chore: Apply Clippy lint redundant_clone using cargo clippy --fix

Author: jbencin

clarity/src/vm/docs/mod.rs

@@ -2734,9 +2734,7 @@ fn make_all_api_reference() -> ReferenceAPIs {
 #[allow(clippy::expect_used)]
 pub fn make_json_api_reference() -> String {
     let api_out = make_all_api_reference();
-    serde_json::to_string(&api_out)
-        .expect("Failed to serialize documentation")
-        .to_string()
+    serde_json::to_string(&api_out).expect("Failed to serialize documentation")
 }
 
 #[cfg(test)]

pox-locking/src/events.rs

@@ -545,7 +545,6 @@ fn create_event_info_data_code(
                     "#,
                     delegate_to = opt
                         .data
-                        .clone()
                         .map(|boxed_value| *boxed_value)
                         .unwrap()
                         .expect_tuple()

stacks-common/src/util/tests.rs

@@ -94,6 +94,6 @@ impl<T: Default + Clone> TestFlag<T> {
     /// assert_eq!(test_flag.get(), 123);
     /// ```
     pub fn get(&self) -> T {
-        self.0.lock().unwrap().clone().unwrap_or_default().clone()
+        self.0.lock().unwrap().clone().unwrap_or_default()
     }
 }

stacks-signer/src/signerdb.rs

@@ -1101,7 +1101,7 @@ mod tests {
             .unwrap()
             .expect("Unable to get block from db");
 
-        assert_eq!(BlockInfo::from(block_proposal_1.clone()), block_info);
+        assert_eq!(BlockInfo::from(block_proposal_1), block_info);
 
         // Test looking up a block with an unknown hash
         let block_info = db
@@ -1116,7 +1116,7 @@ mod tests {
             .unwrap()
             .expect("Unable to get block from db");
 
-        assert_eq!(BlockInfo::from(block_proposal_2.clone()), block_info);
+        assert_eq!(BlockInfo::from(block_proposal_2), block_info);
     }
 
     #[test]
@@ -1543,12 +1543,11 @@ mod tests {
                 &StacksPrivateKey::new(),
             )),
         };
-        let tenure_change_tx_payload =
-            TransactionPayload::TenureChange(tenure_change_payload.clone());
+        let tenure_change_tx_payload = TransactionPayload::TenureChange(tenure_change_payload);
         let tenure_change_tx = StacksTransaction::new(
             TransactionVersion::Testnet,
             TransactionAuth::from_p2pkh(&StacksPrivateKey::new()).unwrap(),
-            tenure_change_tx_payload.clone(),
+            tenure_change_tx_payload,
         );
 
         let consensus_hash_1 = ConsensusHash([0x01; 20]);

testnet/stacks-node/src/burnchains/bitcoin_regtest_controller.rs

@@ -2316,7 +2316,7 @@ impl SerializedTx {
 
     pub fn to_hex(&self) -> String {
         let formatted_bytes: Vec<String> = self.bytes.iter().map(|b| format!("{b:02x}")).collect();
-        formatted_bytes.join("").to_string()
+        formatted_bytes.join("")
     }
 }
 

testnet/stacks-node/src/nakamoto_node/signer_coordinator.rs

@@ -80,7 +80,7 @@ impl SignerCoordinator {
         // Create the stacker DB listener
         let mut listener = StackerDBListener::new(
             stackerdb_channel,
-            node_keep_running.clone(),
+            node_keep_running,
             keep_running.clone(),
             reward_set,
             burn_tip,

testnet/stacks-node/src/neon_node.rs

@@ -2396,7 +2396,7 @@ impl BlockMinerThread {
             &burn_db,
             &self.burn_block,
             &stackerdbs,
-            SignerMessage::MockBlock(mock_block.clone()),
+            SignerMessage::MockBlock(mock_block),
             MinerSlotID::BlockPushed, // There is no specific slot for mock miner messages. Let's use BlockPushed for MockBlock since MockProposal uses BlockProposal.
             self.config.is_mainnet(),
             &mut miners_stackerdb,
@@ -3757,7 +3757,7 @@ impl RelayerThread {
         }
 
         let Some(mut miner_thread_state) =
-            self.create_block_miner(registered_key, last_burn_block.clone(), issue_timestamp_ms)
+            self.create_block_miner(registered_key, last_burn_block, issue_timestamp_ms)
         else {
             return false;
         };