clarified backward compatibility for coinbase checks

rdeioris · rdeioris · commit f47976ef5d86 · 2025-07-22T20:32:34.000+02:00
diff --git a/stackslib/src/chainstate/nakamoto/mod.rs b/stackslib/src/chainstate/nakamoto/mod.rs
@@ -4856,6 +4856,8 @@ impl NakamotoChainState {
         }
 
         // for sip-031 we append the mint event to the coinbase
+        // note that the above coinbase checks are left with index assumptions (get_mut(0))
+        // for backward compatibility (even if since nakamoto the coinbase is at index 1)
         if let Some(event) = sip31_event {
             if let Some(coinbase_receipt) = tx_receipts
                 .iter_mut()

Original file line number	Diff line number	Diff line change
`@@ -4856,6 +4856,8 @@ impl NakamotoChainState {`
`4856`	`4856`	`}`
`4857`	`4857`
`4858`	`4858`	`// for sip-031 we append the mint event to the coinbase`
	`4859`	`+ // note that the above coinbase checks are left with index assumptions (get_mut(0))`
	`4860`	`+ // for backward compatibility (even if since nakamoto the coinbase is at index 1)`
`4859`	`4861`	`if let Some(event) = sip31_event {`
`4860`	`4862`	`if let Some(coinbase_receipt) = tx_receipts`
`4861`	`4863`	`.iter_mut()`