Skip to content

Commit fbce54a

Browse files
committed
fix: off-by-one in failsafe descendency check
1 parent d70d554 commit fbce54a

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

stacks-signer/src/v0/signer_state.rs

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1272,14 +1272,20 @@ impl LocalStateMachine {
12721272
Some(d) => d,
12731273
};
12741274

1275-
let Ok(mut parent_burn_block_info) =
1276-
db.get_burn_block_by_ch(&new_burn_block.consensus_hash)
1277-
else {
1278-
warn!(
1279-
"Failed to get parent burn block info for {}",
1280-
new_burn_block.consensus_hash
1281-
);
1282-
return Ok(false);
1275+
let mut parent_burn_block_info = match db
1276+
.get_burn_block_by_ch(&new_burn_block.consensus_hash)
1277+
.and_then(|burn_block_info| {
1278+
db.get_burn_block_by_hash(&burn_block_info.parent_burn_block_hash)
1279+
}) {
1280+
Ok(info) => info,
1281+
Err(e) => {
1282+
warn!(
1283+
"Failed to get parent burn block info for {}",
1284+
new_burn_block.consensus_hash;
1285+
"error" => ?e,
1286+
);
1287+
return Ok(false);
1288+
}
12831289
};
12841290

12851291
for _ in 0..height_delta {

0 commit comments

Comments
 (0)