chore: remove the @ symbol

Author: chrisbbreuer

src/pr/pr-generator.ts

@@ -567,7 +567,8 @@ export class PullRequestGenerator {
           }
 
           if (release.author) {
-            body += `*Released by [@${release.author}](https://github.com/${release.author}) on ${new Date(release.date).toLocaleDateString()}*\n\n`
+            // Strip '@' in rendered text to avoid accidental pings
+            body += `*Released by [${release.author}](https://github.com/${release.author}) on ${new Date(release.date).toLocaleDateString()}*\n\n`
           }
         }
       }
@@ -963,7 +964,8 @@ export class PullRequestGenerator {
     // Negative lookbehind avoids letters, numbers, dot, slash, underscore before @ (emails/paths)
     // Negative lookahead avoids treating trailing slash or part of longer tokens
     protectedText = protectedText.replace(/(?<![\w./])@([A-Z0-9-]+)(?![A-Z0-9-])/gi, (_m, user: string) => {
-      return `[@${user}](https://github.com/${user})`
+      // Strip '@' in rendered text to prevent any possibility of pings
+      return `[${user}](https://github.com/${user})`
     })
 
     // Restore inline code placeholders

test/pr-mention-sanitization.test.ts

@@ -53,13 +53,13 @@ describe('PR mention sanitization', () => {
     const group = makeGroup()
     const body: string = await gen.generateBody(group)
 
-    // Plain mentions converted
-    expect(body).toContain('[@sokra](https://github.com/sokra)')
-    expect(body).toContain('[@mischnic](https://github.com/mischnic)')
+    // Plain mentions converted (without '@' in rendered text)
+    expect(body).toContain('[sokra](https://github.com/sokra)')
+    expect(body).toContain('[mischnic](https://github.com/mischnic)')
 
-    // No raw @mention should remain in non-code text for those users (allow inside markdown link [@user])
-    expect(body).not.toMatch(/(?<!\[)@sokra/)
-    expect(body).not.toMatch(/(?<!\[)@mischnic/)
+    // No raw @mention should remain anywhere in non-code text
+    expect(body).not.toMatch(/@sokra/)
+    expect(body).not.toMatch(/@mischnic/)
 
     // Inline code preserved
     expect(body).toContain('`doSomething(@nochange)`')