chore: wip

Revert "chore: wip"

This reverts commit 3024439.

chore: wip

chore: wip

Author: chrisbbreuer

src/utils/dependency-file-parser.ts

@@ -129,9 +129,17 @@ async function parseSimpleYamlDependencies(content: string, filePath: string): P
 export async function updateDependencyFile(filePath: string, content: string, updates: PackageUpdate[]): Promise<string> {
   try {
     if (!isDependencyFile(filePath)) {
+      console.log(`⚠️ updateDependencyFile: ${filePath} is not a dependency file, returning original content`)
       return content
     }
 
+    // Extra safety check: ensure we're not accidentally processing non-YAML content
+    if (content.trim().startsWith('{') && content.includes('"require"')) {
+      console.log(`⚠️ updateDependencyFile: Content appears to be JSON (composer.json), but file is ${filePath}`)
+      console.log(`Content preview: ${content.substring(0, 200)}`)
+      return content // Don't process JSON content in YAML function
+    }
+
     let updatedContent = content
 
     // Apply updates using string replacement to preserve formatting

test/plugin-architecture.test.ts

@@ -9,8 +9,16 @@ describe('Integration Ecosystem & Plugin Architecture', () => {
   let pluginManager: PluginManager
   let mockContext: SetupContext
   let originalEnv: Record<string, string | undefined>
+  let originalCwd: string
 
   beforeEach(() => {
+    // Store original working directory
+    originalCwd = process.cwd()
+    
+    // Change to a temporary directory to avoid interference with project files
+    const tempDir = fs.mkdtempSync(path.join(require('node:os').tmpdir(), 'plugin-test-'))
+    process.chdir(tempDir)
+    
     pluginManager = new PluginManager()
     mockContext = {
       step: 'setup_complete',
@@ -58,18 +66,43 @@ describe('Integration Ecosystem & Plugin Architecture', () => {
     delete process.env.JIRA_TOKEN
     delete process.env.JIRA_URL
 
-    // Clean up any .buddy files that might exist
+    // Clean up any .buddy files that might exist (critical for plugin detection)
     if (fs.existsSync('.buddy')) {
       fs.rmSync('.buddy', { recursive: true, force: true })
     }
+
+    // Also clean up specific plugin trigger files that might exist in the working directory
+    const pluginFiles = ['.buddy/slack-webhook', '.buddy/jira-config.json', '.buddy/discord-webhook']
+    pluginFiles.forEach((file) => {
+      if (fs.existsSync(file)) {
+        fs.rmSync(file, { force: true })
+      }
+    })
   })
 
   afterEach(() => {
-    // Clean up test files
+    // Clean up test files in temp directory
     if (fs.existsSync('.buddy')) {
       fs.rmSync('.buddy', { recursive: true, force: true })
     }
 
+    // Clean up specific plugin trigger files
+    const pluginFiles = ['.buddy/slack-webhook', '.buddy/jira-config.json', '.buddy/discord-webhook']
+    pluginFiles.forEach((file) => {
+      if (fs.existsSync(file)) {
+        fs.rmSync(file, { force: true })
+      }
+    })
+    
+    // Restore original working directory and clean up temp directory
+    const tempDir = process.cwd()
+    process.chdir(originalCwd)
+    try {
+      fs.rmSync(tempDir, { recursive: true, force: true })
+    } catch {
+      // Ignore cleanup errors
+    }
+
     // Restore original environment variables
     if (originalEnv.SLACK_WEBHOOK_URL !== undefined) {
       process.env.SLACK_WEBHOOK_URL = originalEnv.SLACK_WEBHOOK_URL
@@ -135,6 +168,9 @@ describe('Integration Ecosystem & Plugin Architecture', () => {
         console.log(`  - JIRA_PROJECT_KEY: ${process.env.JIRA_PROJECT_KEY ? 'SET' : 'UNSET'}`)
         console.log('File system check:')
         console.log(`  - .buddy exists: ${fs.existsSync('.buddy')}`)
+        console.log(`  - .buddy/slack-webhook exists: ${fs.existsSync('.buddy/slack-webhook')}`)
+        console.log(`  - .buddy/jira-config.json exists: ${fs.existsSync('.buddy/jira-config.json')}`)
+        console.log(`  - .buddy/discord-webhook exists: ${fs.existsSync('.buddy/discord-webhook')}`)
         if (fs.existsSync('.buddy')) {
           try {
             const buddyFiles = fs.readdirSync('.buddy', { recursive: true })
@@ -211,7 +247,7 @@ describe('Integration Ecosystem & Plugin Architecture', () => {
         expect(process.env.DISCORD_WEBHOOK_URL).toBeUndefined()
         expect(process.env.JIRA_API_TOKEN).toBeUndefined()
 
-        // Create custom plugin configuration
+        // Create custom plugin configuration (without handler function since it can't be serialized)
         fs.mkdirSync('.buddy/plugins', { recursive: true })
         const customPlugin = {
           name: 'custom-integration',
@@ -223,18 +259,20 @@ describe('Integration Ecosystem & Plugin Architecture', () => {
               name: 'custom-hook',
               priority: 15,
               async: false,
-              handler() {
-                console.log('Custom hook executed')
-              },
+              // Note: handler function would be loaded dynamically in real usage
             },
           ],
           configuration: { custom_setting: 'value' },
         }
 
-        fs.writeFileSync(
-          path.join('.buddy/plugins', 'custom.json'),
-          JSON.stringify(customPlugin),
-        )
+        const customPluginPath = path.join('.buddy/plugins', 'custom.json')
+        fs.writeFileSync(customPluginPath, JSON.stringify(customPlugin))
+
+        // Verify the file was written correctly
+        expect(fs.existsSync(customPluginPath)).toBe(true)
+        const writtenContent = fs.readFileSync(customPluginPath, 'utf8')
+        const parsedContent = JSON.parse(writtenContent)
+        expect(parsedContent).toEqual(customPlugin)
 
         // Create a fresh PluginManager instance to avoid state pollution
         const freshPluginManager = new PluginManager()
@@ -254,13 +292,25 @@ describe('Integration Ecosystem & Plugin Architecture', () => {
             const files = fs.readdirSync('.buddy/plugins')
             files.forEach(f => console.log(`  - ${f}`))
 
-            // Read the custom plugin file to verify its contents
-            const content = fs.readFileSync('.buddy/plugins/custom-integration.json', 'utf8')
-            console.log('Custom plugin file content:', content)
+            // Read the custom plugin file to verify its contents (use correct filename)
+            const content = fs.readFileSync('.buddy/plugins/custom.json', 'utf8')
+            console.log('Custom plugin file content:', content.substring(0, 200))
+            const parsed = JSON.parse(content)
+            console.log('Parsed plugin name:', parsed.name)
           }
           catch (err) {
             console.log('Error reading .buddy/plugins:', err)
           }
+
+          // Test the loadCustomPlugins method directly
+          try {
+            const directPlugins = await (freshPluginManager as any).loadCustomPlugins()
+            console.log('Direct loadCustomPlugins result:', directPlugins.length)
+            directPlugins.forEach((p: any) => console.log(`  Direct: ${p.name}`))
+          }
+          catch (err) {
+            console.log('Direct loadCustomPlugins error:', err)
+          }
         }
 
         expect(customPlugins).toHaveLength(1)

test/respect-latest.test.ts

@@ -11,8 +11,9 @@ describe('respectLatest functionality', () => {
   let testDir: string
 
   beforeEach(() => {
-    // Create temporary test directory
-    testDir = fs.mkdtempSync('buddy-test-')
+    // Create temporary test directory in a more isolated location
+    // eslint-disable-next-line ts/no-require-imports
+    testDir = fs.mkdtempSync(path.join(require('node:os').tmpdir(), 'buddy-test-'))
   })
 
   afterEach(() => {
@@ -88,8 +89,15 @@ devDependencies:
     const depsPath = path.join(testDir, 'deps.yaml')
     fs.writeFileSync(depsPath, depsYaml)
 
+    // Ensure the file was written correctly and verify content
+    const actualFileContent = fs.readFileSync(depsPath, 'utf-8')
+    expect(actualFileContent).toBe(depsYaml) // Verify file content is correct
+
     // Test the dependency file respectLatest logic
-    const { updateDependencyFile } = await import('../src/utils/dependency-file-parser')
+    const { updateDependencyFile, isDependencyFile } = await import('../src/utils/dependency-file-parser')
+
+    // Verify file detection works correctly
+    expect(isDependencyFile(depsPath)).toBe(true)
 
     // Create mock updates
     const updates = [
@@ -111,36 +119,29 @@ devDependencies:
       },
     ]
 
-    // Read the original content using a try-catch to handle potential mocking conflicts
-    let originalContent: string
-    try {
-      originalContent = fs.readFileSync(depsPath, 'utf-8')
-    }
-    catch {
-      // If there's a mocking conflict, use the content directly
-      originalContent = depsYaml
-    }
-
     // Debug info for CI troubleshooting - Check before calling updateDependencyFile
     console.log('🔍 Test setup verification:')
     console.log('  - File path:', depsPath)
     console.log('  - File exists:', fs.existsSync(depsPath))
-    console.log('  - Original content preview:', originalContent.substring(0, 100))
-    // eslint-disable-next-line ts/no-require-imports
-    console.log('  - isDependencyFile result:', require('../src/utils/dependency-file-parser').isDependencyFile(depsPath))
+    console.log('  - Original content preview:', actualFileContent.substring(0, 100))
+    console.log('  - isDependencyFile result:', isDependencyFile(depsPath))
+    console.log('  - Content is YAML format:', !actualFileContent.trim().startsWith('{'))
 
     // Test that dynamic versions are respected (not updated)
-    const updatedContent = await updateDependencyFile(depsPath, originalContent, updates)
+    // Use the verified file content directly to avoid any file reading issues
+    const updatedContent = await updateDependencyFile(depsPath, actualFileContent, updates)
 
     // Debug info for CI troubleshooting
     if (!updatedContent.includes('python.org: "*"')) {
       console.log('🚨 Expected deps.yaml format, but got different format:')
-      console.log('Updated content length:', updatedContent.length)
-      console.log('Updated content preview:', updatedContent.substring(0, 500))
+      console.log('Input content length:', actualFileContent.length)
+      console.log('Input content preview:', actualFileContent.substring(0, 200))
+      console.log('Output content length:', updatedContent.length)
+      console.log('Output content preview:', updatedContent.substring(0, 500))
+      console.log('Content types match:', typeof actualFileContent, typeof updatedContent)
 
       // Check if the file path is being resolved correctly
-      // eslint-disable-next-line ts/no-require-imports
-      const absolutePath = require('node:path').resolve(depsPath)
+      const absolutePath = path.resolve(depsPath)
       console.log('Absolute path:', absolutePath)
       console.log('Working directory:', process.cwd())