chore: several dashboard improvements

chrisbbreuer · chrisbbreuer · commit 6012d18f8719 · 2025-07-26T21:59:31.000-07:00
chore: wip

chore: wip

chore: wip

chore: wip

chore: wip

chore: wip

chore: wip

chore: wip

chore: wip

chore: wip

chore: wip

chore: wip
diff --git a/src/buddy.ts b/src/buddy.ts
@@ -760,15 +760,11 @@ export class Buddy {
           assignees: dashboardConfig.assignees,
         })
 
-        // Pin the issue if configured (even if it's an existing issue)
+        // Note: GitHub REST API does not support pinning issues programmatically
+        // Users need to pin the dashboard issue manually through the GitHub UI
         if (dashboardConfig.pin) {
-          try {
-            await gitProvider.pinIssue(issue.number)
-            this.logger.info(`📌 Pinned existing dashboard issue #${issue.number}`)
-          }
-          catch (error) {
-            this.logger.warn(`Failed to pin dashboard issue: ${error}`)
-          }
+          this.logger.info(`💡 To pin dashboard issue #${issue.number}, please do so manually in the GitHub UI`)
+          this.logger.info(`📌 Go to: ${issue.url} and click "Pin issue" in the right sidebar`)
         }
       }
       else {
@@ -782,15 +778,11 @@ export class Buddy {
           assignees: dashboardConfig.assignees,
         })
 
-        // Pin the issue if configured
+        // Note: GitHub REST API does not support pinning issues programmatically
+        // Users need to pin the dashboard issue manually through the GitHub UI
         if (dashboardConfig.pin) {
-          try {
-            await gitProvider.pinIssue(issue.number)
-            this.logger.info(`📌 Pinned new dashboard issue #${issue.number}`)
-          }
-          catch (error) {
-            this.logger.warn(`Failed to pin dashboard issue: ${error}`)
-          }
+          this.logger.info(`💡 To pin dashboard issue #${issue.number}, please do so manually in the GitHub UI`)
+          this.logger.info(`📌 Go to: ${issue.url} and click "Pin issue" in the right sidebar`)
         }
       }
 
@@ -814,9 +806,15 @@ export class Buddy {
 
     // Filter PRs to only include dependency updates (likely created by buddy-bot)
     const dependencyPRs = openPRs.filter(pr =>
-      pr.labels.includes('dependencies')
-      || pr.title.toLowerCase().includes('update')
-      || pr.title.toLowerCase().includes('chore(deps)'),
+      // Exclude Renovate PRs
+      !pr.author.toLowerCase().includes('renovate')
+      && !pr.head.includes('renovate/')
+      && !pr.title.toLowerCase().includes('renovate')
+      && (
+        pr.labels.includes('dependencies')
+        || pr.title.toLowerCase().includes('update')
+        || pr.title.toLowerCase().includes('chore(deps)')
+      ),
     )
 
     // Categorize package files
diff --git a/src/dashboard/dashboard-generator.ts b/src/dashboard/dashboard-generator.ts
@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import type { DashboardData, PackageFile, PullRequest } from '../types'
 
 export class DashboardGenerator {
@@ -42,10 +43,10 @@ export class DashboardGenerator {
   /**
    * Generate the default header section
    */
-  private generateDefaultHeader(data: DashboardData): string {
-    const portalUrl = `https://developer.mend.io/github/${data.repository.owner}/${data.repository.name}`
+  private generateDefaultHeader(_data: DashboardData): string {
+    // const portalUrl = `https://developer.mend.io/github/${data.repository.owner}/${data.repository.name}`
 
-    return `This issue lists Buddy Bot updates and detected dependencies. Read the [Dependency Dashboard](https://buddy-bot.sh/features/dependency-dashboard) docs to learn more.<br/>[View this repository on the Mend.io Web Portal](${portalUrl}).
+    return `This issue lists Buddy Bot updates and detected dependencies. Read the [Dependency Dashboard](https://buddy-bot.sh/features/dependency-dashboard) docs to learn more.
 
 `
   }
@@ -72,6 +73,7 @@ The following updates have all been created. To force a retry/rebase of any, cli
 
       section += ` - [ ] <!-- rebase-branch=${rebaseBranch} -->[${pr.title}](${relativeUrl})`
 
+      // Show clean package names like Renovate does (without version info)
       if (packageInfo.length > 0) {
         section += ` (\`${packageInfo.join('`, `')}\`)`
       }
@@ -247,58 +249,219 @@ The following updates have all been created. To force a retry/rebase of any, cli
   }
 
   /**
-   * Extract package names from PR title or body
+   * Extract package names from PR title or body (like Renovate does)
    */
   private extractPackageInfo(pr: PullRequest): string[] {
     const packages: string[] = []
 
-    // Try to extract from title patterns like "update dependency react to v18"
-    const titleMatch = pr.title.match(/update.*?dependency\s+(\w+)/i)
-    if (titleMatch) {
-      packages.push(titleMatch[1])
+    // Add logging for debugging the real issue
+    const isTargetPR = pr.title.includes('update all non-major dependencies')
+    if (isTargetPR) {
+      console.log(`\n🔍 DEBUG: Extracting from PR #${pr.number}`)
+      console.log(`📝 Title: "${pr.title}"`)
+      console.log(`📄 Body preview: "${pr.body.substring(0, 200)}..."\n`)
     }
 
-    // Extract from the enhanced PR body format
-    // Look for table entries like: | [package-name](url) | version change | badges |
-    const tableMatches = pr.body.match(/\|\s*\[([^\]]+)\]/g)
-    if (tableMatches) {
-      for (const match of tableMatches) {
-        const packageMatch = match.match(/\|\s*\[([^\]]+)\]/)
-        if (packageMatch) {
-          const packageName = packageMatch[1]
-          // Skip if it's a URL, badge, or contains special characters that indicate it's not a package name
-          if (!packageName.includes('://')
-            && !packageName.includes('Compare Source')
-            && !packageName.includes('badge')
-            && !packageName.includes('!')
-            && !packageName.startsWith('[![')
-            && !packages.includes(packageName)) {
-            packages.push(packageName)
+    // Pattern 1: Extract from common dependency update titles
+    // Examples: "chore(deps): update dependency react to v18"
+    //           "chore(deps): update all non-major dependencies"
+    //           "update @types/node to v20"
+    const titlePatterns = [
+      /update.*?dependency\s+(\S+)/i,
+      /update\s+(\S+)\s+to\s+v?\d+/i,
+      /bump\s+(\S+)\s+from/i,
+    ]
+
+    for (const pattern of titlePatterns) {
+      const match = pr.title.match(pattern)
+      if (match && match[1] && !packages.includes(match[1])) {
+        packages.push(match[1])
+        if (isTargetPR)
+          console.log(`✅ Title match: "${match[1]}"`)
+      }
+    }
+
+    // Pattern 2: Extract from table format in PR body - handle all table sections
+    // Look for different table types: npm Dependencies, Launchpad/pkgx Dependencies, GitHub Actions
+
+    // Split the body into sections and process each table
+    const tableSections = [
+      // npm Dependencies table
+      { name: 'npm', pattern: /### npm Dependencies[\s\S]*?(?=###|\n\n---|z)/i },
+      // Launchpad/pkgx Dependencies table
+      { name: 'pkgx', pattern: /### Launchpad\/pkgx Dependencies[\s\S]*?(?=###|\n\n---|z)/i },
+      // GitHub Actions table
+      { name: 'actions', pattern: /### GitHub Actions[\s\S]*?(?=###|\n\n---|z)/i },
+    ]
+
+    for (const section of tableSections) {
+      const sectionMatch = pr.body.match(section.pattern)
+      if (sectionMatch) {
+        const sectionContent = sectionMatch[0]
+        if (isTargetPR)
+          console.log(`📊 Found ${section.name} section`)
+
+        // Extract package names from this section's table
+        const tableRowMatches = sectionContent.match(/\|\s*\[([^\]]+)\]\([^)]+\)\s*\|/g)
+        if (tableRowMatches) {
+          if (isTargetPR) {
+            console.log(`📊 ${section.name} table matches: ${tableRowMatches.length}`)
+            console.log(`📋 Raw ${section.name} matches:`, JSON.stringify(tableRowMatches))
+          }
+
+          for (const match of tableRowMatches) {
+            const packageMatch = match.match(/\|\s*\[([^\]]+)\]/)
+            if (packageMatch && packageMatch[1]) {
+              const packageName = packageMatch[1].trim()
+
+              if (isTargetPR) {
+                console.log(`🔍 Checking ${section.name}: "${packageName}"`)
+              }
+
+              // Check if this looks like a version string - if so, try to extract package name from URL
+              if (packageName.includes('`') && packageName.includes('->')) {
+                // This is a version string like "`1.2.17` -> `1.2.19`"
+                // Try to extract the package name from the URL
+                const urlMatch = match.match(/\]\(([^)]+)\)/)
+                if (urlMatch && urlMatch[1]) {
+                  const url = urlMatch[1]
+                  if (isTargetPR) {
+                    console.log(`🔗 Extracting from URL: "${url}"`)
+                  }
+
+                  // Extract package name from Renovate diff URLs like:
+                  // https://renovatebot.com/diffs/npm/%40types%2Fbun/1.2.17/1.2.19
+                  // https://renovatebot.com/diffs/npm/cac/6.7.13/6.7.14
+                  const diffUrlMatch = url.match(/\/diffs\/npm\/([^/]+)\//)
+                  if (diffUrlMatch && diffUrlMatch[1]) {
+                    // Decode URL encoding like %40types%2Fbun -> @types/bun
+                    const extractedPackage = decodeURIComponent(diffUrlMatch[1])
+                    if (isTargetPR) {
+                      console.log(`📦 Extracted from URL: "${extractedPackage}"`)
+                    }
+
+                    if (extractedPackage && extractedPackage.length > 1 && !packages.includes(extractedPackage)) {
+                      packages.push(extractedPackage)
+                      if (isTargetPR)
+                        console.log(`✅ ${section.name} (from URL): "${extractedPackage}"`)
+                    }
+                  }
+                  else if (isTargetPR) {
+                    console.log(`❌ Could not extract package from URL: "${url}"`)
+                  }
+                }
+                continue // Skip the normal processing for version strings
+              }
+
+              // Normal processing for direct package names
+              // Skip if it's a URL, badge, or contains special characters
+              // CRITICAL: Skip version strings like "`1.2.17` -> `1.2.19`"
+              if (!packageName.includes('://')
+                && !packageName.includes('Compare Source')
+                && !packageName.includes('badge')
+                && !packageName.includes('!')
+                && !packageName.startsWith('[![')
+                && !packageName.includes('`') // Skip anything with backticks (version strings)
+                && !packageName.includes('->') // Skip version arrows
+                && !packageName.includes(' -> ') // Skip spaced version arrows
+                && !packageName.match(/^\d+\.\d+/) // Skip version numbers
+                && !packageName.includes(' ') // Package names shouldn't have spaces
+                && packageName.length > 0
+                && !packages.includes(packageName)) {
+                packages.push(packageName)
+                if (isTargetPR)
+                  console.log(`✅ ${section.name}: "${packageName}"`)
+              }
+              else if (isTargetPR) {
+                console.log(`❌ ${section.name} skipped: "${packageName}" (likely version string)`)
+              }
+            }
+          }
+        }
+        else if (isTargetPR) {
+          console.log(`❌ No table matches in ${section.name} section`)
+          // Let's also try a simpler approach - look for table rows with package names
+          const simpleRowMatches = sectionContent.match(/^\|\s*\[([^\]]+)\]/gm)
+          if (simpleRowMatches) {
+            console.log(`🔄 Trying simpler pattern, found ${simpleRowMatches.length} rows:`, JSON.stringify(simpleRowMatches))
           }
         }
       }
+      else if (isTargetPR) {
+        console.log(`❌ No ${section.name} section found`)
+      }
     }
 
-    // Fallback: try to extract from simple backtick patterns
-    if (packages.length === 0) {
+    // Pattern 3: Extract from PR body - look for package names in backticks (avoid table content)
+    // This handles cases where the title doesn't contain specific package names
+    // but the body lists them like: `@types/bun`, `cac`, `ts-pkgx`
+    if (packages.length < 3) { // Allow backtick extraction to supplement table extraction
       const bodyMatches = pr.body.match(/`([^`]+)`/g)
       if (bodyMatches) {
+        if (isTargetPR) {
+          console.log(`🔍 Backtick matches (${bodyMatches.length}):`)
+          console.log(JSON.stringify(bodyMatches.slice(0, 10))) // Show first 10
+        }
+
         for (const match of bodyMatches) {
-          const content = match.replace(/`/g, '')
-          // Only extract if it looks like a package name (no version arrows, URLs, or special chars)
-          if (!content.includes('->')
-            && !content.includes('://')
-            && !content.includes(' ')
-            && !content.includes('Compare Source')
-            && content.length > 0
-            && !packages.includes(content)) {
-            packages.push(content)
+          let packageName = match.replace(/`/g, '').trim()
+
+          // Skip anything that looks like version information
+          if (packageName.includes('->')
+            || packageName.includes(' -> ')
+            || packageName.includes('` -> `')
+            || packageName.match(/^\d+\.\d+/) // Starts with version number
+            || packageName.match(/^v\d+/) // Version tags
+            || packageName.match(/[\d.]+\s*->\s*[\d.]+/) // Version arrows
+            || packageName.match(/^[\d.]+$/) // Pure version numbers like "1.2.17"
+            || packageName.match(/^\d+\.\d+\.\d+/) // Semver patterns
+            || packageName.match(/^\d+\.\d+\.\d+\./) // Longer version patterns
+            || packageName.match(/^\^?\d+\.\d+/) // Version ranges like "^1.2.3"
+            || packageName.match(/^~\d+\.\d+/) // Tilde version ranges
+            || packageName.includes('://') // URLs with protocol
+            || packageName.includes('Compare Source')
+            || packageName.includes('badge')
+            || packageName.includes(' ')) { // Package names shouldn't have spaces
+            if (isTargetPR)
+              console.log(`❌ Skipped: "${packageName}"`)
+            continue
+          }
+
+          // Clean up the package name - take first part only
+          packageName = packageName.split(',')[0].trim()
+
+          // Only include if it looks like a valid package/dependency name
+          if (packageName
+            && packageName.length > 1
+            && !packages.includes(packageName)
+            && (
+          // Must match one of these patterns for valid package names:
+              packageName.startsWith('@') // Scoped packages like @types/node
+              || packageName.includes('/') // GitHub actions like actions/checkout
+              || packageName.match(/^[a-z][a-z0-9.-]*$/i) // Simple package names like lodash, ts-pkgx, bun.com
+            )) {
+            packages.push(packageName)
+            if (isTargetPR)
+              console.log(`✅ Added: "${packageName}"`)
+          }
+          else if (isTargetPR) {
+            console.log(`❌ Failed validation: "${packageName}"`)
           }
         }
       }
+      else if (isTargetPR) {
+        console.log(`❌ No backtick matches found`)
+      }
+    }
+    else if (isTargetPR) {
+      console.log(`⏭️ Skipping backticks (have ${packages.length} packages)`)
     }
 
-    return packages.slice(0, 5) // Limit to first 5 packages to keep it clean
+    // NO LIMIT - return all packages like Renovate does
+    if (isTargetPR) {
+      console.log(`\n📋 FINAL RESULT: ${JSON.stringify(packages)} (${packages.length} packages)\n`)
+    }
+    return packages
   }
 
   /**
diff --git a/src/git/github-provider.ts b/src/git/github-provider.ts
@@ -658,29 +658,17 @@ export class GitHubProvider implements GitProvider {
     }
   }
 
-  async pinIssue(issueNumber: number): Promise<void> {
-    try {
-      // GitHub's pin/unpin issue API requires special headers and is relatively new
-      await this.apiRequest(`PUT /repos/${this.owner}/${this.repo}/issues/${issueNumber}/pin`, undefined)
-
-      console.log(`✅ Pinned issue #${issueNumber}`)
-    }
-    catch (error) {
-      console.warn(`⚠️ Failed to pin issue #${issueNumber}:`, error)
-      // Don't throw error for pinning failures as it's not critical
-    }
-  }
-
   async unpinIssue(issueNumber: number): Promise<void> {
     try {
-      // GitHub's pin/unpin issue API requires special headers and is relatively new
       await this.apiRequest(`DELETE /repos/${this.owner}/${this.repo}/issues/${issueNumber}/pin`, undefined)
-
-      console.log(`✅ Unpinned issue #${issueNumber}`)
     }
-    catch (error) {
-      console.warn(`⚠️ Failed to unpin issue #${issueNumber}:`, error)
-      // Don't throw error for unpinning failures as it's not critical
+    catch (error: any) {
+      console.log(`⚠️ Failed to unpin issue #${issueNumber}:`, error)
+      // Don't throw error for pinning failures as it's not critical
     }
   }
+
+  // Note: GitHub REST API does not support pinning issues programmatically
+  // Pinning can only be done manually through the GitHub web interface
+  // See: https://docs.github.com/en/issues/tracking-your-work-with-issues/administering-issues/pinning-an-issue-to-your-repository
 }
diff --git a/src/git/gitlab-provider.ts b/src/git/gitlab-provider.ts
@@ -97,13 +97,8 @@ export class GitLabProvider implements GitProvider {
     console.log(`Would close issue #${issueNumber}`)
   }
 
-  async pinIssue(issueNumber: number): Promise<void> {
-    // TODO: Implement GitLab API call to pin issue
-    console.log(`Would pin issue #${issueNumber}`)
-  }
-
-  async unpinIssue(issueNumber: number): Promise<void> {
-    // TODO: Implement GitLab API call to unpin issue
-    console.log(`Would unpin issue #${issueNumber}`)
+  async unpinIssue(_issueNumber: number): Promise<void> {
+    // GitLab doesn't have issue pinning functionality
+    console.log(`ℹ️ GitLab does not support issue pinning`)
   }
 }
diff --git a/src/types.ts b/src/types.ts
diff --git a/test/dashboard-generator.test.ts b/test/dashboard-generator.test.ts

Original file line number	Diff line number	Diff line change
`@@ -97,13 +97,8 @@ export class GitLabProvider implements GitProvider {`
`97`	`97`	console.log(`Would close issue #${issueNumber}`)
`98`	`98`	`}`
`99`	`99`
`100`		`- async pinIssue(issueNumber: number): Promise<void> {`
`101`		`- // TODO: Implement GitLab API call to pin issue`
`102`		- console.log(`Would pin issue #${issueNumber}`)
`103`		`- }`
`104`		`-`
`105`		`- async unpinIssue(issueNumber: number): Promise<void> {`
`106`		`- // TODO: Implement GitLab API call to unpin issue`
`107`		- console.log(`Would unpin issue #${issueNumber}`)
	`100`	`+ async unpinIssue(_issueNumber: number): Promise<void> {`
	`101`	`+ // GitLab doesn't have issue pinning functionality`
	`102`	+ console.log(`ℹ️ GitLab does not support issue pinning`)
`108`	`103`	`}`
`109`	`104`	`}`