chore: improve handling of large pr bodies

Author: chrisbbreuer

src/buddy.ts

@@ -422,63 +422,77 @@ export class Buddy {
 
     // Handle package.json updates - only for actual package.json files, not dependency or GitHub Actions files
     const packageJsonUpdates = updates.filter(update =>
-      update.file === 'package.json'
+      update.file.endsWith('package.json')
       && !update.file.includes('.yaml')
       && !update.file.includes('.yml')
       && !update.file.includes('.github/workflows/'),
     )
-    if (packageJsonUpdates.length > 0) {
-      const packageJsonPath = 'package.json'
 
-      // Read current package.json content as string to preserve formatting
-      let packageJsonContent = fs.readFileSync(packageJsonPath, 'utf-8')
-
-      // Parse to understand structure
-      const packageJson = JSON.parse(packageJsonContent)
-
-      // Apply updates using string replacement to preserve formatting
-      for (const update of packageJsonUpdates) {
-        let packageFound = false
-
-        // Clean package name (remove dependency type info like "(dev)")
-        const cleanPackageName = update.name.replace(/\s*\(dev\)$/, '').replace(/\s*\(peer\)$/, '').replace(/\s*\(optional\)$/, '')
-
-        // Try to find and update the package in each dependency section
-        const dependencySections = ['dependencies', 'devDependencies', 'peerDependencies', 'optionalDependencies']
-
-        for (const section of dependencySections) {
-          if (packageJson[section] && packageJson[section][cleanPackageName]) {
-            const currentVersionInFile = packageJson[section][cleanPackageName]
-
-            // Extract the original version prefix (^, ~, >=, etc.) or lack thereof
-            const versionPrefixMatch = currentVersionInFile.match(/^(\D*)/)
-            const originalPrefix = versionPrefixMatch ? versionPrefixMatch[1] : ''
+    // Group package.json updates by file
+    const updatesByPackageFile = new Map<string, PackageUpdate[]>()
+    for (const update of packageJsonUpdates) {
+      if (!updatesByPackageFile.has(update.file)) {
+        updatesByPackageFile.set(update.file, [])
+      }
+      updatesByPackageFile.get(update.file)!.push(update)
+    }
 
-            // Create regex to find the exact line with this package and version
-            // This handles various formatting styles like: "package": "version", "package":"version", etc.
-            const packageRegex = new RegExp(
-              `("${cleanPackageName.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}"\\s*:\\s*")([^"]+)(")`,
-              'g',
-            )
+    // Process each package.json file
+    for (const [packageJsonPath, packageUpdates] of updatesByPackageFile) {
+      try {
+        // Read current package.json content as string to preserve formatting
+        let packageJsonContent = fs.readFileSync(packageJsonPath, 'utf-8')
+
+        // Parse to understand structure
+        const packageJson = JSON.parse(packageJsonContent)
+
+        // Apply updates using string replacement to preserve formatting
+        for (const update of packageUpdates) {
+          let packageFound = false
+
+          // Clean package name (remove dependency type info like "(dev)")
+          const cleanPackageName = update.name.replace(/\s*\(dev\)$/, '').replace(/\s*\(peer\)$/, '').replace(/\s*\(optional\)$/, '')
+
+          // Try to find and update the package in each dependency section
+          const dependencySections = ['dependencies', 'devDependencies', 'peerDependencies', 'optionalDependencies']
+
+          for (const section of dependencySections) {
+            if (packageJson[section] && packageJson[section][cleanPackageName]) {
+              const currentVersionInFile = packageJson[section][cleanPackageName]
+
+              // Extract the original version prefix (^, ~, >=, etc.) or lack thereof
+              const versionPrefixMatch = currentVersionInFile.match(/^(\D*)/)
+              const originalPrefix = versionPrefixMatch ? versionPrefixMatch[1] : ''
+
+              // Create regex to find the exact line with this package and version
+              // This handles various formatting styles like: "package": "version", "package":"version", etc.
+              const packageRegex = new RegExp(
+                `("${cleanPackageName.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}"\\s*:\\s*")([^"]+)(")`,
+                'g',
+              )
+
+              // Preserve the original prefix when updating to new version
+              const newVersion = `${originalPrefix}${update.newVersion}`
+              packageJsonContent = packageJsonContent.replace(packageRegex, `$1${newVersion}$3`)
+              packageFound = true
+              break
+            }
+          }
 
-            // Preserve the original prefix when updating to new version
-            const newVersion = `${originalPrefix}${update.newVersion}`
-            packageJsonContent = packageJsonContent.replace(packageRegex, `$1${newVersion}$3`)
-            packageFound = true
-            break
+          if (!packageFound) {
+            console.warn(`Package ${cleanPackageName} not found in ${packageJsonPath}`)
           }
         }
 
-        if (!packageFound) {
-          console.warn(`Package ${cleanPackageName} not found in package.json`)
-        }
+        fileUpdates.push({
+          path: packageJsonPath,
+          content: packageJsonContent,
+          type: 'update' as const,
+        })
+      }
+      catch (error) {
+        console.warn(`Failed to update ${packageJsonPath}:`, error)
       }
-
-      fileUpdates.push({
-        path: packageJsonPath,
-        content: packageJsonContent,
-        type: 'update' as const,
-      })
     }
 
     // Handle dependency file updates (deps.yaml, dependencies.yaml, etc.)

src/pr/pr-generator.ts

@@ -469,6 +469,21 @@ export class PullRequestGenerator {
     body += `---\n\n`
     body += `This PR was generated by [Buddy](https://github.com/stacksjs/buddy-bot) 🤖`
 
+    // Ensure PR body doesn't exceed GitHub's 65,536 character limit
+    const MAX_BODY_LENGTH = 60000 // Leave some buffer
+    if (body.length > MAX_BODY_LENGTH) {
+      const truncatedBody = body.substring(0, MAX_BODY_LENGTH)
+      const lastDetailsEnd = truncatedBody.lastIndexOf('</details>')
+      if (lastDetailsEnd > 0) {
+        // Truncate at the last complete details section
+        body = `${truncatedBody.substring(0, lastDetailsEnd + 10)}\n\n---\n\n**Note**: This PR body was truncated due to GitHub's character limit. View the full details in the individual commits.\n\n`
+      }
+      else {
+        body = `${truncatedBody}\n\n---\n\n**Note**: This PR body was truncated due to GitHub's character limit.\n\n`
+      }
+      body += `This PR was generated by [Buddy](https://github.com/stacksjs/buddy-bot) 🤖`
+    }
+
     return body
   }