chore: adjust tests

chore: wip

chore: wip

chore: wip

chore: wip

chore: wip

chore: wip

Author: chrisbbreuer

test/composer-registry.test.ts

@@ -32,7 +32,7 @@ describe('RegistryClient - Composer Integration', () => {
     // Mock file system operations
     spyOn(fs, 'existsSync').mockReturnValue(true)
     spyOn(fs, 'readFileSync').mockReturnValue(JSON.stringify({
-      require: {
+      'require': {
         'php': '^8.1',
         'laravel/framework': '^10.0',
         'guzzlehttp/guzzle': '^7.0',

test/configuration-migration.test.ts

@@ -1,28 +1,42 @@
 import type { MigrationResult } from '../src/setup'
 import { afterEach, beforeEach, describe, expect, it, spyOn } from 'bun:test'
 import fs from 'node:fs'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
 import { ConfigurationMigrator } from '../src/setup'
 
 describe('Configuration Migration & Import System', () => {
   let migrator: ConfigurationMigrator
+  let testDir: string
+  let originalCwd: string
 
   beforeEach(() => {
+    // Create a temporary directory for each test
+    testDir = fs.mkdtempSync(join(tmpdir(), 'buddy-config-test-'))
+    originalCwd = process.cwd()
+    process.chdir(testDir)
+
     migrator = new ConfigurationMigrator()
   })
 
   afterEach(() => {
-    // Clean up test files - DO NOT DELETE the real package.json!
-    const testFiles = ['renovate.json', '.renovaterc', 'test-package.json', '.github/dependabot.yml']
-    testFiles.forEach((file) => {
-      if (fs.existsSync(file)) {
-        try {
-          fs.unlinkSync(file)
-        }
-        catch {
-          // Ignore cleanup errors
-        }
+    // Change back to original directory and clean up
+    try {
+      process.chdir(originalCwd)
+    }
+    catch {
+      // If we can't change back, try a safe directory
+      try {
+        process.chdir(tmpdir())
       }
-    })
+      catch {
+        process.chdir('/')
+      }
+    }
+
+    if (fs.existsSync(testDir)) {
+      fs.rmSync(testDir, { recursive: true, force: true })
+    }
   })
 
   describe('Tool Detection', () => {

test/dependency-files-integration.test.ts

@@ -1,6 +1,8 @@
 import type { BuddyBotConfig, PackageUpdate } from '../src/types'
 import { afterAll, beforeAll, describe, expect, it } from 'bun:test'
-import { existsSync, unlinkSync, writeFileSync } from 'node:fs'
+import { existsSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
 import { Buddy } from '../src/buddy'
 import { isDependencyFile, parseDependencyFile, updateDependencyFile } from '../src/utils/dependency-file-parser'
 
@@ -10,7 +12,9 @@ describe('Dependency Files Integration Tests', () => {
     packages: { strategy: 'all' },
   }
 
-  const testDepsFile = 'test-deps.yaml'
+  let testDir: string
+  let testDepsFile: string
+  let originalCwd: string
   const testDepsContent = `dependencies:
   lodash: ^4.17.20
   react: ^17.0.0
@@ -19,14 +23,42 @@ devDependencies:
   typescript: ^4.9.0`
 
   beforeAll(() => {
+    // Create a temporary directory for test files
+    testDir = mkdtempSync(join(tmpdir(), 'buddy-deps-test-'))
+    originalCwd = process.cwd()
+    process.chdir(testDir)
+
+    testDepsFile = 'test-deps.yaml'
     // Create a test dependency file
     writeFileSync(testDepsFile, testDepsContent)
   })
 
   afterAll(() => {
-    // Clean up test files
-    if (existsSync(testDepsFile)) {
-      unlinkSync(testDepsFile)
+    // Change back to original directory and clean up
+    try {
+      // Only change directory if the original directory still exists
+      if (existsSync(originalCwd)) {
+        process.chdir(originalCwd)
+      }
+      else {
+        // If original directory doesn't exist, change to a safe directory
+        process.chdir(tmpdir())
+      }
+    }
+    catch {
+      // If we can't change to the original directory, try to change to a safe directory
+      try {
+        process.chdir(tmpdir())
+      }
+      catch {
+        // If all else fails, change to root
+        process.chdir('/')
+      }
+    }
+
+    // Clean up test directory
+    if (existsSync(testDir)) {
+      rmSync(testDir, { recursive: true, force: true })
     }
   })
 

test/package-scanner-ignore-paths.test.ts

@@ -20,19 +20,22 @@ describe('PackageScanner IgnorePaths Integration', () => {
     try {
       // Change back to original directory first, before deleting the test directory
       process.chdir(originalCwd)
-    } catch (error) {
+    }
+    catch {
       // If we can't change back to original directory, try to change to a safe directory
       try {
         process.chdir(tmpdir())
-      } catch {
+      }
+      catch {
         // If all else fails, change to root
         process.chdir('/')
       }
     }
 
     try {
       await fs.rm(testDir, { recursive: true, force: true })
-    } catch (error) {
+    }
+    catch (error) {
       // Ignore cleanup errors - the temp directory will be cleaned up by the OS eventually
       console.warn(`Failed to clean up test directory ${testDir}:`, error)
     }