chore: use bun semver

Author: chrisbbreuer

src/buddy.ts

@@ -422,6 +422,12 @@ export class Buddy {
             // const originalPrefix = prefixMatch ? prefixMatch[1] : ''
             const constraintVersion = dep.constraint.replace(/^[\^~>=<]+/, '')
 
+            // Ensure we only propose upgrades, never downgrades
+            if (!this.isNewerVersion(constraintVersion, dep.version)) {
+              this.logger.debug(`Skipping ${dep.name} - latest (${dep.version}) is not newer than constraint (${constraintVersion})`)
+              continue
+            }
+
             // Determine update type
             const updateType = this.getUpdateType(constraintVersion, dep.version)
 
@@ -552,27 +558,31 @@ export class Buddy {
       const cleanCurrent = current.replace(/^[v^~>=<@]+/, '')
       const cleanLatest = latest.replace(/^[v^~>=<@]+/, '')
 
-      const currentParts = cleanCurrent.split('.').map((part) => {
-        const num = Number(part)
-        return Number.isNaN(num) ? 0 : num
-      })
-      const latestParts = cleanLatest.split('.').map((part) => {
-        const num = Number(part)
-        return Number.isNaN(num) ? 0 : num
-      })
+      if (Bun.semver.order(cleanLatest, cleanCurrent) <= 0)
+        return 'patch'
 
-      // Ensure we have at least major.minor.patch structure
-      while (currentParts.length < 3) currentParts.push(0)
-      while (latestParts.length < 3) latestParts.push(0)
+      if (Bun.semver.satisfies(cleanLatest, `~${cleanCurrent}`))
+        return 'patch'
 
-      if (latestParts[0] > currentParts[0])
-        return 'major'
-      if (latestParts[0] === currentParts[0] && latestParts[1] > currentParts[1])
+      if (Bun.semver.satisfies(cleanLatest, `^${cleanCurrent}`))
         return 'minor'
+
+      return 'major'
+    }
+    catch {
       return 'patch'
     }
+  }
+
+  /**
+   * Check if latest version is strictly newer than current
+   */
+  private isNewerVersion(current: string, latest: string): boolean {
+    try {
+      return Bun.semver.order(latest.replace(/^[v^~>=<@]+/, ''), current.replace(/^[v^~>=<@]+/, '')) > 0
+    }
     catch {
-      return 'patch' // Default to patch if parsing fails
+      return false
     }
   }
 

src/pr/pr-generator.ts

@@ -969,31 +969,21 @@ export class PullRequestGenerator {
     const cleanCurrent = currentVersion.replace(/^[v^~>=<@]+/, '')
     const cleanNew = newVersion.replace(/^[v^~>=<@]+/, '')
 
-    const currentParts = cleanCurrent.split('.').map((part) => {
-      const num = Number(part)
-      return Number.isNaN(num) ? 0 : num
-    })
-    const newParts = cleanNew.split('.').map((part) => {
-      const num = Number(part)
-      return Number.isNaN(num) ? 0 : num
-    })
+    try {
+      if (Bun.semver.order(cleanNew, cleanCurrent) <= 0)
+        return 'patch'
 
-    // Ensure we have at least major.minor.patch structure
-    while (currentParts.length < 3) currentParts.push(0)
-    while (newParts.length < 3) newParts.push(0)
+      if (Bun.semver.satisfies(cleanNew, `~${cleanCurrent}`))
+        return 'patch'
 
-    // Compare major version
-    if (newParts[0] > currentParts[0]) {
-      return 'major'
+      if (Bun.semver.satisfies(cleanNew, `^${cleanCurrent}`))
+        return 'minor'
     }
-
-    // Compare minor version
-    if (newParts[0] === currentParts[0] && newParts[1] > currentParts[1]) {
-      return 'minor'
+    catch {
+      return 'patch'
     }
 
-    // Everything else is patch
-    return 'patch'
+    return 'major'
   }
 
   /**

src/utils/helpers.ts

@@ -305,45 +305,44 @@ export function getUpdateType(currentVersion: string, newVersion: string): 'majo
   const cleanCurrent = currentVersion.replace(/^[v^~>=<@]+/, '')
   const cleanNew = newVersion.replace(/^[v^~>=<@]+/, '')
 
-  // Handle version ranges with @ (like @1.1, @1, etc.)
-  // For @1.1 -> 3.5.0, current should be interpreted as 1.1
-  const currentParts = cleanCurrent.split('.').map((part) => {
-    const num = Number(part)
-    return Number.isNaN(num) ? 0 : num
-  })
-  const newParts = cleanNew.split('.').map((part) => {
-    const num = Number(part)
-    return Number.isNaN(num) ? 0 : num
-  })
-
-  // Ensure we have at least major.minor.patch structure
-  while (currentParts.length < 3) currentParts.push(0)
-  while (newParts.length < 3) newParts.push(0)
+  // If not an upgrade or equal, treat as patch (no-op or bugfix)
+  try {
+    if (Bun.semver.order(cleanNew, cleanCurrent) <= 0)
+      return 'patch'
+  }
+  catch {
+    // Fallback to patch if semver fails
+    return 'patch'
+  }
 
-  // Compare major version
-  if (newParts[0] > currentParts[0]) {
-    return 'major'
+  // Patch: within same minor series
+  try {
+    if (Bun.semver.satisfies(cleanNew, `~${cleanCurrent}`))
+      return 'patch'
   }
+  catch {}
 
-  // Compare minor version
-  if (newParts[0] === currentParts[0] && newParts[1] > currentParts[1]) {
-    return 'minor'
+  // Minor: within same major series
+  try {
+    if (Bun.semver.satisfies(cleanNew, `^${cleanCurrent}`))
+      return 'minor'
   }
+  catch {}
 
-  // Everything else is patch
-  return 'patch'
+  // Otherwise major
+  return 'major'
 }
 
 /**
  * Check if version satisfies semver range
  */
 export function satisfiesRange(version: string, range: string): boolean {
-  // This is a simplified implementation
-  // In production, use a proper semver library
-  const cleanVersion = version.replace(/^[\^~>=<]+/, '')
-  const cleanRange = range.replace(/^[\^~>=<]+/, '')
-
-  return cleanVersion === cleanRange
+  try {
+    return Bun.semver.satisfies(version, range)
+  }
+  catch {
+    return false
+  }
 }
 
 /**