chore: wip

Author: chrisbbreuer

src/setup.ts

@@ -463,17 +463,17 @@ export class PluginManager {
   }
 
   private async hasSlackWebhook(): Promise<boolean> {
-    return process.env.SLACK_WEBHOOK_URL !== undefined
+    return (process.env.SLACK_WEBHOOK_URL !== undefined && process.env.SLACK_WEBHOOK_URL !== '')
       || fs.existsSync('.buddy/slack-webhook')
   }
 
   private async hasJiraIntegration(): Promise<boolean> {
-    return process.env.JIRA_API_TOKEN !== undefined
+    return (process.env.JIRA_API_TOKEN !== undefined && process.env.JIRA_API_TOKEN !== '')
       || fs.existsSync('.buddy/jira-config.json')
   }
 
   private async hasDiscordWebhook(): Promise<boolean> {
-    return process.env.DISCORD_WEBHOOK_URL !== undefined
+    return (process.env.DISCORD_WEBHOOK_URL !== undefined && process.env.DISCORD_WEBHOOK_URL !== '')
       || fs.existsSync('.buddy/discord-webhook')
   }
 

test/plugin-architecture.test.ts

@@ -55,18 +55,28 @@ describe('Integration Ecosystem & Plugin Architecture', () => {
       JIRA_PROJECT_KEY: process.env.JIRA_PROJECT_KEY,
     }
 
-    // Clean up test environment variables aggressively
-    delete process.env.SLACK_WEBHOOK_URL
-    delete process.env.DISCORD_WEBHOOK_URL
-    delete process.env.JIRA_API_TOKEN
-    delete process.env.JIRA_BASE_URL
-    delete process.env.JIRA_PROJECT_KEY
-
-    // Also check for any variations that might exist in CI
-    delete process.env.SLACK_WEBHOOK
-    delete process.env.DISCORD_WEBHOOK
-    delete process.env.JIRA_TOKEN
-    delete process.env.JIRA_URL
+    // SUPER aggressive cleanup - delete ALL possible environment variables that could trigger plugin discovery
+    // Note: In GitHub Actions, env vars might be set but empty, so we delete them entirely
+    const envVarsToDelete = [
+      'SLACK_WEBHOOK_URL',
+      'DISCORD_WEBHOOK_URL',
+      'JIRA_API_TOKEN',
+      'JIRA_BASE_URL',
+      'JIRA_PROJECT_KEY',
+      'SLACK_WEBHOOK',
+      'DISCORD_WEBHOOK',
+      'JIRA_TOKEN',
+      'JIRA_URL',
+      // Also check for other variations that might exist in different CI environments
+      'SLACK_URL',
+      'DISCORD_URL',
+      'JIRA_ENDPOINT',
+      'JIRA_HOST',
+    ]
+
+    envVarsToDelete.forEach((envVar) => {
+      delete process.env[envVar]
+    })
 
     // Clean up any .buddy files that might exist (critical for plugin detection)
     if (fs.existsSync('.buddy')) {

test/respect-latest.test.ts

@@ -80,7 +80,7 @@ describe('respectLatest functionality', () => {
     expect(shouldRespectVersion('^1.0.0')).toBe(false)
   })
 
-    it('should test dependency file respectLatest logic', async () => {
+  it('should test dependency file respectLatest logic', async () => {
     // Test the dependency file respectLatest logic directly without file system operations
     // This avoids the file corruption issue in GitHub Actions environment
     const { updateDependencyFile, isDependencyFile } = await import('../src/utils/dependency-file-parser')