chore: wip

Author: chrisbbreuer

packages/launchpad/src/binary-downloader.ts

@@ -5,6 +5,7 @@ import * as fs from 'node:fs'
 import * as path from 'node:path'
 import process from 'node:process'
 import { config } from './config'
+import type { GitHubRelease } from './types'
 
 export interface BinaryInfo {
   filename: string
@@ -216,10 +217,10 @@ export class PrecompiledBinaryDownloader {
         throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
       }
 
-      const release = await response.json()
+      const release = await response.json() as GitHubRelease
 
       // Find manifest.json in release assets
-      const manifestAsset = release.assets?.find((asset: any) => asset.name === 'manifest.json')
+      const manifestAsset = release.assets?.find((asset) => asset.name === 'manifest.json')
       if (!manifestAsset) {
         throw new Error('No manifest.json found in latest release')
       }
@@ -230,11 +231,11 @@ export class PrecompiledBinaryDownloader {
         throw new Error(`Failed to download manifest: ${manifestResponse.statusText}`)
       }
 
-      const manifest: BinaryManifest = await manifestResponse.json()
+      const manifest = await manifestResponse.json() as BinaryManifest
 
       // Add download URLs to binaries
       manifest.binaries = manifest.binaries.map((binary) => {
-        const asset = release.assets?.find((asset: any) => asset.name === binary.filename)
+        const asset = release.assets?.find((asset) => asset.name === binary.filename)
         return {
           ...binary,
           download_url: asset?.browser_download_url || '',

packages/launchpad/src/config.ts

@@ -168,17 +168,6 @@ export const defaultConfig: LaunchpadConfig = {
         timeout: 600000, // 10 minutes
         debug: false,
       },
-      libraryFixes: {
-        systemLibraryPaths: [
-          '/opt/homebrew/lib',
-          '/usr/local/lib',
-          '/usr/lib',
-        ],
-      },
-      shim: {
-        optimizeLibraryPath: true,
-        environmentVariables: {},
-      },
     },
   },
 }

packages/launchpad/src/dev/dump.ts

@@ -200,7 +200,7 @@ export async function detectLaravelProject(dir: string): Promise<{ isLaravel: bo
   }
 
   // Execute post-setup commands if enabled
-  if (config.services.frameworks.laravel.postSetupCommands.enabled) {
+  if (config.services.frameworks.laravel.postSetupCommands?.enabled) {
     const postSetupResults = await executePostSetupCommands(dir, config.services.frameworks.laravel.postSetupCommands.commands)
     suggestions.push(...postSetupResults)
   }
@@ -264,8 +264,6 @@ function evaluateCommandCondition(condition: PostSetupCommand['condition'], proj
   switch (condition) {
     case 'always':
       return true
-    case 'never':
-      return false
     case 'hasUnrunMigrations':
       return hasUnrunMigrations(projectDir)
     case 'hasSeeders':

packages/launchpad/src/install.ts

@@ -2983,12 +2983,12 @@ async function installPackage(packageName: string, packageSpec: string, installP
     }
 
     // Install all PHP dependencies from ts-pkgx (includes build tools and runtime deps)
-    await installPhpBuildDependencies(installPath)
+    // PHP build dependencies are no longer needed with precompiled binaries
 
     if (config.verbose) {
       console.log('✅ All PHP dependencies ready - starting build...')
     }
-    return await buildPhpFromSource(installPath, requestedVersion)
+    throw new Error('Source builds are no longer supported. Use precompiled binaries instead.')
   }
 
   // Special handling for zlib - disabled, let ts-pkgx handle it

packages/launchpad/src/php/php-shim.ts

@@ -96,14 +96,12 @@ export class PHPShimManager {
     const issues: string[] = []
     const recommendations: string[] = []
 
-    // Add system library paths if they exist
-    for (const libPath of this.phpConfig.libraryFixes.systemLibraryPaths) {
+    // Add common system library paths if they exist
+    const commonLibPaths = ['/opt/homebrew/lib', '/usr/local/lib', '/usr/lib']
+    for (const libPath of commonLibPaths) {
       if (fs.existsSync(libPath)) {
         libraryPaths.push(libPath)
       }
-      else {
-        issues.push(`System library path not found: ${libPath}`)
-      }
     }
 
     // Detect Launchpad environment libraries
@@ -128,14 +126,9 @@ export class PHPShimManager {
     // Add other optimizations
     environmentVariables.DYLD_FALLBACK_LIBRARY_PATH = '/opt/homebrew/lib:/usr/local/lib:/usr/lib'
 
-    // Configure PHP-specific optimizations
-    if (this.phpConfig.shim.optimizeLibraryPath) {
-      environmentVariables.PHP_INI_SCAN_DIR = '/opt/homebrew/etc/php/8.4/conf.d'
-      recommendations.push('Optimized PHP configuration scanning')
-    }
-
-    // Merge user-configured environment variables
-    Object.assign(environmentVariables, this.phpConfig.shim.environmentVariables)
+    // Configure PHP-specific optimizations for precompiled binaries
+    environmentVariables.PHP_INI_SCAN_DIR = '/opt/homebrew/etc/php/8.4/conf.d'
+    recommendations.push('Configured PHP configuration scanning')
 
     return {
       libraryPaths,

packages/launchpad/src/php/php-strategy.ts

@@ -5,7 +5,6 @@
  */
 
 import { getLatestVersion, packages } from 'ts-pkgx'
-import { buildPhpFromSource } from '../install'
 
 /**
  * Get the latest PHP version with fallback logic
@@ -90,39 +89,8 @@ export class SourceBuildPHPStrategy implements PHPStrategy {
       // Store the version for later use
       this.installedVersion = latestVersion
 
-      // Build PHP from source in the current environment
-      const envDir = path.join(os.homedir(), '.local', 'share', 'launchpad', 'envs', 'global')
-      const _installedFiles = await buildPhpFromSource(envDir, latestVersion)
-
-      const phpBinary = path.join(envDir, 'php.net', `v${latestVersion}`, 'bin', 'php')
-
-      // Test the installation
-      const testResult = await this.testPHPInstallation(phpBinary)
-
-      return {
-        success: testResult.success,
-        phpPath: phpBinary,
-        version: testResult.version || latestVersion,
-        extensions: testResult.extensions || [],
-        databaseSupport: {
-          sqlite: true, // Built with SQLite support
-          mysql: true, // Built with MySQL support
-          postgresql: true, // Built with PostgreSQL support
-          extensions: {
-            pdo_sqlite: true,
-            pdo_mysql: true,
-            pdo_pgsql: true,
-            mysqli: true,
-            pgsql: true,
-          },
-        },
-        libraryIssues: [],
-        recommendations: [
-          'PHP built from source with full database support',
-          'All libraries properly linked during compilation',
-          'Ready for Laravel development',
-        ],
-      }
+      // Source builds are no longer supported - use precompiled binaries instead
+      throw new Error('Source builds are no longer supported. Use precompiled binaries via the main install command.')
     }
     catch (error) {
       return {

packages/launchpad/src/types.ts

@@ -1,6 +1,23 @@
 import type { Version } from '../test/version'
 import type { Path } from './path'
 
+// GitHub API types
+export interface GitHubAsset {
+  name: string
+  browser_download_url: string
+  size: number
+  content_type: string
+}
+
+export interface GitHubRelease {
+  tag_name: string
+  name: string
+  body: string
+  assets: GitHubAsset[]
+  draft: boolean
+  prerelease: boolean
+}
+
 export interface LaunchpadConfig {
   /** Enable verbose logging (default: false) */
   verbose: boolean

packages/launchpad/test/deps-yaml-integration.test.ts

@@ -260,7 +260,7 @@ services:
     fs.writeFileSync(path.join(globalDir, 'global-tool'), 'global')
 
     // Test cleanup with the temp directory
-    TestUtils.cleanupEnvironmentDirs(tempDir)
+    TestUtils.cleanupEnvironmentDirs()
 
     // Test environment should be cleaned
     expect(fs.existsSync(testEnvDir)).toBe(false)

packages/launchpad/test/end-to-end-integration.test.ts

@@ -126,26 +126,12 @@ dependencies:
         // Import the Homebrew-style PHP build function
         const installModule = await import('../src/install')
 
-        // Check if the function exists
-        if (typeof installModule.buildPhpFromSource === 'function') {
-          const installPath = path.join(testHome, '.local', 'share', 'launchpad', 'envs', 'test-env')
-          fs.mkdirSync(installPath, { recursive: true })
-
-          // In test mode, we expect this to handle gracefully
-          try {
-            const result = await installModule.buildPhpFromSource(installPath, '8.4.0')
-            expect(result).toBeDefined()
-            expect(Array.isArray(result)).toBe(true)
-          }
-          catch (error) {
-            // In test mode, source building may fail but should be handled gracefully
-            expect(error instanceof Error).toBe(true)
-          }
-        }
-        else {
-          // Function not exported yet, test passes by checking it exists in structure
-          expect(typeof installModule).toBe('object')
-        }
+        // Source builds are no longer supported - test that error is thrown appropriately
+        // Note: buildPhpFromSource function has been removed
+        expect(true).toBe(true) // Placeholder test since source builds are removed
+
+        // Function not exported since source builds are no longer supported
+        expect(typeof installModule).toBe('object')
       }
       catch (importError) {
         // If import fails, that's a test failure we need to address

packages/launchpad/test/install-deps-only.test.ts

@@ -115,8 +115,8 @@ describe('Install Dependencies Only', () => {
 
       // Should mention both packages
       const logCalls = mockConsoleLog.mock.calls.flat()
-      expect(logCalls.some(call => call.includes('php'))).toBe(true)
-      expect(logCalls.some(call => call.includes('nodejs'))).toBe(true)
+      expect(logCalls.some((call: any) => call.includes('php'))).toBe(true)
+      expect(logCalls.some((call: any) => call.includes('nodejs'))).toBe(true)
     })
 
     it('should handle empty package list gracefully', async () => {
@@ -130,7 +130,7 @@ describe('Install Dependencies Only', () => {
     it('should handle packages with no dependencies', async () => {
       // Mock a package with no dependencies
       const tempPantry = { ...mockPantry }
-      tempPantry.test = { dependencies: [] }
+      ;(tempPantry as any).test = { dependencies: [] }
 
       const packages = ['test']
       const results = await installDependenciesOnly(packages, tempDir)
@@ -148,7 +148,7 @@ describe('Install Dependencies Only', () => {
 
       // Should warn about missing package
       const warnCalls = mockConsoleWarn.mock.calls.flat()
-      expect(warnCalls.some(call => call.includes('not found in pantry'))).toBe(true)
+      expect(warnCalls.some((call: any) => call.includes('not found in pantry'))).toBe(true)
     })
 
     it('should use provided install path', async () => {
@@ -167,7 +167,7 @@ describe('Install Dependencies Only', () => {
 
       // Should not mention installing PHP itself, only dependencies
       const logCalls = mockConsoleLog.mock.calls.flat()
-      const installMainPackage = logCalls.some(call =>
+      const installMainPackage = logCalls.some((call: any) =>
         call.includes('Installing php') && !call.includes('dependencies'),
       )
       expect(installMainPackage).toBe(false)
@@ -227,7 +227,7 @@ describe('Install Dependencies Only', () => {
 
       // Should warn about missing package
       const warnCalls = mockConsoleWarn.mock.calls.flat()
-      expect(warnCalls.some(call => call.includes('not found in pantry'))).toBe(true)
+      expect(warnCalls.some((call: any) => call.includes('not found in pantry'))).toBe(true)
     })
 
     it('should handle individual dependency installation failures', async () => {