chore: wip

Author: chrisbbreuer

.gitignore

@@ -15,3 +15,4 @@ packages/launchpad/bin/launchpad
 packages/launchpad/bin/launchpad*
 packages/launchpad/test/clean-integration-*
 *.bun-build
+/.local

packages/launchpad/src/services/manager.ts

@@ -706,8 +706,30 @@ async function executePostStartCommands(service: ServiceInstance): Promise<void>
     return
   }
 
-  // Wait a moment for the service to be fully ready
-  await new Promise(resolve => setTimeout(resolve, 2000))
+  // Wait for the service to be fully ready, especially for databases
+  if (definition.name === 'postgres' || definition.name === 'mysql') {
+    // For databases, wait longer and check if they're actually ready
+    await new Promise(resolve => setTimeout(resolve, 5000))
+
+    // Try to verify the service is responding before running post-start commands
+    if (definition.healthCheck) {
+      for (let i = 0; i < 5; i++) {
+        try {
+          const healthResult = await checkServiceHealth(service)
+          if (healthResult)
+            break
+        }
+        catch {
+          // Health check failed, wait a bit more
+          await new Promise(resolve => setTimeout(resolve, 1000))
+        }
+      }
+    }
+  }
+  else {
+    // For other services, use the original wait time
+    await new Promise(resolve => setTimeout(resolve, 2000))
+  }
 
   for (const commandTemplate of definition.postStartCommands) {
     try {
@@ -727,7 +749,17 @@ async function executePostStartCommands(service: ServiceInstance): Promise<void>
           env: { ...process.env, ...definition.env },
         })
 
+        // Add timeout for post-start commands (30 seconds max)
+        const timeout = setTimeout(() => {
+          if (config.verbose) {
+            console.warn(`⚠️ Post-start command timed out after 30s: ${resolvedCommand.join(' ')}`)
+          }
+          proc.kill('SIGTERM')
+          resolve()
+        }, 30000)
+
         proc.on('close', (code) => {
+          clearTimeout(timeout)
           if (code === 0) {
             resolve()
           }
@@ -742,6 +774,7 @@ async function executePostStartCommands(service: ServiceInstance): Promise<void>
         })
 
         proc.on('error', (error) => {
+          clearTimeout(timeout)
           if (config.verbose) {
             console.warn(`⚠️ Post-start command error: ${error.message}`)
           }

packages/launchpad/test/binary-stub-isolation.test.ts

@@ -17,7 +17,11 @@ describe('Binary Stub Isolation', () => {
   })
 
   afterEach(() => {
-    process.env = originalEnv
+    // Restore environment variables properly without replacing the entire process.env object
+    Object.keys(process.env).forEach((key) => {
+      delete process.env[key]
+    })
+    Object.assign(process.env, originalEnv)
     if (fs.existsSync(tempDir)) {
       fs.rmSync(tempDir, { recursive: true, force: true })
     }

packages/launchpad/test/bootstrap.test.ts

@@ -14,7 +14,11 @@ describe('Bootstrap Command', () => {
   })
 
   afterEach(() => {
-    process.env = originalEnv
+    // Restore environment variables properly without replacing the entire process.env object
+    Object.keys(process.env).forEach((key) => {
+      delete process.env[key]
+    })
+    Object.assign(process.env, originalEnv)
     if (fs.existsSync(tempDir)) {
       fs.rmSync(tempDir, { recursive: true, force: true })
     }

packages/launchpad/test/bun-performance-optimizations.test.ts

@@ -52,7 +52,11 @@ describe('Bun Performance Optimizations', () => {
     if (fs.existsSync(tempDir)) {
       fs.rmSync(tempDir, { recursive: true, force: true })
     }
-    process.env = originalEnv
+    // Restore environment variables properly without replacing the entire process.env object
+    Object.keys(process.env).forEach((key) => {
+      delete process.env[key]
+    })
+    Object.assign(process.env, originalEnv)
     // Clean up global mocks
     delete (globalThis as any).fetch
   })

packages/launchpad/test/bun.test.ts

@@ -70,7 +70,11 @@ describe('Bun', () => {
   })
 
   afterEach(() => {
-    process.env = originalEnv
+    // Restore environment variables properly without replacing the entire process.env object
+    Object.keys(process.env).forEach((key) => {
+      delete process.env[key]
+    })
+    Object.assign(process.env, originalEnv)
     if (fs.existsSync(tempDir)) {
       fs.rmSync(tempDir, { recursive: true, force: true })
     }

packages/launchpad/test/cache-performance.test.ts

@@ -26,7 +26,11 @@ describe('Cache Performance Tests', () => {
   })
 
   afterEach(() => {
-    process.env = originalEnv
+    // Restore environment variables properly without replacing the entire process.env object
+    Object.keys(process.env).forEach((key) => {
+      delete process.env[key]
+    })
+    Object.assign(process.env, originalEnv)
 
     // Clean up temp directory
     try {

packages/launchpad/test/caching-integration.test.ts

@@ -132,7 +132,11 @@ describe('Caching Integration Tests', () => {
   })
 
   afterEach(() => {
-    process.env = originalEnv
+    // Restore environment variables properly without replacing the entire process.env object
+    Object.keys(process.env).forEach((key) => {
+      delete process.env[key]
+    })
+    Object.assign(process.env, originalEnv)
     if (fs.existsSync(tempDir)) {
       fs.rmSync(tempDir, { recursive: true, force: true })
     }

packages/launchpad/test/caching-performance.test.ts

@@ -29,7 +29,11 @@ describe('Caching Performance Benchmarks', () => {
   })
 
   afterEach(() => {
-    process.env = originalEnv
+    // Restore environment variables properly without replacing the entire process.env object
+    Object.keys(process.env).forEach((key) => {
+      delete process.env[key]
+    })
+    Object.assign(process.env, originalEnv)
     if (fs.existsSync(tempDir)) {
       fs.rmSync(tempDir, { recursive: true, force: true })
     }

packages/launchpad/test/caching.test.ts

@@ -29,7 +29,11 @@ describe('Package Caching System', () => {
   })
 
   afterEach(() => {
-    process.env = originalEnv
+    // Restore environment variables properly without replacing the entire process.env object
+    Object.keys(process.env).forEach((key) => {
+      delete process.env[key]
+    })
+    Object.assign(process.env, originalEnv)
     if (fs.existsSync(tempDir)) {
       fs.rmSync(tempDir, { recursive: true, force: true })
     }