chore: wip

Author: chrisbbreuer

.github/workflows/precompile-php.yml

@@ -298,7 +298,7 @@ jobs:
             "-I$(brew --prefix openldap)/include"
           )
           echo "CPPFLAGS=$(IFS=' '; echo "${CPPFLAGS_PATHS[*]}")" >> $GITHUB_ENV
-          echo "CXXFLAGS=-std=c++14 -stdlib=libc++" >> $GITHUB_ENV
+          echo "CXXFLAGS=-std=c++17 -stdlib=libc++" >> $GITHUB_ENV
 
           # Set readline-specific paths
           echo "READLINE_CFLAGS=-I$(brew --prefix readline)/include" >> $GITHUB_ENV
@@ -395,17 +395,26 @@ jobs:
               echo "Debug: LDAP environment variables cleared"
             fi
 
-            # Set C++14 flag for ICU4C compatibility - set explicitly
-            # Only apply C++14 to C++ compiler, not C compiler
-            export CXXFLAGS="-std=c++14 -stdlib=libc++"
+            # Set C++17 flag for ICU4C compatibility - set explicitly
+            # Only apply C++17 to C++ compiler, not C compiler
+            export CXXFLAGS="-std=c++17 -stdlib=libc++"
             # Keep CFLAGS clean for C compiler
             export CFLAGS=""
             export CPPFLAGS="$CPPFLAGS"
-            echo "Set C++14 flags for configure step"
+            echo "Set C++17 flags for configure step"
             echo "CXXFLAGS: $CXXFLAGS"
             echo "CFLAGS: $CFLAGS"
             echo "CPPFLAGS: $CPPFLAGS"
 
+            # Ensure we're using clang++ on macOS
+            if command -v clang++ >/dev/null 2>&1; then
+              export CC=clang
+              export CXX=clang++
+              echo "Using clang/clang++ compilers"
+              echo "CC: $CC"
+              echo "CXX: $CXX"
+            fi
+
             # Try to find readline.h and set the path explicitly
             READLINE_PATH=$(brew --prefix readline)
             if [[ -f "$READLINE_PATH/include/readline/readline.h" ]]; then
@@ -496,13 +505,13 @@ jobs:
           # Use all available CPU cores for faster builds
           if [[ "${{ matrix.platform }}" == "darwin" ]]; then
             JOBS=$(sysctl -n hw.ncpu)
-            # Ensure C++14 is used during build - set explicitly
-            # Only apply C++14 to C++ compiler, not C compiler
-            export CXXFLAGS="-std=c++14 -stdlib=libc++"
+            # Ensure C++17 is used during build - set explicitly
+            # Only apply C++17 to C++ compiler, not C compiler
+            export CXXFLAGS="-std=c++17 -stdlib=libc++"
             # Keep CFLAGS clean for C compiler
             export CFLAGS=""
             export CPPFLAGS="$CPPFLAGS"
-            echo "Set C++14 flags for macOS build"
+            echo "Set C++17 flags for macOS build"
           else
             JOBS=$(nproc)
           fi