chore: wip

Author: chrisbbreuer

.github/workflows/precompile-php.yml

@@ -975,6 +975,14 @@ jobs:
         run: |
           cd binaries/
 
+          # Debug: Show what we have
+          echo "🔍 Current directory structure:"
+          ls -la
+          echo ""
+          echo "🔍 Looking for tar.gz files:"
+          find . -name "*.tar.gz" -type f
+          echo ""
+
           # Create a manifest of all built binaries
           cat > manifest.json << EOF
           {
@@ -985,31 +993,61 @@ jobs:
           EOF
 
           first=true
-          for dir in */; do
-            if [[ -f "$dir"*.tar.gz ]]; then
-              if [[ $first == "false" ]]; then
-                echo "," >> manifest.json
-              fi
-              tarball=$(ls "$dir"*.tar.gz | head -1)
-              filename=$(basename "$tarball")
-              size=$(stat -c%s "$tarball" 2>/dev/null || stat -f%z "$tarball")
-
-              # Extract metadata from tarball if available
-              tar -xzOf "$tarball" "*/metadata.json" > temp_metadata.json 2>/dev/null || echo '{}' > temp_metadata.json
-
-              echo "      {" >> manifest.json
-              echo "        \"filename\": \"$filename\"," >> manifest.json
-              echo "        \"size\": $size," >> manifest.json
-              cat temp_metadata.json | sed 's/^/        /' | sed '1s/^        {//' | sed '$s/$//' >> manifest.json
-              echo "      }" >> manifest.json
-              first=false
+          # Find all tar.gz files recursively
+          for tarball in $(find . -name "*.tar.gz" -type f); do
+            if [[ $first == "false" ]]; then
+              echo "," >> manifest.json
+            fi
+
+            filename=$(basename "$tarball")
+            size=$(stat -c%s "$tarball" 2>/dev/null || stat -f%z "$tarball")
+
+            echo "Processing: $filename (size: $size bytes)"
+
+            # Extract metadata from tarball if available
+            tar -xzOf "$tarball" "*/metadata.json" > temp_metadata.json 2>/dev/null || echo '{}' > temp_metadata.json
+
+            # Parse the binary name to extract components
+            # Expected format: php-8.4.11-darwin-arm64-laravel-mysql.tar.gz
+            binary_name=$(echo "$filename" | sed 's/\.tar\.gz$//')
+
+            # Extract components from binary name
+            if [[ "$binary_name" =~ ^php-([^-]+)-([^-]+)-([^-]+)-(.+)$ ]]; then
+              php_version="${BASH_REMATCH[1]}"
+              platform="${BASH_REMATCH[2]}"
+              architecture="${BASH_REMATCH[3]}"
+              configuration="${BASH_REMATCH[4]}"
+            else
+              # Fallback if pattern doesn't match
+              php_version="unknown"
+              platform="unknown"
+              architecture="unknown"
+              configuration="unknown"
             fi
+
+            echo "      {" >> manifest.json
+            echo "        \"filename\": \"$filename\"," >> manifest.json
+            echo "        \"size\": $size," >> manifest.json
+            echo "        \"php_version\": \"$php_version\"," >> manifest.json
+            echo "        \"platform\": \"$platform\"," >> manifest.json
+            echo "        \"architecture\": \"$architecture\"," >> manifest.json
+            echo "        \"configuration\": \"$configuration\"," >> manifest.json
+            echo "        \"built_at\": \"$(date -u +%Y-%m-%dT%H:%M:%SZ)\"," >> manifest.json
+            echo "        \"extensions\": \"$(cat temp_metadata.json | jq -r '.extensions // ""' 2>/dev/null || echo '')\"" >> manifest.json
+            echo "      }" >> manifest.json
+            first=false
           done
 
           echo "    ]" >> manifest.json
           echo "  }" >> manifest.json
 
+          echo ""
+          echo "📋 Generated manifest.json:"
           cat manifest.json
+          echo ""
+          echo "📊 Summary:"
+          echo "  - Total binaries found: $(find . -name "*.tar.gz" -type f | wc -l)"
+          echo "  - Manifest file size: $(stat -c%s manifest.json 2>/dev/null || stat -f%z manifest.json) bytes"
 
       - name: Create GitHub Release
         uses: softprops/action-gh-release@v1

packages/launchpad/src/binary-downloader.ts

@@ -248,26 +248,47 @@ export class PrecompiledBinaryDownloader {
   private async downloadManifest(): Promise<BinaryManifest> {
     console.log('📋 Downloading precompiled binary manifest...')
 
-    const manifestUrl = `${this.GITHUB_API}/repos/${this.GITHUB_REPO}/releases/latest`
+    // First, get all releases to find the latest binaries release
+    const releasesUrl = `${this.GITHUB_API}/repos/${this.GITHUB_REPO}/releases`
 
     try {
-      const response = await fetch(manifestUrl, {
+      const releasesResponse = await fetch(releasesUrl, {
         headers: {
           'User-Agent': 'Launchpad Binary Downloader',
           'Accept': 'application/vnd.github.v3+json',
         },
       })
 
-      if (!response.ok) {
-        throw new Error(`GitHub API error: ${response.status} ${response.statusText}`)
+      if (!releasesResponse.ok) {
+        if (releasesResponse.status === 403) {
+          throw new Error('GitHub API rate limit exceeded. Please try again later.')
+        }
+        throw new Error(`GitHub API error: ${releasesResponse.status} ${releasesResponse.statusText}`)
       }
 
-      const release = await response.json() as GitHubRelease
+      const releases = await releasesResponse.json() as GitHubRelease[]
+
+      // Find the latest release with binaries- prefix
+      const binariesReleases = releases.filter(release =>
+        release.tag_name.startsWith('binaries-'),
+      ).sort((a, b) => {
+        // Sort by release number (binaries-1234)
+        const aNum = Number.parseInt(a.tag_name.replace('binaries-', ''), 10)
+        const bNum = Number.parseInt(b.tag_name.replace('binaries-', ''), 10)
+        return bNum - aNum // Latest first
+      })
+
+      if (binariesReleases.length === 0) {
+        throw new Error('No binaries releases found. The precompile workflow may not have run yet.')
+      }
+
+      const binariesRelease = binariesReleases[0]
+      console.log(`📦 Found binaries release: ${binariesRelease.tag_name}`)
 
       // Find manifest.json in release assets
-      const manifestAsset = release.assets?.find(asset => asset.name === 'manifest.json')
+      const manifestAsset = binariesRelease.assets?.find(asset => asset.name === 'manifest.json')
       if (!manifestAsset) {
-        throw new Error('No manifest.json found in latest release')
+        throw new Error('No manifest.json found in binaries release')
       }
 
       // Download manifest content
@@ -280,12 +301,21 @@ export class PrecompiledBinaryDownloader {
 
       // Add download URLs to binaries
       manifest.binaries = manifest.binaries.map((binary) => {
-        const asset = release.assets?.find(asset => asset.name === binary.filename)
+        const asset = binariesRelease.assets?.find(asset => asset.name === binary.filename)
+        if (!asset) {
+          console.warn(`⚠️ No asset found for binary: ${binary.filename}`)
+        }
         return {
           ...binary,
           download_url: asset?.browser_download_url || '',
         }
-      })
+      }).filter(binary => binary.download_url) // Remove binaries without download URLs
+
+      console.log(`📋 Manifest loaded: ${manifest.binaries.length} binaries available`)
+
+      if (manifest.binaries.length === 0) {
+        throw new Error('No valid binaries found in manifest. The release may be incomplete.')
+      }
 
       return manifest
     }
@@ -391,7 +421,7 @@ export class PrecompiledBinaryDownloader {
    */
   private generateDiscordErrorMessage(detectedConfig: string, platform: string, architecture: string): string {
     return `
-🚨 **Unsupported PHP Configuration Detected**
+🚨 **PHP Binary Not Available**
 
 We don't have a precompiled binary for your setup yet. Please help us improve!
 
@@ -405,9 +435,19 @@ We don't have a precompiled binary for your setup yet. Please help us improve!
 2. Share this error in the #launchpad channel
 3. Tell us about your project setup so we can add support
 
-**Workaround:**
-- Launchpad will automatically fall back to source compilation
-- This will take longer but will work for your configuration
+**Available Configurations:**
+- laravel-mysql: Laravel with MySQL/MariaDB
+- laravel-postgres: Laravel with PostgreSQL
+- laravel-sqlite: Laravel with SQLite
+- api-only: Minimal API applications
+- enterprise: Full-featured enterprise build
+- wordpress: WordPress-optimized
+- full-stack: Complete PHP with all major extensions
+
+**Next Steps:**
+- Try a different PHP version if available
+- Check if your platform/architecture is supported
+- Request support for your specific configuration
 
 Thanks for helping us make Launchpad better! 🙏
     `.trim()
@@ -549,16 +589,31 @@ Thanks for helping us make Launchpad better! 🙏
       if (!binary) {
         const platform = this.getPlatform()
         const arch = this.getArchitecture()
-        const detectedConfig = this.detectFrameworkAndDatabase()
+        const detectedConfig = await this.detectFrameworkAndDatabase()
+
+        // Show available binaries for debugging
+        const availableBinaries = manifest.binaries.filter(b =>
+          b.platform === platform && b.architecture === arch,
+        )
+
+        console.log(`\n🔍 Available binaries for ${platform}-${arch}:`)
+        if (availableBinaries.length > 0) {
+          availableBinaries.forEach((b) => {
+            console.log(`  - PHP ${b.php_version} (${b.configuration})`)
+          })
+        }
+        else {
+          console.log(`  ❌ No binaries available for ${platform}-${arch}`)
+        }
 
         // Generate helpful Discord error message
-        const discordMessage = this.generateDiscordErrorMessage(await detectedConfig, platform, arch)
+        const discordMessage = this.generateDiscordErrorMessage(detectedConfig, platform, arch)
         console.log(`\n${discordMessage}\n`)
 
         throw new Error(
           `No precompiled binary found for ${platform}-${arch} with ${detectedConfig} configuration${
             requestedVersion ? ` and PHP ${requestedVersion}` : ''
-          }. See Discord message above for help.`,
+          }. See available binaries above and Discord message for help.`,
         )
       }
 

packages/launchpad/src/install-core.ts

@@ -223,41 +223,30 @@ export async function installPackage(packageName: string, packageSpec: string, i
     return await installMeilisearch(installPath, requestedVersion)
   }
 
-  // Special handling for PHP - use precompiled binaries for speed
+  // Special handling for PHP - use precompiled binaries from GitHub
   if (name === 'php' || domain === 'php.net') {
-    try {
-      if (config.verbose) {
-        console.warn(`Installing PHP from precompiled binaries for ${name}`)
-      }
+    console.log('🐘 Installing PHP using precompiled binaries from GitHub...')
 
+    try {
       // Import the binary downloader
-      const { downloadPhpBinary, PrecompiledBinaryDownloader } = await import('./binary-downloader')
+      const { downloadPhpBinary } = await import('./binary-downloader')
 
-      // Check if precompiled binaries are available
-      const downloader = new PrecompiledBinaryDownloader(installPath)
-      const isSupported = await downloader.isSupported()
-
-      if (isSupported) {
-        console.log('🚀 Using precompiled PHP binaries...')
-        return await downloadPhpBinary(installPath, requestedVersion)
-      }
-      else {
-        console.warn('🔧 Custom extensions detected: falling back to source build. Nudge us or open an issue if you need this!')
-        throw new Error('Source builds are no longer supported. Use precompiled binaries instead. If you need this, nudge us or open an issue!')
-      }
+      // Always use precompiled binaries for PHP
+      return await downloadPhpBinary(installPath, requestedVersion)
     }
     catch (error) {
-      if (config.verbose) {
-        console.log(`⚠️ Binary download failed: ${error instanceof Error ? error.message : String(error)}`)
-      }
-    }
+      const errorMessage = error instanceof Error ? error.message : String(error)
+      console.error(`❌ Failed to install PHP from precompiled binaries: ${errorMessage}`)
 
-    // CRITICAL: Install ALL PHP dependencies FIRST before building
-    if (config.verbose) {
-      console.log('🔧 Setting up build environment for PHP...')
-    }
+      // Provide helpful error message
+      console.log('\n💡 Troubleshooting:')
+      console.log('1. Check your internet connection')
+      console.log('2. Verify that the precompile workflow has run recently')
+      console.log('3. Try a different PHP version if available')
+      console.log('4. Join our Discord for help: https://discord.gg/stacksjs')
 
-    throw new Error('Source builds are no longer supported. Use precompiled binaries instead.')
+      throw new Error(`PHP installation failed: ${errorMessage}`)
+    }
   }
 
   if (config.verbose) {