chore: wip

Author: chrisbbreuer

packages/launchpad/src/bun.ts

@@ -291,13 +291,10 @@ export async function install_bun(installPath: string, version?: string): Promis
 
   try {
     if (cachedArchivePath) {
-      // Use cached version
+      // Use cached version - show success message directly without intermediate loading message
       if (config.verbose) {
         console.warn(`Using cached Bun v${bunVersion} from: ${cachedArchivePath}`)
       }
-      else {
-        console.log(`📦 Using cached Bun v${bunVersion}...`)
-      }
 
       // Copy cached file to temp directory for extraction
       zipPath = path.join(tempDir, filename)

packages/launchpad/src/install.ts

@@ -32,6 +32,12 @@ function cleanupSpinner(): void {
   }
 }
 
+// Function to clean up all lingering processing messages at the end
+function cleanupAllProcessingMessages(): void {
+  cleanupSpinner()
+  // Additional cleanup can be added here if needed
+}
+
 // Setup signal handlers for clean exit
 function setupSignalHandlers(): void {
   process.on('SIGINT', () => {
@@ -103,19 +109,22 @@ function logUniqueMessage(message: string, forceLog = false): void {
   if (!config.verbose && message.startsWith('✅') && !message.includes('Environment activated')) {
     // Add a small delay to make the success message visible before showing processing message
     setTimeout(() => {
-      const processingMsg = `🔄 Processing next dependency...`
+      // Only show processing message if we haven't completed all packages
+      if (!hasTemporaryProcessingMessage) {
+        const processingMsg = `🔄 Processing next dependency...`
 
-      if (process.env.LAUNCHPAD_SHELL_INTEGRATION === '1') {
-        process.stderr.write(`${processingMsg}\n`)
-        if (process.stderr.isTTY) {
-          fs.writeSync(process.stderr.fd, '')
+        if (process.env.LAUNCHPAD_SHELL_INTEGRATION === '1') {
+          process.stderr.write(`${processingMsg}\n`)
+          if (process.stderr.isTTY) {
+            fs.writeSync(process.stderr.fd, '')
+          }
+        }
+        else {
+          process.stdout.write(`${processingMsg}\n`)
         }
-      }
-      else {
-        process.stdout.write(`${processingMsg}\n`)
-      }
 
-      hasTemporaryProcessingMessage = true
+        hasTemporaryProcessingMessage = true
+      }
     }, 50) // Small delay to ensure success message is visible
   }
 }
@@ -1396,6 +1405,9 @@ export async function downloadPackage(
     let archiveFile: string | null = null
     let usedCache = false
 
+    // Track whether we've shown a success message to avoid redundant extraction messages
+    let showedSuccessMessage = false
+
     for (const format of formats) {
       // Check if we have a cached version first
       const cachedArchivePath = getCachedPackagePath(domain, version, format)
@@ -1406,40 +1418,9 @@ export async function downloadPackage(
           console.warn(`Using cached ${domain} v${version} from: ${cachedArchivePath}`)
         }
         else {
-          // Show a brief processing message for cached packages to provide feedback
-          if (!config.verbose) {
-            const processingMsg = `🔄 Loading ${domain} v${version} from cache...`
-            if (process.env.LAUNCHPAD_SHELL_INTEGRATION === '1') {
-              process.stderr.write(`${processingMsg}\n`)
-              if (process.stderr.isTTY) {
-                fs.writeSync(process.stderr.fd, '')
-              }
-            }
-            else {
-              process.stdout.write(`${processingMsg}\n`)
-            }
-
-            // Brief delay to make the message visible
-            await new Promise(resolve => setTimeout(resolve, 100))
-
-            // Clear the processing message by moving cursor up and clearing the line
-            if (process.env.LAUNCHPAD_SHELL_INTEGRATION === '1') {
-              process.stderr.write('\x1B[1A\r\x1B[K')
-              if (process.stderr.isTTY) {
-                try {
-                  fs.writeSync(process.stderr.fd, '')
-                }
-                catch {
-                  // Ignore flush errors
-                }
-              }
-            }
-            else {
-              process.stdout.write('\x1B[1A\r\x1B[K')
-            }
-          }
-
+          // For cached packages, show completion message directly without intermediate processing message
           logUniqueMessage(`✅ ${domain} \x1B[2m\x1B[3m(v${version})\x1B[0m`)
+          showedSuccessMessage = true
         }
 
         // Copy cached file to temp directory
@@ -1671,8 +1652,9 @@ export async function downloadPackage(
     }
     else {
       // Only show extraction for very large packages (>20MB) to keep output clean
+      // But don't show if we already showed a success message (for cached packages)
       const archiveStats = fs.statSync(archiveFile)
-      if (archiveStats.size > 20 * 1024 * 1024) {
+      if (archiveStats.size > 20 * 1024 * 1024 && !showedSuccessMessage) {
         // Clear any existing spinner before starting extraction
         if (hasTemporaryProcessingMessage) {
           cleanupSpinner()
@@ -1778,7 +1760,7 @@ export async function downloadPackage(
     else {
       // Clear the extraction progress message if we showed one
       const archiveStats = fs.statSync(archiveFile)
-      if (archiveStats.size > 20 * 1024 * 1024) {
+      if (archiveStats.size > 20 * 1024 * 1024 && !showedSuccessMessage) {
         if (process.env.LAUNCHPAD_SHELL_INTEGRATION === '1') {
           process.stderr.write('\x1B[1A\r\x1B[K')
           if (process.stderr.isTTY) {
@@ -2861,6 +2843,9 @@ export async function install(packages: PackageSpec | PackageSpec[], basePath?:
     }
   }
 
+  // Clean up any lingering processing messages
+  cleanupAllProcessingMessages()
+
   return allInstalledFiles
 }
 

packages/launchpad/test/download-progress.test.ts

@@ -513,31 +513,6 @@ describe('Download Progress', () => {
   })
 
   describe('Cache vs Download Progress', () => {
-    it('should show cache loading messages for cached packages', async () => {
-      // Mock cache hit
-      jest.spyOn(fs, 'existsSync').mockReturnValue(true)
-      jest.spyOn(fs, 'statSync').mockReturnValue({ size: 1024 } as any)
-      jest.spyOn(fs, 'copyFileSync').mockImplementation(jest.fn())
-
-      process.env.NODE_ENV = 'development'
-
-      const { downloadPackage } = await import('../src/install')
-
-      try {
-        await downloadPackage('test.domain', '1.0.0', 'darwin', 'x86_64', tempDir)
-      }
-      catch {
-        // Expected to fail due to mocking
-      }
-
-      // Verify cache loading messages were written
-      const cacheCalls = mockStdout.mock.calls.filter(call =>
-        call[0].includes('🔄') && call[0].includes('Loading') && call[0].includes('cache'),
-      )
-
-      expect(cacheCalls.length).toBeGreaterThan(0)
-    })
-
     it('should not show download progress for cached packages', async () => {
       // Mock cache hit
       jest.spyOn(fs, 'existsSync').mockReturnValue(true)