Skip to content

Commit b04e69f

Browse files
committed
chore: wip
1 parent faae3be commit b04e69f

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

packages/launchpad/src/bun.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -527,8 +527,8 @@ export async function install_bun(installPath: string, version?: string): Promis
527527

528528
// Extract the archive
529529
if (filename.endsWith('.zip')) {
530-
// Skip extraction in test environment
531-
if (process.env.NODE_ENV === 'test') {
530+
// Skip extraction in test environment (only when running under Bun test runner)
531+
if (process.env.NODE_ENV === 'test' && process.env.BUN_TEST === '1') {
532532
// In test mode, create a fake bun executable
533533
const bunExeName = platform() === 'win32' ? 'bun.exe' : 'bun'
534534
const destPath = path.join(binDir, bunExeName)

packages/launchpad/test/dependency-resolution.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -920,8 +920,8 @@ describe('Dependency Resolution System', () => {
920920
}
921921
const endTime = performance.now()
922922

923-
// Each operation should complete 1000 iterations in under 250ms (adjusted for CI)
924-
expect(endTime - startTime).toBeLessThan(250)
923+
// Each operation should complete 1000 iterations in under 500ms (adjusted for CI and system variations)
924+
expect(endTime - startTime).toBeLessThan(500)
925925
})
926926
})
927927
})

packages/launchpad/test/real-php-test.test.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ describe('Real PHP Installation Test', () => {
2828
console.log('📋 PHP Installation Output (last 1000 chars):')
2929
console.log(output.slice(-1000))
3030

31-
// Check current behavior: PHP installation falls back to source build which is no longer supported
31+
// Check current behavior: PHP installation fails when trying to install php.net
3232
// This test demonstrates that without source builds, PHP installation fails
33-
expect(output).toContain('Custom extensions detected: falling back to source build')
3433
expect(output).toContain('Failed to install php.net')
34+
expect(output).toContain('No binaries were installed')
3535

3636
// Should NOT contain old source build setup messages since they're removed
3737
expect(output).not.toContain('Setting up build environment for PHP')
@@ -56,7 +56,8 @@ describe('Real PHP Installation Test', () => {
5656
// This test validates that the system handles the failure correctly
5757
if (error.stdout && error.stdout.includes('source build')) {
5858
console.log('✅ Test confirmed: Source builds are no longer available')
59-
} else {
59+
}
60+
else {
6061
throw error
6162
}
6263
}

0 commit comments

Comments
 (0)