Skip to content

Commit dab1010

Browse files
committed
chore: wip
1 parent cbd4ea9 commit dab1010

File tree

5 files changed

+13
-16
lines changed

5 files changed

+13
-16
lines changed

packages/launchpad/src/dependency-resolution.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ import { logUniqueMessage } from './logging'
55
import { getAvailableVersions, getLatestVersion, getPackageInfo, parsePackageSpec, resolvePackageName, resolveVersion } from './package-resolution'
66
import { deduplicatePackagesByVersion, getPlatform } from './utils'
77

8+
// Global variables for processing message management
9+
let hasTemporaryProcessingMessage = false
10+
let spinnerInterval: Timer | null = null
11+
812
// Global tracker for deduplicating packages across all install calls
913
const globalInstalledTracker = new Set<string>()
1014

@@ -450,7 +454,3 @@ export async function installDependencies(
450454

451455
return allInstalledFiles
452456
}
453-
454-
// Global variables from logging module
455-
let hasTemporaryProcessingMessage = false
456-
let spinnerInterval: Timer | null = null

packages/launchpad/src/install-core.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ import { installMeilisearch } from './special-installers'
1414
import { DISTRIBUTION_CONFIG } from './types'
1515
import { copyDirectoryStructure, getArchitecture, getPlatform } from './utils'
1616

17+
// Global variables for processing message management
18+
const hasTemporaryProcessingMessage = false
19+
1720
/**
1821
* Create missing library symlinks for dynamic linking
1922
*/
@@ -878,6 +881,3 @@ export async function downloadPackage(
878881
throw error
879882
}
880883
}
881-
882-
// Global variables from logging module
883-
let hasTemporaryProcessingMessage = false

packages/launchpad/src/install-main.ts

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ import { clearMessageCache, logUniqueMessage } from './logging'
88
import { parsePackageSpec } from './package-resolution'
99
import { install_prefix } from './utils'
1010

11-
// Global tracker for deduplicating packages across all install calls
12-
const globalInstalledTracker = new Set<string>()
13-
1411
/**
1512
* Main installation function with type-safe package specifications
1613
*/
@@ -49,8 +46,6 @@ export async function install(packages: PackageSpec | PackageSpec[], basePath?:
4946
}
5047

5148
const allInstalledFiles: string[] = []
52-
// Use the global tracker to deduplicate across multiple install() calls
53-
const installedPackages = globalInstalledTracker
5449

5550
if (useDirectInstallation) {
5651
// ts-pkgx already resolved all dependencies, install all packages directly
@@ -88,7 +83,7 @@ export async function install(packages: PackageSpec | PackageSpec[], basePath?:
8883
}
8984
continue // Success, move to next package
9085
}
91-
catch (fallbackError) {
86+
catch {
9287
// If fallback with version fails, try without version
9388
if (versionConstraint) {
9489
try {
@@ -210,9 +205,9 @@ export async function installPackagesInParallel(
210205
* Download with resumption support for large files
211206
*/
212207
export async function _downloadWithResumption(
213-
url: string,
214-
destination: string,
215-
expectedSize?: number,
208+
_url: string,
209+
_destination: string,
210+
_expectedSize?: number,
216211
): Promise<void> {
217212
// Implementation for resumable downloads
218213
// This is a placeholder for future implementation

packages/launchpad/src/logging.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable no-console */
12
import fs from 'node:fs'
23
import process from 'node:process'
34
import { config } from './config'

packages/launchpad/test/config.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ describe('Config', () => {
7676
})
7777

7878
it('should have valid shell messages', () => {
79+
// eslint-disable-next-line no-control-regex
7980
const ansiEscapeRegex = /\x1B\[[0-9;]*[a-z]/gi
8081

8182
expect(defaultConfig.shellActivationMessage).toBeDefined()

0 commit comments

Comments
 (0)