chore: wip

chrisbbreuer · chrisbbreuer · commit ee4e947becd3 · 2025-09-25T10:54:26.000-07:00
diff --git a/packages/launchpad/src/commands/config.ts b/packages/launchpad/src/commands/config.ts
@@ -367,6 +367,10 @@ const command: Command = {
 
     if (args.action === 'get' || args.get) {
       const key = args.get
+      if (!key) {
+        console.error('Key is required for get operation')
+        return 1
+      }
       const val = getByPath(effectiveConfig, key)
       const out = val === undefined ? getByPath(defaultConfig, key) : val
 
diff --git a/packages/launchpad/src/commands/dev.ts b/packages/launchpad/src/commands/dev.ts
@@ -1,4 +1,5 @@
 import type { Command } from '../cli/types'
+import process from 'node:process'
 
 const cmd: Command = {
   name: 'dev',
diff --git a/packages/launchpad/src/commands/find-project-root.ts b/packages/launchpad/src/commands/find-project-root.ts
@@ -1,4 +1,5 @@
 import type { Command } from '../cli/types'
+import process from 'node:process'
 
 const cmd: Command = {
   name: 'find-project-root',
@@ -11,6 +12,7 @@ const cmd: Command = {
     try {
       const result = findProjectRoot(startDir)
       if (result) {
+        // eslint-disable-next-line no-console
         console.log(result)
         return 0
       }
diff --git a/packages/launchpad/src/commands/install.ts b/packages/launchpad/src/commands/install.ts
@@ -141,9 +141,9 @@ async function installPackagesGlobally(packages: string[], options: { verbose?:
 
   await createGlobalBinarySymlinks(globalEnvDir)
   // Skip shell integration in CI environments or if explicitly disabled
-  const skipShellIntegration = process.env.LAUNCHPAD_SKIP_SHELL_INTEGRATION === 'true' ||
-                                process.env.CI === 'true' ||
-                                process.env.GITHUB_ACTIONS === 'true'
+  const skipShellIntegration = process.env.LAUNCHPAD_SKIP_SHELL_INTEGRATION === 'true'
+    || process.env.CI === 'true'
+    || process.env.GITHUB_ACTIONS === 'true'
   if (!options.quiet && !options.noInteractive && !skipShellIntegration) {
     await ensureShellIntegrationInstalled()
     triggerShellGlobalRefresh()
@@ -376,7 +376,7 @@ async function installGlobalDependencies(options: { dryRun?: boolean, quiet?: bo
   try {
     process.env.LAUNCHPAD_SUPPRESS_INSTALL_SUMMARY = 'true'
     const pkgNames = ['php', 'php.net']
-    const isListed = (val: unknown): boolean => {
+    const _isListed = (val: unknown): boolean => {
       if (typeof val === 'string')
         return pkgNames.includes(val)
       if (Array.isArray(val))
@@ -509,9 +509,9 @@ const command: Command = {
         await createGlobalBinarySymlinks(basePath)
       }
       // Skip shell integration in CI environments or if explicitly disabled
-      const skipShellIntegration = process.env.LAUNCHPAD_SKIP_SHELL_INTEGRATION === 'true' ||
-                                    process.env.CI === 'true' ||
-                                    process.env.GITHUB_ACTIONS === 'true'
+      const skipShellIntegration = process.env.LAUNCHPAD_SKIP_SHELL_INTEGRATION === 'true'
+        || process.env.CI === 'true'
+        || process.env.GITHUB_ACTIONS === 'true'
       if (!skipShellIntegration) {
         await ensureShellIntegrationInstalled()
         triggerShellGlobalRefresh()
@@ -561,9 +561,9 @@ const command: Command = {
         await createGlobalBinarySymlinks(basePath)
       }
       // Skip shell integration in CI environments or if explicitly disabled
-      const skipShellIntegration = process.env.LAUNCHPAD_SKIP_SHELL_INTEGRATION === 'true' ||
-                                    process.env.CI === 'true' ||
-                                    process.env.GITHUB_ACTIONS === 'true'
+      const skipShellIntegration = process.env.LAUNCHPAD_SKIP_SHELL_INTEGRATION === 'true'
+        || process.env.CI === 'true'
+        || process.env.GITHUB_ACTIONS === 'true'
       if (!skipShellIntegration) {
         await ensureShellIntegrationInstalled()
         triggerShellGlobalRefresh()
diff --git a/packages/launchpad/src/commands/md5.ts b/packages/launchpad/src/commands/md5.ts
@@ -1,5 +1,6 @@
 /* eslint-disable no-console */
 import type { Command } from '../cli/types'
+import type { Buffer } from 'node:buffer'
 
 const cmd: Command = {
   name: 'md5',
diff --git a/packages/launchpad/src/commands/reinstall.ts b/packages/launchpad/src/commands/reinstall.ts
@@ -6,15 +6,15 @@ import { config } from '../config'
 const cmd: Command = {
   name: 'reinstall',
   description: 'Uninstall and reinstall packages',
-  async run({ argv, env }) {
+  async run({ argv, env: _env }) {
     const { uninstall } = await import('../uninstall')
     const { install } = await import('../install')
 
     const verbose = argv.includes('--verbose')
     const force = argv.includes('--force')
     const dryRun = argv.includes('--dry-run')
     const global = argv.includes('--global') || argv.includes('-g')
-    const depsOnly = argv.includes('--deps-only')
+    const _depsOnly = argv.includes('--deps-only')
     const quiet = argv.includes('--quiet')
 
     // Extract path option
diff --git a/packages/launchpad/src/commands/scan-library-paths.ts b/packages/launchpad/src/commands/scan-library-paths.ts
@@ -8,6 +8,7 @@ const cmd: Command = {
     const envDir = argv[0]
     try {
       const paths = await scanLibraryPaths(envDir)
+      // eslint-disable-next-line no-console
       console.log(paths.join(':'))
       return 0
     }
diff --git a/packages/launchpad/src/commands/uninstall.ts b/packages/launchpad/src/commands/uninstall.ts
@@ -4,7 +4,7 @@ import type { Command } from '../cli/types'
 const cmd: Command = {
   name: 'uninstall',
   description: 'Remove installed packages',
-  async run({ argv, env }) {
+  async run({ argv, env: _env }) {
     const { uninstall } = await import('../uninstall')
     const { config } = await import('../config')
 
diff --git a/packages/launchpad/src/commands/upgrade.ts b/packages/launchpad/src/commands/upgrade.ts
@@ -34,7 +34,7 @@ function parseArgs(argv: string[]): { force: boolean, verbose: boolean, target?:
   return { force, verbose, target, release, dryRun }
 }
 
-async function detectCurrentBinaryPath(verbose: boolean): Promise<string> {
+async function detectCurrentBinaryPath(_verbose: boolean): Promise<string> {
   // Try which launchpad
   try {
     const { execSync } = await import('node:child_process')
diff --git a/packages/launchpad/src/config-validation.ts b/packages/launchpad/src/config-validation.ts
@@ -1,6 +1,7 @@
 import type { LaunchpadConfig } from './types'
 import fs from 'node:fs'
 import path from 'node:path'
+import process from 'node:process'
 
 export interface ValidationResult {
   valid: boolean
diff --git a/packages/launchpad/src/config.ts b/packages/launchpad/src/config.ts
@@ -82,8 +82,8 @@ export const defaultConfig: LaunchpadConfig = {
   network: {
     timeout: Number.parseInt(process.env.LAUNCHPAD_NETWORK_TIMEOUT || '30000', 10),
     // Use slightly higher concurrency in CI to speed up installation
-    maxConcurrent: Number.parseInt(process.env.LAUNCHPAD_NETWORK_MAX_CONCURRENT ||
-                    (process.env.CI === 'true' || process.env.GITHUB_ACTIONS === 'true' ? '4' : '3'), 10),
+    maxConcurrent: Number.parseInt(process.env.LAUNCHPAD_NETWORK_MAX_CONCURRENT
+      || (process.env.CI === 'true' || process.env.GITHUB_ACTIONS === 'true' ? '4' : '3'), 10),
     retries: Number.parseInt(process.env.LAUNCHPAD_NETWORK_RETRIES || '3', 10),
     proxy: {
       http: process.env.HTTP_PROXY || process.env.http_proxy,
diff --git a/packages/launchpad/src/dependency-resolution.ts b/packages/launchpad/src/dependency-resolution.ts
@@ -71,11 +71,11 @@ export async function resolveAllDependencies(packages: string[]): Promise<string
 
       if (config.verbose) {
         console.warn(`🔍 ts-pkgx resolved ${result.totalCount || result.packages.length} total packages from ${packages.length} input packages`)
-        console.warn(`📦 Resolved packages: ${result.packages.map(pkg => `${pkg.name}@${pkg.version || 'latest'}`).join(', ')}`)
+        console.warn(`📦 Resolved packages: ${result.packages.map((pkg: any) => `${pkg.name}@${pkg.version || 'latest'}`).join(', ')}`)
       }
 
       // Convert resolved packages back to package specs
-      const resolvedSpecs = result.packages.map(pkg =>
+      const resolvedSpecs = result.packages.map((pkg: any) =>
         pkg.version ? `${pkg.name}@${pkg.version}` : pkg.name,
       )
 
diff --git a/packages/launchpad/src/dev/integrate.ts b/packages/launchpad/src/dev/integrate.ts
@@ -80,8 +80,10 @@ export default async function (op: 'install' | 'uninstall', { dryrun }: { dryrun
           const isCI = process.env.CI === 'true' || process.env.GITHUB_ACTIONS === 'true' || process.env.CONTINUOUS_INTEGRATION === 'true'
           if (isCI) {
             // In CI, we can't restart terminal, so just note that hooks are installed
+            // eslint-disable-next-line no-console
             console.log('✅ Launchpad shell hooks installed for CI environment')
-          } else {
+          }
+          else {
             // eslint-disable-next-line no-console
             console.log(
               'now %crestart your terminal%c for `launchpad` hooks to take effect',
diff --git a/packages/launchpad/src/services/manager.ts b/packages/launchpad/src/services/manager.ts
@@ -100,7 +100,7 @@ export async function startService(serviceName: string): Promise<boolean> {
     catch (error) {
       console.warn(`🧪 Test mode: Failed to start unknown service ${serviceName}`)
       operation.result = 'failure'
-      operation.error = error instanceof Error ? error.message : String(error)
+      operation.error = String(error)
       operation.duration = 0
       manager.operations.push(operation)
       return false
@@ -283,7 +283,7 @@ export async function startService(serviceName: string): Promise<boolean> {
   catch (error) {
     console.error(`❌ Failed to start service ${serviceName}: ${error}`)
     operation.result = 'failure'
-    operation.error = error
+    operation.error = String(error)
     operation.duration = 0
     manager.operations.push(operation)
     return false
@@ -378,12 +378,12 @@ export async function stopService(serviceName: string): Promise<boolean> {
   }
   catch (error) {
     operation.result = 'failure'
-    operation.error = error instanceof Error ? error.message : String(error)
+    operation.error = String(error)
     operation.duration = Date.now() - operation.timestamp.getTime()
     manager.operations.push(operation)
 
     console.error(`❌ Failed to stop ${serviceName}: ${operation.error}`)
-    return { success: false, error: 'Service stop failed' }
+    return false
   }
 }
 
@@ -401,7 +401,8 @@ export async function restartService(serviceName: string): Promise<{ success: bo
   // Wait a moment before starting
   await new Promise(resolve => setTimeout(resolve, 1000))
 
-  return await startService(serviceName)
+  const startSuccess = await startService(serviceName)
+  return { success: startSuccess, error: startSuccess ? undefined : 'Failed to start service after restart' }
 }
 
 /**
@@ -437,10 +438,10 @@ export async function enableService(serviceName: string): Promise<boolean> {
     catch (error) {
       console.warn(`🧪 Test mode: Failed to enable unknown service ${serviceName}`)
       operation.result = 'failure'
-      operation.error = error instanceof Error ? error.message : String(error)
+      operation.error = String(error)
       operation.duration = 0
       manager.operations.push(operation)
-      return { success: false, error: 'Service stop failed' }
+      return false
     }
   }
 
@@ -479,12 +480,12 @@ export async function enableService(serviceName: string): Promise<boolean> {
   }
   catch (error) {
     operation.result = 'failure'
-    operation.error = error instanceof Error ? error.message : String(error)
+    operation.error = String(error)
     operation.duration = Date.now() - operation.timestamp.getTime()
     manager.operations.push(operation)
 
     console.error(`❌ Failed to enable ${serviceName}: ${operation.error}`)
-    return { success: false, error: 'Service stop failed' }
+    return false
   }
 }
 
@@ -569,12 +570,12 @@ export async function disableService(serviceName: string): Promise<boolean> {
   }
   catch (error) {
     operation.result = 'failure'
-    operation.error = error instanceof Error ? error.message : String(error)
+    operation.error = String(error)
     operation.duration = Date.now() - operation.timestamp.getTime()
     manager.operations.push(operation)
 
     console.error(`❌ Failed to disable ${serviceName}: ${operation.error}`)
-    return { success: false, error: 'Service stop failed' }
+    return false
   }
 }
 
@@ -655,7 +656,7 @@ async function isServiceInitialized(service: ServiceInstance): Promise<boolean>
   if (definition?.dataDirectory) {
     const dataDir = service.dataDir || definition.dataDirectory
     if (!fs.existsSync(dataDir)) {
-      return { success: false, error: 'Service stop failed' }
+      return false
     }
 
     // For databases, check if data directory has initialization files
@@ -883,7 +884,7 @@ async function ensureServicePackageInstalled(service: ServiceInstance): Promise<
     }
     catch (importError) {
       console.error(`❌ Failed to import install function: ${importError instanceof Error ? importError.message : String(importError)}`)
-      return { success: false, error: 'Service stop failed' }
+      return false
     }
 
     // Install the main service package - this will automatically install all dependencies
@@ -921,7 +922,7 @@ async function ensureServicePackageInstalled(service: ServiceInstance): Promise<
         return true
       }
 
-      return { success: false, error: 'Service stop failed' }
+      return false
     }
 
     // Verify installation worked by checking in the Launchpad environment
@@ -934,7 +935,7 @@ async function ensureServicePackageInstalled(service: ServiceInstance): Promise<
   }
   catch (error) {
     console.error(`❌ Failed to install ${definition.displayName}: ${error instanceof Error ? error.message : String(error)}`)
-    return { success: false, error: 'Service stop failed' }
+    return false
   }
 }
 
@@ -977,7 +978,7 @@ async function ensurePHPDatabaseExtensions(_service: ServiceInstance): Promise<b
     })
 
     if (!checkResult) {
-      return { success: false, error: 'Service stop failed' }
+      return false
     }
 
     const loadedExtensions = output.toLowerCase().split('\n').map(line => line.trim())
@@ -995,11 +996,11 @@ async function ensurePHPDatabaseExtensions(_service: ServiceInstance): Promise<b
     if (config.verbose)
       console.warn(`💡 Launchpad ships precompiled PHP binaries with common DB extensions. We'll select the correct binary for your project automatically.`)
     // Do not attempt PECL here. Let binary-downloader pick the right PHP and shims load the project php.ini
-    return { success: false, error: 'Service stop failed' }
+    return false
   }
   catch (error) {
     console.error(`❌ Failed to check PHP extensions: ${error instanceof Error ? error.message : String(error)}`)
-    return { success: false, error: 'Service stop failed' }
+    return false
   }
 }
 
@@ -1099,7 +1100,7 @@ export async function setupSQLiteForProject(): Promise<boolean> {
   }
   catch (error) {
     console.warn(`⚠️  Could not set up SQLite automatically: ${error instanceof Error ? error.message : String(error)}`)
-    return { success: false, error: 'Service stop failed' }
+    return false
   }
 }
 
@@ -1219,7 +1220,7 @@ async function autoInitializeDatabase(service: ServiceInstance): Promise<boolean
     }
     catch (error) {
       console.error(`❌ Failed to initialize PostgreSQL: ${error instanceof Error ? error.message : String(error)}`)
-      return { success: false, error: 'Service stop failed' }
+      return false
     }
   }
 
@@ -1251,7 +1252,7 @@ async function autoInitializeDatabase(service: ServiceInstance): Promise<boolean
     }
     catch (error) {
       console.error(`❌ Failed to initialize MySQL: ${error instanceof Error ? error.message : String(error)}`)
-      return { success: false, error: 'Service stop failed' }
+      return false
     }
   }
 
diff --git a/packages/launchpad/src/uninstall.ts b/packages/launchpad/src/uninstall.ts
diff --git a/packages/launchpad/test/config.test.ts b/packages/launchpad/test/config.test.ts
diff --git a/packages/launchpad/test/dependency-resolution.test.ts b/packages/launchpad/test/dependency-resolution.test.ts
diff --git a/packages/launchpad/test/project-file-detection.test.ts b/packages/launchpad/test/project-file-detection.test.ts
diff --git a/packages/launchpad/test/services.test.ts b/packages/launchpad/test/services.test.ts

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import type { Command } from '../cli/types'`
	`2`	`+import process from 'node:process'`
`2`	`3`
`3`	`4`	`const cmd: Command = {`
`4`	`5`	`name: 'dev',`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ const cmd: Command = {`
`8`	`8`	`const envDir = argv[0]`
`9`	`9`	`try {`
`10`	`10`	`const paths = await scanLibraryPaths(envDir)`
	`11`	`+ // eslint-disable-next-line no-console`
`11`	`12`	`console.log(paths.join(':'))`
`12`	`13`	`return 0`
`13`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ function parseArgs(argv: string[]): { force: boolean, verbose: boolean, target?:`
`34`	`34`	`return { force, verbose, target, release, dryRun }`
`35`	`35`	`}`
`36`	`36`
`37`		`-async function detectCurrentBinaryPath(verbose: boolean): Promise<string> {`
	`37`	`+async function detectCurrentBinaryPath(_verbose: boolean): Promise<string> {`
`38`	`38`	`// Try which launchpad`
`39`	`39`	`try {`
`40`	`40`	`const { execSync } = await import('node:child_process')`