Skip to content

Commit f3aedcd

Browse files
committed
chore: wip
1 parent 05d5e60 commit f3aedcd

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

packages/benchmark/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,10 @@ for (const file of PROJECT_FILES) {
5959
### Bun Glob Approach
6060
```typescript
6161
const glob = new Glob(`{${PROJECT_FILES.join(',')}}`)
62+
// eslint-disable-next-line no-unreachable-loop
6263
for await (const file of glob.scan({ cwd: currentDir, onlyFiles: true })) {
63-
return currentDir // Found a match
64+
// Found a matching project file - return immediately on first match
65+
return currentDir
6466
}
6567
```
6668

packages/launchpad/src/commands/check-updates.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ const cmd: Command = {
1515

1616
if (env.CI === 'true' || env.GITHUB_ACTIONS === 'true') {
1717
// Minimal CI output for diagnostics, same shape as existing implementation
18+
// eslint-disable-next-line no-console
1819
console.log(JSON.stringify(result))
1920
}
2021

packages/launchpad/src/commands/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ function setByPath(obj: any, path: string, value: any): boolean {
165165
else if (value === 'undefined') {
166166
parsedValue = undefined
167167
}
168-
else if (!isNaN(Number(value)) && value !== '') {
168+
else if (!Number.isNaN(Number(value)) && value !== '') {
169169
parsedValue = Number(value)
170170
}
171171
else if (value.startsWith('[') || value.startsWith('{')) {

packages/launchpad/src/config-validation.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ function validatePath(
244244
*/
245245
function isValidUrl(url: string): boolean {
246246
try {
247+
// eslint-disable-next-line no-new
247248
new URL(url)
248249
return true
249250
}
@@ -256,7 +257,7 @@ function isValidUrl(url: string): boolean {
256257
* Validates if a string is a valid domain name
257258
*/
258259
function isValidDomain(domain: string): boolean {
259-
const domainRegex = /^[a-z0-9]([a-z0-9-]{0,61}[a-z0-9])?(\.[a-z0-9]([a-z0-9-]{0,61}[a-z0-9])?)*$/i
260+
const domainRegex = /^[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?(?:\.[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?)*$/i
260261
return domainRegex.test(domain)
261262
}
262263

0 commit comments

Comments
 (0)