chore: wip

Author: iamzjohn

docs/features/linting-basics.md

@@ -56,7 +56,7 @@ const obj = { b: 1, a: 2 }
 const obj2 = { y: 1, x: 2 }
 
 // pickier-disable-next-line ts/no-require-imports
-const fs = require('fs')
+const fs = require('node:fs')
 ```
 
 Notes:

docs/rules/ts-no-require-imports.md

@@ -17,7 +17,7 @@ Examples (violations):
 
 ```ts
 // a.ts
-const fs = require('fs')
+const fs = require('node:fs')
 ```
 
 ```ts
@@ -29,7 +29,7 @@ Non-violations:
 
 ```ts
 // dynamic import
-const mod = await import('fs')
+const mod = await import('node:fs')
 ```
 
 Rationale: TypeScript projects commonly target ESM. Mixing `require()` with ESM import/export leads to interop edge cases and bundler inconsistencies.

eslint.config.ts

@@ -13,6 +13,7 @@ const config: ESLintConfig = stacks({
   ignores: [
     '**/test/fixtures/**',
     '**/test/output/**',
+    'docs/**',
   ],
 })
 

packages/pickier/src/cli/run-lint.ts

@@ -1803,7 +1803,7 @@ function applyPlugins(filePath: string, content: string, cfg: PickierConfig): Pl
         meta: { docs: 'Detects potentially super-linear backtracking patterns in regex literals (heuristic)' },
         check: (text, ctx) => {
           const issues: PluginLintIssue[] = []
-          const regexLiteral = /\/[^\/\\]*(?:\\.[^\/\\]*)*\//g
+          const regexLiteral = /\/[^/\\]*(?:\\.[^/\\]*)*\//g
           const mark = (idx: number, len: number, msg: string) => {
             const before = text.slice(0, idx)
             const line = (before.match(/\n/g) || []).length + 1
@@ -1899,7 +1899,7 @@ function applyPlugins(filePath: string, content: string, cfg: PickierConfig): Pl
               continue
             }
             // also flag import = require('...') pattern
-            if (/^import\s+.+=\s*require\s*\(/.test(trimmed)) {
+            if (/^import\s+(?:\S.*|[\t\v\f \xA0\u1680\u2000-\u200A\u202F\u205F\u3000\uFEFF])=\s*require\s*\(/.test(trimmed)) {
               const col = raw.indexOf('require(')
               issues.push({
                 filePath: ctx.filePath,
@@ -2103,7 +2103,7 @@ function scanContent(filePath: string, content: string, cfg: PickierConfig): Lin
         severity: cfg.rules.noUnusedCapturingGroup === 'error' ? 'error' : 'warning',
       })
     }
-    const regexLiteral = /\/[^\/\\]*(?:\\.[^\/\\]*)*\//g
+    const regexLiteral = /\/[^/\\]*(?:\\.[^/\\]*)*\//g
     for (let i = 0; i < lines.length; i++) {
       const line = lines[i]
       regexLiteral.lastIndex = 0

packages/pickier/src/format.ts

@@ -549,7 +549,7 @@ function parseImportStatement(stmt: string): ParsedImport | undefined {
 function trySortKnownJson(input: string, filePath: string): string | null {
   if (/package\.json$/i.test(filePath))
     return sortPackageJsonContent(input)
-  if (/[jt]sconfig(\..+)?\.json$/i.test(filePath))
+  if (/[jt]sconfig(?:\..+)?\.json$/i.test(filePath))
     return sortTsconfigContent(input)
   return null
 }
@@ -650,7 +650,7 @@ function sortPackageJsonContent(text: string): string {
   }
   // sort deps blocks A-Z
   for (const k of Object.keys(sortedTop)) {
-    if (/^(?:dev|peer|optional|bundled)?[Dd]ependencies(Meta)?$/.test(k) || /^(?:resolutions|overrides|pnpm\.overrides)$/.test(k)) {
+    if (/^(?:dev|peer|optional|bundled)?[Dd]ependencies(?:Meta)?$/.test(k) || /^(?:resolutions|overrides|pnpm\.overrides)$/.test(k)) {
       if (sortedTop[k] && typeof sortedTop[k] === 'object')
         sortedTop[k] = sortDepsAsc(sortedTop[k])
     }

packages/pickier/test/lint-disable-next-line.test.ts

@@ -90,7 +90,7 @@ describe('disable-next-line directives', () => {
     const file = 'e.ts'
     const src = [
       '// pickier-disable-next-line ts/no-require-imports',
-      "const fs = require('fs')",
+      'const fs = require(\'fs\')',
       '',
     ].join('\n')
     writeFileSync(join(dir, file), src, 'utf8')
@@ -122,4 +122,4 @@ describe('disable-next-line directives', () => {
     const code = await runLint([dir], { reporter: 'json' })
     expect(code).toBe(0)
   })
-}) 
+})

packages/pickier/test/lint-fixtures-disable-next-line.test.ts

@@ -30,8 +30,8 @@ describe('disable-next-line fixtures', () => {
     writeFileSync(cfgPath, JSON.stringify({
       verbose: false,
       ignores: [],
-      lint: { extensions: ['ts','js'], reporter: 'json', cache: false, maxWarnings: -1 },
-      format: { extensions: ['ts','js'], trimTrailingWhitespace: true, maxConsecutiveBlankLines: 1, finalNewline: 'one', indent: 2, quotes: 'single', semi: false },
+      lint: { extensions: ['ts', 'js'], reporter: 'json', cache: false, maxWarnings: -1 },
+      format: { extensions: ['ts', 'js'], trimTrailingWhitespace: true, maxConsecutiveBlankLines: 1, finalNewline: 'one', indent: 2, quotes: 'single', semi: false },
       rules: { noDebugger: 'error', noConsole: 'warn' },
       pluginRules: { 'sort-objects': 'warn', 'ts/no-require-imports': 'error' },
     }, null, 2), 'utf8')
@@ -48,4 +48,4 @@ describe('disable-next-line fixtures', () => {
     const lintCode = await runLint([dir], { config: cfgPath, reporter: 'json' })
     expect(lintCode).toBe(0)
   })
-}) 
+})

packages/pickier/test/rules-ts-no-require-imports.test.ts

@@ -13,7 +13,7 @@ describe('ts/no-require-imports', () => {
     const dir = tmp()
     const file = 'a.ts'
     const src = [
-      "const fs = require('fs')",
+      'const fs = require(\'fs\')',
       'export const x = fs.existsSync ? 1 : 0',
       '',
     ].join('\n')
@@ -38,7 +38,7 @@ describe('ts/no-require-imports', () => {
     const dir = tmp()
     const file = 'b.ts'
     const src = [
-      "const mod = await import('fs')",
+      'const mod = await import(\'fs\')',
       'export { mod }',
       '',
     ].join('\n')
@@ -57,4 +57,4 @@ describe('ts/no-require-imports', () => {
     const code = await runLint([dir], { config: cfgPath, reporter: 'json' })
     expect(code).toBe(0)
   })
-}) 
+})