add support for Nodejs24, make Node24 the default for containers

matuscongrady · matuscongrady · commit a510f902ecee · 2025-11-27T15:50:43.000+01:00
diff --git a/@generated/schemas/config-schema.json b/@generated/schemas/config-schema.json
diff --git a/@generated/schemas/validate-config-schema.js b/@generated/schemas/validate-config-schema.js
diff --git a/_test-stacks/provisioned-lambda/src/simple.ts b/_test-stacks/provisioned-lambda/src/simple.ts
@@ -0,0 +1,3 @@
+export default (event, context) => {
+  console.log(event, context);
+};
diff --git a/_test-stacks/provisioned-lambda/stacktape.ts b/_test-stacks/provisioned-lambda/stacktape.ts
@@ -0,0 +1,21 @@
+import { defineConfig, LambdaFunction, StacktapeLambdaBuildpackPackaging } from '../../__release-npm';
+
+export default defineConfig(() => {
+  const lambda = new LambdaFunction({
+    packaging: new StacktapeLambdaBuildpackPackaging({
+      entryfilePath: './src/simple.ts'
+    }),
+    url: {
+      enabled: true,
+      cors: {
+        enabled: true
+      }
+    },
+    runtime: 'nodejs24.x',
+    provisionedConcurrency: 1
+  });
+
+  return {
+    resources: { lambda },
+  };
+});
diff --git a/_test-stacks/simple-lambda/stacktape.ts b/_test-stacks/simple-lambda/stacktape.ts
@@ -11,14 +11,12 @@ export default defineConfig(() => {
         enabled: true
       }
     },
-    provisionedConcurrency: 1,
     transforms: {
       lambda: (props) => {
         return {
           ...props,
           MemorySize: (props.MemorySize ?? 128) * 2,
           Description: 'This is a test lambda',
-          Layers: ['arn:aws:lambda:us-east-1:123456789012:layer:my-layer:1'],
         }
       }
     }
diff --git a/bun.lock b/bun.lock
diff --git a/package.json b/package.json
@@ -159,6 +159,7 @@
   "devDependencies": {
     "@antfu/eslint-config": "^6.2.0",
     "@cspell/eslint-plugin": "^9.2.2",
+    "@eslint-react/eslint-plugin": "^2.3.9",
     "@types/adm-zip": "^0.5.7",
     "@types/archiver": "^5.3.4",
     "@types/aws-lambda": "^8.10.152",
@@ -176,6 +177,8 @@
     "eslint": "^9.36.0",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-prettier": "^5.5.4",
+    "eslint-plugin-react-hooks": "^7.0.1",
+    "eslint-plugin-react-refresh": "^0.4.24",
     "inquirer": "^13.0.1",
     "json-schema-to-typescript": "^15.0.4",
     "nodejs-file-downloader": "^4.13.0",
diff --git a/shared/packaging/bundlers/es/index.ts b/shared/packaging/bundlers/es/index.ts
@@ -2,6 +2,7 @@ import type { Plugin } from 'esbuild';
 import type { PackageJsonDepsInfo } from './utils';
 import { existsSync } from 'node:fs';
 import { dirname, isAbsolute, join, resolve } from 'node:path';
+import { NODE_RUNTIME_VERSIONS_WITH_SKIPPED_SDK_V3_PACKAGING } from '@config';
 import { SOURCE_MAP_INSTALL_DIST_PATH } from '@shared/naming/project-fs-paths';
 import { dependencyInstaller } from '@shared/utils/dependency-installer';
 import {
@@ -112,12 +113,9 @@ export const buildEsCode = async ({
   // @todo add option to use exact version (as-is in user's package json)
   const skipAwsSdkV3Deps =
     isLambda &&
-    (nodeTarget.includes('18') ||
-      String(nodeTarget) === '18' ||
-      nodeTarget.includes('20') ||
-      String(nodeTarget) === '20' ||
-      nodeTarget.includes('22') ||
-      String(nodeTarget) === '22');
+    NODE_RUNTIME_VERSIONS_WITH_SKIPPED_SDK_V3_PACKAGING.some(
+      (v) => nodeTarget.includes(String(v)) || String(nodeTarget) === String(v)
+    );
 
   const runBuild = async ({ dynamicallyImportedModules = [] }: { dynamicallyImportedModules?: string[] }) => {
     const allDependenciesToInstallInDocker: ModuleInfo[] = [];
diff --git a/shared/packaging/stacktape-es-image-buildpack.ts b/shared/packaging/stacktape-es-image-buildpack.ts
@@ -5,6 +5,7 @@ import { getFolder } from '@shared/utils/fs-utils';
 import { outputFile } from 'fs-extra';
 import objectHash from 'object-hash';
 import { createEsBundle } from './bundlers/es';
+import { DEFAULT_CONTAINER_NODE_VERSION } from '@config';
 
 export const buildUsingStacktapeEsImageBuildpack = async ({
   progressLogger,
@@ -50,7 +51,7 @@ export const buildUsingStacktapeEsImageBuildpack = async ({
     languageSpecificBundleOutput: bundlingOutput.languageSpecificBundleOutput,
     requiresGlibcBinaries,
     customDockerBuildCommands: otherProps.customDockerBuildCommands,
-    nodeVersion: (languageSpecificConfig as EsLanguageSpecificConfig)?.nodeVersion || 18
+    nodeVersion: (languageSpecificConfig as EsLanguageSpecificConfig)?.nodeVersion || DEFAULT_CONTAINER_NODE_VERSION
   });
   await progressLogger.finishEvent({ eventType: 'CREATE_DOCKERFILE' });
 
diff --git a/src/config/random.ts b/src/config/random.ts
@@ -36,20 +36,22 @@ export const possiblySupportedLangExtensions = [
   'tsx'
 ] as const;
 
+export const NODE_RUNTIME_VERSIONS_WITH_SKIPPED_SDK_V3_PACKAGING = [24, 22, 20, 18];
+
 export const lambdaRuntimesForFileExtension: {
   [_ext in (typeof possiblySupportedLangExtensions)[number]]: string[];
 } = {
-  js: ['nodejs22.x', 'nodejs20.x', 'nodejs18.x', 'nodejs16.x'], // 'nodejs14.x', 'nodejs12.x'],
-  ts: ['nodejs22.x', 'nodejs20.x', 'nodejs18.x', 'nodejs16.x'], // 'nodejs14.x', 'nodejs12.x'],
-  mjs: ['nodejs22.x', 'nodejs20.x', 'nodejs18.x', 'nodejs16.x'], // 'nodejs14.x', 'nodejs12.x'],
-  mts: ['nodejs22.x', 'nodejs20.x', 'nodejs18.x', 'nodejs16.x'], // 'nodejs14.x', 'nodejs12.x'],
-  jsx: ['nodejs22.x', 'nodejs20.x', 'nodejs18.x', 'nodejs16.x'], // 'nodejs14.x', 'nodejs12.x'],
-  tsx: ['nodejs22.x', 'nodejs20.x', 'nodejs18.x', 'nodejs16.x'], // 'nodejs14.x', 'nodejs12.x'],
-  py: ['python3.13', 'python3.12', 'python3.11', 'python3.10', 'python3.9', 'python3.8'],
-  java: ['java11', 'java8.al2', 'java8'],
-  rb: ['ruby3.2'],
+  js: ['nodejs24.x', 'nodejs22.x', 'nodejs20.x', 'nodejs18.x'],
+  ts: ['nodejs24.x', 'nodejs22.x', 'nodejs20.x', 'nodejs18.x'],
+  mjs: ['nodejs24.x', 'nodejs22.x', 'nodejs20.x', 'nodejs18.x'],
+  mts: ['nodejs24.x', 'nodejs22.x', 'nodejs20.x', 'nodejs18.x'],
+  jsx: ['nodejs24.x', 'nodejs22.x', 'nodejs20.x', 'nodejs18.x'],
+  tsx: ['nodejs24.x', 'nodejs22.x', 'nodejs20.x', 'nodejs18.x'],
+  py: ['python3.13', 'python3.12', 'python3.11', 'python3.10'],
+  java: ['java21', 'java17', 'java11'],
+  rb: ['ruby3.3'],
   go: ['provided.al2', 'provided.al2023'],
-  cs: ['dotnet6', 'dotnet7']
+  cs: ['dotnet8', 'dotnet6']
 };
 export const supportedWorkloadExtensions: (typeof possiblySupportedLangExtensions)[number][] = [
   'js',
@@ -73,6 +75,7 @@ export const MONITORING_FREQUENCY_SECONDS = 3.5;
 export const SENTRY_CAPTURE_EXCEPTION_WAIT_TIME_MS = 1500;
 export const DEFAULT_MAXIMUM_PARALLEL_ARTIFACT_UPLOADS = 10;
 export const DEFAULT_MAXIMUM_PARALLEL_BUCKET_SYNCS = 10;
+export const DEFAULT_CONTAINER_NODE_VERSION = 24;
 
 // @todo
 export const linksMap = {
diff --git a/src/domain/packaging-manager/index.ts b/src/domain/packaging-manager/index.ts
@@ -57,12 +57,13 @@ export class PackagingManager {
     }
 
     await Promise.all([
-      ...configManager.allUserCodeLambdas.map(async ({ name, type, packaging, architecture }) => {
+      ...configManager.allUserCodeLambdas.map(async ({ name, type, packaging, architecture, runtime }) => {
         return this.packageWorkload({
           commandCanUseCache,
           jobName: getJobName({ workloadName: name, workloadType: type }),
           workloadName: name,
           packaging,
+          runtime,
           dockerBuildOutputArchitecture: architecture === 'arm64' ? 'linux/arm64' : 'linux/amd64'
         });
       }),
@@ -303,6 +304,7 @@ export class PackagingManager {
     workloadName,
     jobName,
     packaging,
+    runtime,
     dockerBuildOutputArchitecture = 'linux/amd64',
     parentEventType = 'PACKAGE_ARTIFACTS'
   }: {
@@ -314,6 +316,7 @@ export class PackagingManager {
       | LambdaPackaging
       | HelperLambdaPackaging;
     commandCanUseCache: boolean;
+    runtime?: LambdaRuntime;
     dockerBuildOutputArchitecture?: DockerBuildOutputArchitecture;
     parentEventType?: Subtype<LoggableEventType, 'PACKAGE_ARTIFACTS' | 'REPACKAGE_ARTIFACTS'>;
   }) => {
@@ -365,12 +368,17 @@ export class PackagingManager {
         case 'jsx':
         case 'mjs':
         case 'tsx': {
+          // Extract Node.js version from runtime (e.g., 'nodejs24.x' -> '24')
+          const nodeVersion = runtime?.match(/nodejs(\d+)/)?.[1] || '22';
+          const useEsm = Number(nodeVersion) >= 24;
           const sharedStpBuildpackProps = {
             ...packaging.properties,
-            nodeTarget: '22',
+            nodeTarget: nodeVersion,
             minify: false,
             keepNames: true,
-            entryfilePath: join(globalStateManager.workingDir, packaging.properties.entryfilePath)
+            entryfilePath: join(globalStateManager.workingDir, packaging.properties.entryfilePath),
+            // Node.js 24+ requires (and properly supports) ESM for proper default export handling
+            ...(useEsm && { outputModuleFormat: 'esm' as const })
           };
           const additionalDigestInput = objectHash(sharedStpBuildpackProps);
           if (packagingType === 'stacktape-lambda-buildpack') {
diff --git a/types/random.d.ts b/types/random.d.ts
@@ -86,6 +86,7 @@ type CloudformationTemplate = import('../@generated/cloudform/template').default
 };
 
 type LambdaRuntime =
+  | 'nodejs24.x'
   | 'nodejs22.x'
   | 'nodejs20.x'
   | 'nodejs18.x'
diff --git a/types/stacktape-config/edge-lambda-functions.d.ts b/types/stacktape-config/edge-lambda-functions.d.ts
@@ -34,15 +34,16 @@ interface EdgeLambdaFunctionProps {
    * Edge Lambda functions support a specific set of runtimes.
    */
   runtime?:
-    | 'nodejs22.x'
-    | 'nodejs20.x'
-    | 'nodejs18.x'
-    | 'python3.13'
-    | 'python3.12'
-    | 'python3.11'
-    | 'python3.10'
-    | 'python3.9'
-    | 'python3.8';
+  | 'nodejs24.x'
+  | 'nodejs22.x'
+  | 'nodejs20.x'
+  | 'nodejs18.x'
+  | 'python3.13'
+  | 'python3.12'
+  | 'python3.11'
+  | 'python3.10'
+  | 'python3.9'
+  | 'python3.8';
   /**
    * #### The amount of memory (in MB) allocated to the function.
    *
@@ -135,15 +136,15 @@ type StpHelperEdgeLambdaFunction = Omit<StpEdgeLambdaFunction, 'packaging'> & {
   packaging: HelperLambdaPackaging;
   artifactPath: string;
   runtime:
-    | 'nodejs22.x'
-    | 'nodejs20.x'
-    | 'nodejs18.x'
-    | 'python3.13'
-    | 'python3.12'
-    | 'python3.11'
-    | 'python3.10'
-    | 'python3.9'
-    | 'python3.8';
+  | 'nodejs22.x'
+  | 'nodejs20.x'
+  | 'nodejs18.x'
+  | 'python3.13'
+  | 'python3.12'
+  | 'python3.11'
+  | 'python3.10'
+  | 'python3.9'
+  | 'python3.8';
 };
 
 type EdgeLambdaFunctionReferencableParam = 'arn';

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+export default (event, context) => {`
	`2`	`+ console.log(event, context);`
	`3`	`+};`
Original file line number	Diff line number	Diff line change
`@@ -11,14 +11,12 @@ export default defineConfig(() => {`
`11`	`11`	`enabled: true`
`12`	`12`	`}`
`13`	`13`	`},`
`14`		`- provisionedConcurrency: 1,`
`15`	`14`	`transforms: {`
`16`	`15`	`lambda: (props) => {`
`17`	`16`	`return {`
`18`	`17`	`...props,`
`19`	`18`	`MemorySize: (props.MemorySize ?? 128) * 2,`
`20`	`19`	`Description: 'This is a test lambda',`
`21`		`- Layers: ['arn:aws:lambda:us-east-1:123456789012:layer:my-layer:1'],`
`22`	`20`	`}`
`23`	`21`	`}`
`24`	`22`	`}`