Fix preVerificationGas calculation (#116)

hazim-j · web-flow · commit 927f3a764522 · 2023-03-12T17:01:16.000+11:00
diff --git a/pkg/gas/overhead.go b/pkg/gas/overhead.go
@@ -25,6 +25,7 @@ type Overhead struct {
 // CalcPreVerificationGas returns an expected gas cost for processing a UserOperation from a batch.
 func (ov *Overhead) CalcPreVerificationGas(op *userop.UserOperation) *big.Int {
 	packed := op.Pack()
+	lengthInWord := float64(len(packed)+31) / 32
 	callDataCost := float64(0)
 
 	for _, b := range packed {
@@ -35,9 +36,7 @@ func (ov *Overhead) CalcPreVerificationGas(op *userop.UserOperation) *big.Int {
 		}
 	}
 
-	pvg := callDataCost + (ov.fixed / ov.minBundleSize) + ov.perUserOp + ov.perUserOpWord*float64(
-		(len(packed)),
-	)
+	pvg := callDataCost + (ov.fixed / ov.minBundleSize) + ov.perUserOp + (ov.perUserOpWord * lengthInWord)
 	return big.NewInt(int64(math.Round(pvg)))
 }
 

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ type Overhead struct {`
`25`	`25`	`// CalcPreVerificationGas returns an expected gas cost for processing a UserOperation from a batch.`
`26`	`26`	`func (ov Overhead) CalcPreVerificationGas(op userop.UserOperation) *big.Int {`
`27`	`27`	`packed := op.Pack()`
	`28`	`+ lengthInWord := float64(len(packed)+31) / 32`
`28`	`29`	`callDataCost := float64(0)`
`29`	`30`
`30`	`31`	`for _, b := range packed {`
`@@ -35,9 +36,7 @@ func (ov Overhead) CalcPreVerificationGas(op userop.UserOperation) *big.Int {`
`35`	`36`	`}`
`36`	`37`	`}`
`37`	`38`
`38`		`- pvg := callDataCost + (ov.fixed / ov.minBundleSize) + ov.perUserOp + ov.perUserOpWord*float64(`
`39`		`- (len(packed)),`
`40`		`- )`
	`39`	`+ pvg := callDataCost + (ov.fixed / ov.minBundleSize) + ov.perUserOp + (ov.perUserOpWord * lengthInWord)`
`41`	`40`	`return big.NewInt(int64(math.Round(pvg)))`
`42`	`41`	`}`
`43`	`42`