feat(api): manual updates (#16)

Author: stainless-app[bot]

README.md

@@ -30,7 +30,7 @@ const client = new Stainless({
 });
 
 async function main() {
-  const output = await client.builds.outputs.retrieve({ id: 'bui_123', target: 'node' });
+  const output = await client.builds.outputs.retrieve('node', { id: 'bui_123' });
 
   console.log(output.commit);
 }
@@ -51,8 +51,11 @@ const client = new Stainless({
 });
 
 async function main() {
-  const params: Stainless.Builds.OutputRetrieveParams = { id: 'bui_123', target: 'node' };
-  const output: Stainless.Builds.OutputRetrieveResponse = await client.builds.outputs.retrieve(params);
+  const params: Stainless.Builds.OutputRetrieveParams = { id: 'bui_123' };
+  const output: Stainless.Builds.OutputRetrieveResponse = await client.builds.outputs.retrieve(
+    'node',
+    params,
+  );
 }
 
 main();
@@ -69,17 +72,15 @@ a subclass of `APIError` will be thrown:
 <!-- prettier-ignore -->
 ```ts
 async function main() {
-  const output = await client.builds.outputs
-    .retrieve({ id: 'bui_123', target: 'node' })
-    .catch(async (err) => {
-      if (err instanceof Stainless.APIError) {
-        console.log(err.status); // 400
-        console.log(err.name); // BadRequestError
-        console.log(err.headers); // {server: 'nginx', ...}
-      } else {
-        throw err;
-      }
-    });
+  const output = await client.builds.outputs.retrieve('node', { id: 'bui_123' }).catch(async (err) => {
+    if (err instanceof Stainless.APIError) {
+      console.log(err.status); // 400
+      console.log(err.name); // BadRequestError
+      console.log(err.headers); // {server: 'nginx', ...}
+    } else {
+      throw err;
+    }
+  });
 }
 
 main();
@@ -114,7 +115,7 @@ const client = new Stainless({
 });
 
 // Or, configure per-request:
-await client.builds.outputs.retrieve({ id: 'bui_123', target: 'node' }, {
+await client.builds.outputs.retrieve('node', { id: 'bui_123' }, {
   maxRetries: 5,
 });
 ```
@@ -131,7 +132,7 @@ const client = new Stainless({
 });
 
 // Override per-request:
-await client.builds.outputs.retrieve({ id: 'bui_123', target: 'node' }, {
+await client.builds.outputs.retrieve('node', { id: 'bui_123' }, {
   timeout: 5 * 1000,
 });
 ```
@@ -152,12 +153,12 @@ You can also use the `.withResponse()` method to get the raw `Response` along wi
 ```ts
 const client = new Stainless();
 
-const response = await client.builds.outputs.retrieve({ id: 'bui_123', target: 'node' }).asResponse();
+const response = await client.builds.outputs.retrieve('node', { id: 'bui_123' }).asResponse();
 console.log(response.headers.get('X-My-Header'));
 console.log(response.statusText); // access the underlying Response object
 
 const { data: output, response: raw } = await client.builds.outputs
-  .retrieve({ id: 'bui_123', target: 'node' })
+  .retrieve('node', { id: 'bui_123' })
   .withResponse();
 console.log(raw.headers.get('X-My-Header'));
 console.log(output.commit);
@@ -267,7 +268,8 @@ const client = new Stainless({
 
 // Override per-request:
 await client.builds.outputs.retrieve(
-  { id: 'bui_123', target: 'node' },
+  'node',
+  { id: 'bui_123' },
   {
     httpAgent: new http.Agent({ keepAlive: false }),
   },

api.md

@@ -24,4 +24,4 @@ Types:
 
 Methods:
 
-- <code title="get /v1/builds/{id}/outputs/{target}">client.builds.outputs.<a href="./src/resources/builds/outputs.ts">retrieve</a>({ ...params }) -> OutputRetrieveResponse</code>
+- <code title="get /v1/builds/{id}/outputs/{target}">client.builds.outputs.<a href="./src/resources/builds/outputs.ts">retrieve</a>(target, { ...params }) -> OutputRetrieveResponse</code>

src/resources/builds/outputs.ts

@@ -8,8 +8,12 @@ export class Outputs extends APIResource {
   /**
    * Get the output status and details for a specific target for a specific build
    */
-  retrieve(params: OutputRetrieveParams, options?: RequestOptions): APIPromise<OutputRetrieveResponse> {
-    const { id, target } = params;
+  retrieve(
+    target: 'node' | 'python' | 'go' | 'java' | 'kotlin' | 'ruby',
+    params: OutputRetrieveParams,
+    options?: RequestOptions,
+  ): APIPromise<OutputRetrieveResponse> {
+    const { id } = params;
     return this._client.get(`/v1/builds/${id}/outputs/${target}`, options);
   }
 }
@@ -122,11 +126,6 @@ export interface OutputRetrieveParams {
    * The build ID
    */
   id: string;
-
-  /**
-   * The target to get the output for
-   */
-  target: 'node' | 'python' | 'go' | 'java' | 'kotlin' | 'ruby';
 }
 
 export declare namespace Outputs {

tests/api-resources/builds/outputs.test.ts

@@ -9,7 +9,7 @@ const client = new Stainless({
 
 describe('resource outputs', () => {
   test('retrieve: only required params', async () => {
-    const responsePromise = client.builds.outputs.retrieve({ id: 'id', target: 'node' });
+    const responsePromise = client.builds.outputs.retrieve('node', { id: 'id' });
     const rawResponse = await responsePromise.asResponse();
     expect(rawResponse).toBeInstanceOf(Response);
     const response = await responsePromise;
@@ -20,6 +20,6 @@ describe('resource outputs', () => {
   });
 
   test('retrieve: required and optional params', async () => {
-    const response = await client.builds.outputs.retrieve({ id: 'id', target: 'node' });
+    const response = await client.builds.outputs.retrieve('node', { id: 'id' });
   });
 });