Fix timeout handling in inline package

Update inline package to properly handle time.Duration timeouts after the
config changes. Remove unused time import and fix test cases to use duration
strings instead of numeric values.

Author: dgellow

internal/inline/resolver.go

@@ -3,6 +3,7 @@ package inline
 import (
 	"encoding/json"
 	"fmt"
+	"time"
 
 	"github.com/dgellow/mcp-front/internal/config"
 )
@@ -57,6 +58,13 @@ func ResolveConfig(rawConfig json.RawMessage) (Config, []ResolvedToolConfig, err
 			resolved.Env = values
 		}
 
+		// Validate timeout format if specified
+		if resolved.Timeout != "" {
+			if _, err := time.ParseDuration(resolved.Timeout); err != nil {
+				return Config{}, nil, fmt.Errorf("invalid timeout format for tool %s: %w (use Go duration format like '30s', '5m', '1h')", tool.Name, err)
+			}
+		}
+
 		resolvedTools[i] = resolved
 	}
 

internal/inline/resolver_test.go

@@ -111,7 +111,7 @@ func TestResolveConfig(t *testing.T) {
 						"inputSchema": {"type": "object"},
 						"command": "echo",
 						"args": ["two"],
-						"timeout": 30000000000
+						"timeout": "30s"
 					}
 				]
 			}`,
@@ -120,7 +120,7 @@ func TestResolveConfig(t *testing.T) {
 				assert.Len(t, tools, 2)
 				assert.Equal(t, "tool1", tools[0].Name)
 				assert.Equal(t, "tool2", tools[1].Name)
-				assert.Equal(t, 30*1000*1000*1000, int(tools[1].Timeout)) // 30s in nanoseconds
+				assert.Equal(t, "30s", tools[1].Timeout)
 			},
 		},
 	}

internal/inline/server.go

@@ -8,6 +8,7 @@ import (
 	"os"
 	"os/exec"
 	"strings"
+	"time"
 
 	"github.com/dgellow/mcp-front/internal"
 )
@@ -92,11 +93,14 @@ func (s *Server) HandleToolCall(ctx context.Context, toolName string, args map[s
 	cmd.Env = append(cmd.Env, os.Environ()...)
 
 	// Set timeout if specified
-	if tool.Timeout > 0 {
-		var cancel context.CancelFunc
-		ctx, cancel = context.WithTimeout(ctx, tool.Timeout)
-		defer cancel()
-		cmd = exec.CommandContext(ctx, tool.Command, tool.Args...)
+	if tool.Timeout != "" {
+		timeout, _ := time.ParseDuration(tool.Timeout)
+		if timeout > 0 {
+			var cancel context.CancelFunc
+			ctx, cancel = context.WithTimeout(ctx, timeout)
+			defer cancel()
+			cmd = exec.CommandContext(ctx, tool.Command, tool.Args...)
+		}
 	}
 
 	// Capture output

internal/inline/server_test.go

@@ -198,7 +198,7 @@ func TestServer_HandleToolCall_Timeout(t *testing.T) {
 			Description: "Slow command",
 			Command:     "sleep",
 			Args:        []string{"5"},
-			Timeout:     100 * 1000 * 1000, // 100ms in nanoseconds
+			Timeout:     "100ms",
 		},
 	}
 

internal/inline/types.go

@@ -2,7 +2,6 @@ package inline
 
 import (
 	"encoding/json"
-	"time"
 )
 
 // Config represents an inline MCP server configuration
@@ -19,7 +18,7 @@ type ToolConfig struct {
 	Command     string                     `json:"command"`           // Command to run (e.g., "docker", "gcloud", etc.)
 	Args        []json.RawMessage          `json:"args,omitempty"`    // Arguments with {"$env": "..."} support
 	Env         map[string]json.RawMessage `json:"env,omitempty"`     // Environment variables with {"$env": "..."} support
-	Timeout     time.Duration              `json:"timeout,omitempty"` // Timeout for command execution
+	Timeout     string                     `json:"timeout,omitempty"` // Timeout for command execution (e.g. "30s")
 }
 
 // ResolvedToolConfig represents a tool config with all values resolved
@@ -30,5 +29,5 @@ type ResolvedToolConfig struct {
 	Command     string            `json:"command"`
 	Args        []string          `json:"args,omitempty"` // Resolved arguments
 	Env         map[string]string `json:"env,omitempty"`  // Resolved environment variables
-	Timeout     time.Duration     `json:"timeout,omitempty"`
+	Timeout     string            `json:"timeout,omitempty"`
 }