diff --git a/src/strategies/php.ts b/src/strategies/php.ts index 9136aa9a9..32fdc4bf3 100644 --- a/src/strategies/php.ts +++ b/src/strategies/php.ts @@ -15,7 +15,7 @@ // Generic import {Changelog} from '../updaters/changelog'; // PHP Specific. -import {RootComposerUpdatePackages} from '../updaters/php/root-composer-update-packages'; +// import {RootComposerUpdatePackages} from '../updaters/php/root-composer-update-packages'; import {BaseStrategy, BuildUpdatesOptions, BaseStrategyOptions} from './base'; import {Update} from '../update'; import {VersionsMap} from '../version'; @@ -57,6 +57,11 @@ export class PHP extends BaseStrategy { }), }); + /** + + STAINLESS-EDIT: Note from Hao & Jacob: In Packagist we want to prefer using the github tag rather than + composer version. Releases can be skipped if the tag version misaligns with the composer version. + // update composer.json updates.push({ path: this.addPath('composer.json'), @@ -65,7 +70,8 @@ export class PHP extends BaseStrategy { version, versionsMap, }), - }); + }); + */ return updates; } diff --git a/test/strategies/php.ts b/test/strategies/php.ts index 05da02f13..4d0d325b6 100644 --- a/test/strategies/php.ts +++ b/test/strategies/php.ts @@ -22,7 +22,7 @@ import {buildMockConventionalCommit} from '../helpers'; import {TagName} from '../../src/util/tag-name'; import {Version} from '../../src/version'; import {Changelog} from '../../src/updaters/changelog'; -import {RootComposerUpdatePackages} from '../../src/updaters/php/root-composer-update-packages'; +// import {RootComposerUpdatePackages} from '../../src/updaters/php/root-composer-update-packages'; const sandbox = sinon.createSandbox(); @@ -95,9 +95,14 @@ describe('PHP', () => { latestRelease, }); const updates = release!.updates; - expect(updates).lengthOf(2); + // Stainless EDIT: we removed updates to the composer.json file + expect(updates).lengthOf(1); assertHasUpdate(updates, 'CHANGELOG.md', Changelog); - assertHasUpdate(updates, 'composer.json', RootComposerUpdatePackages); + + // Original: + // expect(updates).lengthOf(2); + // assertHasUpdate(updates, 'CHANGELOG.md', Changelog); + // assertHasUpdate(updates, 'composer.json', RootComposerUpdatePackages); }); }); });