Show linter errors on stl lint using the nice format

Author: Bruce Hill

cmd/stl-docs/main.go

@@ -66,7 +66,7 @@ func generateManpage(filename string) error {
 
 	app := cmd.Command
 
-	manpage, err := docs.ToMan(&app)
+	manpage, err := docs.ToMan(app)
 	if err != nil {
 		return err
 	}
@@ -87,7 +87,7 @@ func generateMarkdown(filename string) error {
 
 	app := cmd.Command
 
-	md, err := docs.ToMarkdown(&app)
+	md, err := docs.ToMarkdown(app)
 	if err != nil {
 		return err
 	}

pkg/cmd/dev.go

@@ -271,11 +271,6 @@ var devCommand = cli.Command{
 			Value:   false,
 			Usage:   "Only check for diagnostic errors without running a full build.",
 		},
-		&cli.StringFlag{
-			Name:  "lint-format",
-			Value: "pretty",
-			Usage: "The format for the linter output.",
-		},
 		&cli.BoolFlag{
 			Name:  "lint-first",
 			Value: false,
@@ -380,7 +375,9 @@ func runPreview(ctx context.Context, cmd *cli.Command) error {
 				}
 				return err
 			}
-			ShowJSON("Linting Results", diagnostics.Raw, cmd.String("lint-format"))
+			jsonObj := gjson.Parse(diagnostics.Raw)
+			transform := cmd.String("transform")
+			ShowJSON("Linting Results", jsonObj, cmd.String("format"), transform)
 		}
 
 		// Start the build process
@@ -422,17 +419,16 @@ func runLintLoop(ctx context.Context, cmd *cli.Command) error {
 			}
 			return err
 		}
-		ShowJSON("Diagnostics", diagnostics.Raw, cmd.String("lint-format"))
+		jsonObj := gjson.Parse(diagnostics.Raw)
+		ShowJSON("Diagnostics", jsonObj, cmd.String("format"), cmd.String("transform"))
 
 		if !cmd.Bool("watch") {
 			break
 		}
 
-		// Watch for file changes instead of sleeping
 		for {
-			time.Sleep(500 * time.Millisecond) // Check every 500ms
+			time.Sleep(500 * time.Millisecond)
 
-			// Check OpenAPI spec file
 			if openapiSpecStat, err := os.Stat(openapiSpecPath); err == nil {
 				if openapiSpecStat.ModTime().After(openapiSpecLastModified) {
 					openapiSpecLastModified = openapiSpecStat.ModTime()

pkg/cmd/dev_view.go

@@ -5,7 +5,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/charmbracelet/bubbletea"
+	tea "github.com/charmbracelet/bubbletea"
 	"github.com/charmbracelet/glamour"
 	"github.com/charmbracelet/lipgloss"
 	"github.com/stainless-api/stainless-api-go"
@@ -397,10 +397,9 @@ func ViewDiagnosticsPrint(diagnostics []stainless.BuildDiagnostic) string {
 		s.WriteString(lipgloss.NewStyle().
 			Padding(1).
 			Border(lipgloss.RoundedBorder()).
-			BorderForeground(lipgloss.Color("7")).
+			BorderForeground(lipgloss.Color("208")).
 			Render(strings.TrimRight(sub.String(), "\n")),
 		)
-		s.WriteString("\n\n")
 	} else {
 		s.WriteString(SProperty(0, "diagnostics", "(no errors or warnings)"))
 	}

pkg/cmd/lint.go

@@ -2,9 +2,13 @@ package cmd
 
 import (
 	"context"
+	"encoding/json"
+	"fmt"
 	"os"
 
+	"github.com/stainless-api/stainless-api-go"
 	"github.com/stainless-api/stainless-api-go/option"
+	"github.com/tidwall/gjson"
 	"github.com/urfave/cli/v3"
 )
 
@@ -63,5 +67,23 @@ func runLinter(ctx context.Context, cmd *cli.Command) error {
 	if err != nil {
 		return err
 	}
-	return ShowJSON("Diagnostics", string(result), "json")
+
+	transform := "spec.diagnostics.@values.@flatten.#(ignored==false)#"
+	jsonObj := gjson.Parse(string(result)).Get(transform)
+	var diagnostics []stainless.BuildDiagnostic
+	json.Unmarshal([]byte(jsonObj.Raw), &diagnostics)
+	fmt.Println(ViewDiagnosticsPrint(diagnostics))
+	for _, d := range diagnostics {
+		if !d.Ignored {
+			switch d.Level {
+			case stainless.BuildDiagnosticLevelFatal:
+			case stainless.BuildDiagnosticLevelError:
+			case stainless.BuildDiagnosticLevelWarning:
+				os.Exit(1)
+			case stainless.BuildDiagnosticLevelNote:
+				continue
+			}
+		}
+	}
+	return nil
 }