chore: use stretchr/testify assertion helpers in tests

Author: stainless-app[bot]

internal/debugmiddleware/debug_middleware_test.go

@@ -5,9 +5,10 @@ import (
 	"log"
 	"net/http"
 	"net/http/httptest"
-	"reflect"
 	"strings"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestDebugMiddleware(t *testing.T) {
@@ -37,20 +38,13 @@ func TestDebugMiddleware(t *testing.T) {
 			nextMiddlewareRan = true
 
 			// The request sent down through middleware shouldn't be mutated.
-			if req.Header.Get("User-Agent") != stainlessUserAgent {
-				t.Error("expected original request to be unmodified")
-			}
+			require.Equal(t, stainlessUserAgent, req.Header.Get("User-Agent"))
 
 			return &http.Response{}, nil
 		})
 
-		if !nextMiddlewareRan {
-			t.Error("expected next middleware to have been run")
-		}
-
-		if !strings.Contains(logBuf.String(), "User-Agent: "+stainlessUserAgent) {
-			t.Error("expected logged request headers to include `User-Agent: Stainless`")
-		}
+		require.True(t, nextMiddlewareRan)
+		require.Contains(t, logBuf.String(), "User-Agent: "+stainlessUserAgent)
 	})
 
 	const secretToken = "secret-token"
@@ -68,20 +62,13 @@ func TestDebugMiddleware(t *testing.T) {
 			nextMiddlewareRan = true
 
 			// The request sent down through middleware shouldn't be mutated.
-			if req.Header.Get("Authorization") != secretToken {
-				t.Error("expected original request to be unmodified")
-			}
+			require.Equal(t, secretToken, req.Header.Get("Authorization"))
 
 			return &http.Response{}, nil
 		})
 
-		if !nextMiddlewareRan {
-			t.Error("expected next middleware to have been run")
-		}
-
-		if !strings.Contains(logBuf.String(), "Authorization: "+redactedPlaceholder) {
-			t.Error("expected authorization header to be redacted")
-		}
+		require.True(t, nextMiddlewareRan)
+		require.Contains(t, logBuf.String(), "Authorization: "+redactedPlaceholder)
 	})
 
 	t.Run("RedactsOnlySecretInAuthorizationHeader", func(t *testing.T) {
@@ -99,13 +86,8 @@ func TestDebugMiddleware(t *testing.T) {
 			return &http.Response{}, nil
 		})
 
-		if !nextMiddlewareRan {
-			t.Error("expected next middleware to have been run")
-		}
-
-		if !strings.Contains(logBuf.String(), "Authorization: Bearer "+redactedPlaceholder) {
-			t.Error("expected authorization header to be redacted")
-		}
+		require.True(t, nextMiddlewareRan)
+		require.Contains(t, logBuf.String(), "Authorization: Bearer "+redactedPlaceholder)
 	})
 
 	t.Run("RedactsMultipleAuthorizationHeaders", func(t *testing.T) {
@@ -122,16 +104,12 @@ func TestDebugMiddleware(t *testing.T) {
 			nextMiddlewareRan = true
 
 			// The request sent down through middleware shouldn't be mutated.
-			if !reflect.DeepEqual(req.Header.Values("Authorization"), []string{secretToken + "1", secretToken + "2"}) {
-				t.Errorf("expected original request to be unmodified")
-			}
+			require.Equal(t, []string{secretToken + "1", secretToken + "2"}, req.Header.Values("Authorization"))
 
 			return &http.Response{}, nil
 		})
 
-		if !nextMiddlewareRan {
-			t.Error("expected next middleware to have been run")
-		}
+		require.True(t, nextMiddlewareRan)
 
 		if strings.Count(logBuf.String(), "Authorization: "+redactedPlaceholder) != 2 {
 			t.Error("expected exactly two redacted placeholders in authorization headers")
@@ -155,20 +133,13 @@ func TestDebugMiddleware(t *testing.T) {
 			nextMiddlewareRan = true
 
 			// The request sent down through middleware shouldn't be mutated.
-			if req.Header.Get(customAPIKeyHeader) != secretToken {
-				t.Error("expected original request to be unmodified")
-			}
+			require.Equal(t, secretToken, req.Header.Get(customAPIKeyHeader))
 
 			return &http.Response{}, nil
 		})
 
-		if !nextMiddlewareRan {
-			t.Error("expected next middleware to have been run")
-		}
-
-		if !strings.Contains(logBuf.String(), customAPIKeyHeader+": "+redactedPlaceholder) {
-			t.Errorf("expected %s header to be redacted", customAPIKeyHeader)
-		}
+		require.True(t, nextMiddlewareRan)
+		require.Contains(t, logBuf.String(), customAPIKeyHeader+": "+redactedPlaceholder)
 	})
 
 	t.Run("RedactsMultipleSensitiveHeaders", func(t *testing.T) {
@@ -187,19 +158,12 @@ func TestDebugMiddleware(t *testing.T) {
 			nextMiddlewareRan = true
 
 			// The request sent down through middleware shouldn't be mutated.
-			if !reflect.DeepEqual(req.Header.Values(customAPIKeyHeader), []string{secretToken + "1", secretToken + "2"}) {
-				t.Error("expected original request to be unmodified")
-			}
+			require.Equal(t, []string{secretToken + "1", secretToken + "2"}, req.Header.Values(customAPIKeyHeader))
 
 			return &http.Response{}, nil
 		})
 
-		if !nextMiddlewareRan {
-			t.Error("expected next middleware to have been run")
-		}
-
-		if strings.Count(logBuf.String(), customAPIKeyHeader+": "+redactedPlaceholder) != 2 {
-			t.Errorf("expected %s header to be redacted", customAPIKeyHeader)
-		}
+		require.True(t, nextMiddlewareRan)
+		require.Equal(t, 2, strings.Count(logBuf.String(), customAPIKeyHeader+": "+redactedPlaceholder))
 	})
 }