Working version of fast diagnostics

Author: Bruce Hill

go.mod

@@ -1,8 +1,6 @@
 module github.com/stainless-api/stainless-api-cli
 
-go 1.24.4
-
-toolchain go1.24.7
+go 1.25
 
 require (
 	github.com/charmbracelet/bubbles v0.21.0
@@ -12,6 +10,7 @@ require (
 	github.com/charmbracelet/lipgloss v1.1.1-0.20250404203927-76690c660834
 	github.com/charmbracelet/x/ansi v0.8.0
 	github.com/charmbracelet/x/term v0.2.1
+	github.com/fsnotify/fsnotify v1.9.0
 	github.com/itchyny/json2yaml v0.1.4
 	github.com/logrusorgru/aurora/v4 v4.0.0
 	github.com/muesli/reflow v0.3.0

go.sum

@@ -60,6 +60,8 @@ github.com/dustin/go-humanize v1.0.1 h1:GzkhY7T5VNhEkwH0PVJgjz+fX1rhBrR7pRT3mDkp
 github.com/dustin/go-humanize v1.0.1/go.mod h1:Mu1zIs6XwVuF/gI1OepvI0qD18qycQx+mFykh5fBlto=
 github.com/erikgeiser/coninput v0.0.0-20211004153227-1c3628e74d0f h1:Y/CXytFA4m6baUTXGLOoWe4PQhGxaX0KpnayAqC48p4=
 github.com/erikgeiser/coninput v0.0.0-20211004153227-1c3628e74d0f/go.mod h1:vw97MGsxSvLiUE2X8qFplwetxpGLQrlU1Q9AUEIzCaM=
+github.com/fsnotify/fsnotify v1.9.0 h1:2Ml+OJNzbYCTzsxtv8vKSFD9PbJjmhYF14k/jKC7S9k=
+github.com/fsnotify/fsnotify v1.9.0/go.mod h1:8jBTzvmWwFyi3Pb8djgCCO5IBqzKJ/Jwo8TRcHyHii0=
 github.com/gorilla/css v1.0.1 h1:ntNaBIghp6JmvWnxbZKANoLyuXTPZ4cAMlo6RyhlbO8=
 github.com/gorilla/css v1.0.1/go.mod h1:BvnYkspnSzMmwRK+b8/xgNPLiIuNZr6vbZBTPQ2A3b0=
 github.com/hexops/gotextdiff v1.0.3 h1:gitA9+qJrrTCsiCl7+kh75nPqQt1cx4ZkudSTLoUqJM=

pkg/cmd/dev.go

@@ -47,6 +47,7 @@ type fetchBuildMsg *stainless.Build
 type fetchDiagnosticsMsg []stainless.BuildDiagnostic
 type errorMsg error
 type downloadMsg stainless.Target
+type fileChangeMsg struct{}
 
 func NewBuildModel(cc *apiCommandContext, ctx context.Context, branch string, fn func() (*stainless.Build, error)) BuildModel {
 	return BuildModel{
@@ -160,6 +161,10 @@ func (m BuildModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 	case errorMsg:
 		m.err = msg
 		cmds = append(cmds, tea.Quit)
+
+	case fileChangeMsg:
+		// File change detected, exit with success
+		cmds = append(cmds, tea.Quit)
 	}
 	return m, tea.Sequence(cmds...)
 }
@@ -367,6 +372,9 @@ func runPreview(ctx context.Context, cmd *cli.Command) error {
 			if hasBlockingDiagnostic(diagnostics) {
 				fmt.Println("\nDiagnostic checks will re-run once you edit your configuration files...")
 				if err := waitTillConfigChanges(ctx, cmd, cc); err != nil {
+					if errors.Is(err, ErrUserCancelled) {
+						return nil
+					}
 					return err
 				}
 				continue
@@ -400,32 +408,46 @@ func waitTillConfigChanges(ctx context.Context, cmd *cli.Command, cc *apiCommand
 		stainlessConfigPath = cmd.String("stainless-config")
 	}
 
-	files := []string{openapiSpecPath, stainlessConfigPath}
-	lastModified := make(map[string]time.Time)
-	for _, file := range files {
-		if stat, err := os.Stat(file); err == nil {
-			lastModified[file] = stat.ModTime()
-		}
+	// Get initial file modification times
+	openapiSpecInfo, err := os.Stat(openapiSpecPath)
+	if err != nil {
+		return fmt.Errorf("failed to get file info for %s: %v", openapiSpecPath, err)
+	}
+	openapiSpecModTime := openapiSpecInfo.ModTime()
+
+	stainlessConfigInfo, err := os.Stat(stainlessConfigPath)
+	if err != nil {
+		return fmt.Errorf("failed to get file info for %s: %v", stainlessConfigPath, err)
 	}
+	stainlessConfigModTime := stainlessConfigInfo.ModTime()
+
+	fmt.Println("Waiting for file changes...")
+
+	// Poll for file changes every 250ms
+	ticker := time.NewTicker(250 * time.Millisecond)
+	defer ticker.Stop()
 
 	for {
-		time.Sleep(500 * time.Millisecond)
+		select {
+		case <-ticker.C:
+			// Check OpenAPI spec file
+			if info, err := os.Stat(openapiSpecPath); err == nil {
+				if info.ModTime().After(openapiSpecModTime) {
+					return nil
+				}
+			}
 
-		for _, file := range files {
-			if stat, err := os.Stat(file); err == nil {
-				if stat.ModTime().After(lastModified[file]) {
+			// Check Stainless config file
+			if info, err := os.Stat(stainlessConfigPath); err == nil {
+				if info.ModTime().After(stainlessConfigModTime) {
 					return nil
 				}
 			}
-		}
-		// Check for cancellation
-		select {
+
 		case <-ctx.Done():
 			return ctx.Err()
-		default:
 		}
 	}
-	return nil
 }
 
 func runDevBuild(ctx context.Context, cc *apiCommandContext, cmd *cli.Command, branch string, languages []stainless.Target) error {
@@ -496,6 +518,15 @@ func getCurrentGitBranch() (string, error) {
 	return branch, nil
 }
 
+type GenerateSpecParams struct {
+	Project string `json:"project"`
+	Source  struct {
+		Type            string `json:"type"`
+		OpenAPISpec     string `json:"openapi_spec"`
+		StainlessConfig string `json:"stainless_config"`
+	} `json:"source"`
+}
+
 func getDiagnostics(ctx context.Context, cmd *cli.Command, cc *apiCommandContext) ([]stainless.BuildDiagnostic, error) {
 	var specParams GenerateSpecParams
 	if cmd.IsSet("project") {

pkg/cmd/dev_view.go

@@ -394,7 +394,7 @@ func ViewDiagnosticsPrint(diagnostics []stainless.BuildDiagnostic, maxDiagnostic
 
 		s.WriteString(SProperty(0, "diagnostics", summary))
 		s.WriteString(lipgloss.NewStyle().
-			Padding(1).
+			Padding(0).
 			Border(lipgloss.RoundedBorder()).
 			BorderForeground(lipgloss.Color("208")).
 			Render(strings.TrimRight(sub.String(), "\n")),