fix: handle edge cases in build view component better

Author: yjp20

pkg/cmd/build.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"os"
 	"path"
+	"slices"
 	"strings"
 
 	tea "github.com/charmbracelet/bubbletea"
@@ -252,13 +253,15 @@ func (c buildCompletionModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 	return c, cmd
 }
 
+var GOOD_COMMIT_CONCLUSIONS = []string{"error", "warning", "note", "success"}
+
 func (c buildCompletionModel) IsCompleted() bool {
 	b := stainlessutils.NewBuild(c.Build.Build)
 	for _, target := range b.Languages() {
 		buildTarget := b.BuildTarget(target)
 
-		downloadIsCompleted := true
-		if buildTarget.IsCompleted() {
+		var downloadIsCompleted = true
+		if buildTarget.IsCommitCompleted() && slices.Contains(GOOD_COMMIT_CONCLUSIONS, buildTarget.Commit.Completed.Conclusion) {
 			if download, ok := c.Build.Downloads[target]; ok {
 				if download.Status != "completed" {
 					downloadIsCompleted = false

pkg/components/build/model.go

@@ -32,15 +32,20 @@ type Model struct {
 }
 
 type DownloadStatus struct {
-	Status     string // one of "not_started" "in_progress" "completed"
+	Status string // one of "not_started" "in_progress" "completed"
+	// One of "success", "failure', or empty if Status not "completed"
 	Conclusion string
 	Path       string
 }
 
 type TickMsg time.Time
 type FetchBuildMsg stainless.Build
 type ErrorMsg error
-type DownloadMsg stainless.Target
+type DownloadMsg struct {
+	Target stainless.Target
+	// One of "success", "failure',
+	Conclusion string
+}
 
 func NewModel(client stainless.Client, ctx context.Context, build stainless.Build, downloadPaths map[stainless.Target]string) Model {
 	downloads := map[stainless.Target]DownloadStatus{}
@@ -84,9 +89,10 @@ func (m Model) Update(msg tea.Msg) (Model, tea.Cmd) {
 		}))
 
 	case DownloadMsg:
-		download := m.Downloads[stainless.Target(msg)]
+		download := m.Downloads[msg.Target]
 		download.Status = "completed"
-		m.Downloads[stainless.Target(msg)] = download
+		download.Conclusion = msg.Conclusion
+		m.Downloads[msg.Target] = download
 
 	case FetchBuildMsg:
 		m.Build = stainless.Build(msg)
@@ -132,9 +138,9 @@ func (m Model) downloadTarget(target stainless.Target) tea.Cmd {
 		}
 		err = PullOutput(outputRes.Output, outputRes.URL, outputRes.Ref, m.Downloads[target].Path, console.NewGroup(true))
 		if err != nil {
-			return ErrorMsg(err)
+			return DownloadMsg{target, "failure"}
 		}
-		return DownloadMsg(target)
+		return DownloadMsg{target, "success"}
 	}
 }
 

pkg/components/build/view.go

@@ -68,7 +68,7 @@ func ViewBuildPipeline(build stainless.Build, target stainless.Target, downloads
 		if pipeline.Len() > 0 {
 			pipeline.WriteString("  ")
 		}
-		// align our naming of the commit step with the
+		// align our naming of the commit step with the version in the Studio
 		if step == "commit" {
 			step = "codegen"
 		}

pkg/stainlessutils/stainlessutils.go

@@ -220,31 +220,11 @@ func (bt *BuildTarget) Steps() []string {
 }
 
 func (bt *BuildTarget) IsCompleted() bool {
-	steps := []string{"commit", "lint", "build", "test"}
-	for _, step := range steps {
-		if !gjson.Get(bt.RawJSON(), step).Exists() {
-			continue
-		}
-		status, _, conclusion := bt.StepInfo(step)
-		if conclusion == "merge_conflict" {
-			return true
-		}
-		if status != "completed" {
-			return false
-		}
-	}
-	return true
+	return bt.Status == "completed"
 }
 
 func (bt *BuildTarget) IsInProgress() bool {
-	steps := []string{"commit", "lint", "build", "test", "upload"}
-	for _, step := range steps {
-		status, _, _ := bt.StepInfo(step)
-		if status == "in_progress" {
-			return true
-		}
-	}
-	return false
+	return bt.Status != "completed"
 }
 
 func (bt *BuildTarget) IsCommitCompleted() bool {