fix: use errors pkg for comparison

follow this best practice: https://go.dev/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features

Author: PascalBourdier

pkg/monitors/appinsights/appinsights-monitor.go

@@ -6,14 +6,15 @@ import (
 	"encoding/xml"
 	"errors"
 	"fmt"
+	"net/http"
+	"os"
+
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/arm"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
 	"github.com/Azure/azure-sdk-for-go/sdk/azidentity"
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor"
-	"net/http"
-	"os"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/applicationinsights/armapplicationinsights"
 
@@ -194,7 +195,8 @@ func (aiService *AppinsightsMonitorService) GetByName(monitorName string) (*mode
 	log.Info("AppInsights Monitor's GetByName method has been called")
 	webtest, err := aiService.insightsClient.Get(aiService.ctx, aiService.resourceGroup, monitorName, nil)
 	if err != nil {
-		if re, ok := err.(*azcore.ResponseError); ok {
+		var re *azcore.ResponseError
+		if errors.As(err, &re) {
 			if re.StatusCode == http.StatusNotFound {
 				return nil, fmt.Errorf("Application Insights WebTest %s was not found in Resource Group %s", monitorName, aiService.resourceGroup)
 			}

pkg/monitors/gcloud/gcloud-monitor.go

@@ -2,17 +2,18 @@ package gcloud
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"net/url"
 	"strconv"
 
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
 
 	monitoring "cloud.google.com/go/monitoring/apiv3/v2"
-	monitoringpb "cloud.google.com/go/monitoring/apiv3/v2/monitoringpb"
+	"cloud.google.com/go/monitoring/apiv3/v2/monitoringpb"
 	"google.golang.org/api/iterator"
 	"google.golang.org/api/option"
-	monitoredres "google.golang.org/genproto/googleapis/api/monitoredres"
+	"google.golang.org/genproto/googleapis/api/monitoredres"
 
 	endpointmonitorv1alpha1 "github.com/stakater/IngressMonitorController/v2/api/v1alpha1"
 	"github.com/stakater/IngressMonitorController/v2/pkg/config"
@@ -52,7 +53,7 @@ func (service *MonitorService) GetByName(name string) (monitor *models.Monitor,
 
 	for {
 		uptimeCheckConfig, err := uptimeCheckConfigsIterator.Next()
-		if err == iterator.Done {
+		if errors.Is(err, iterator.Done) {
 			break
 		}
 		if err != nil {
@@ -75,7 +76,7 @@ func (service *MonitorService) GetAll() (monitors []models.Monitor) {
 	monitors = []models.Monitor{}
 	for {
 		uptimeCheckConfig, err := uptimeCheckConfigsIterator.Next()
-		if err == iterator.Done {
+		if errors.Is(err, iterator.Done) {
 			break
 		}
 		if err != nil {