Merge pull request #443 from stakater/lint-fix

Removed deprecated dependency and unnecessary condition

Author: hussnain612

.github/workflows/pull_request.yml

@@ -25,7 +25,7 @@ jobs:
     - name: Check out code
       uses: actions/checkout@v3
       with:
-        fetch-depth: 0
+        ref: ${{github.event.pull_request.head.sha}}
 
     - name: Set up Go
       uses: actions/setup-go@v3

pkg/monitors/gcloud/gcloud-monitor.go

@@ -8,7 +8,7 @@ import (
 
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
 
-	monitoring "cloud.google.com/go/monitoring/apiv3"
+	monitoring "cloud.google.com/go/monitoring/apiv3/v2"
 	"google.golang.org/api/iterator"
 	"google.golang.org/api/option"
 	monitoredres "google.golang.org/genproto/googleapis/api/monitoredres"

pkg/monitors/statuscake/statuscake-monitor.go

@@ -286,7 +286,7 @@ func (service *StatusCakeMonitorService) GetByID(id string) (*models.Monitor, er
 func (service *StatusCakeMonitorService) GetAll() []models.Monitor {
 	var StatusCakeMonitorData []StatusCakeMonitorData
 	page := 1
-	for true {
+	for {
 		res := service.fetchMonitors(page)
 		StatusCakeMonitorData = append(StatusCakeMonitorData, res.StatusCakeData...)
 		if page >= res.StatusCakeMetadata.PageCount {