Skip to content

Commit d86e753

Browse files
committed
fix: use Path::ends_with for cross-platform test compatibility
Replace string-based path suffix checks with Path::ends_with() to fix test failures on Windows where paths use backslashes instead of forward slashes.
1 parent bba97b2 commit d86e753

File tree

1 file changed

+11
-35
lines changed

1 file changed

+11
-35
lines changed

apps/cli/src/commands/core/config.rs

Lines changed: 11 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -943,73 +943,55 @@ project_skills_dir = ".custom/skills"
943943
// Kilo Code - ~/.kilocode/skills
944944
let kilocode = config.get_agent("kilocode").unwrap();
945945
assert!(
946-
kilocode
947-
.skills_dir
948-
.to_string_lossy()
949-
.ends_with(".kilocode/skills"),
946+
kilocode.skills_dir.ends_with(".kilocode/skills"),
950947
"kilocode skills_dir should end with .kilocode/skills, got: {}",
951948
kilocode.skills_dir.display()
952949
);
953950

954951
// Roo Code - ~/.roo/skills
955952
let roo = config.get_agent("roo").unwrap();
956953
assert!(
957-
roo.skills_dir.to_string_lossy().ends_with(".roo/skills"),
954+
roo.skills_dir.ends_with(".roo/skills"),
958955
"roo skills_dir should end with .roo/skills, got: {}",
959956
roo.skills_dir.display()
960957
);
961958

962959
// Gemini CLI - ~/.gemini/skills
963960
let gemini = config.get_agent("gemini").unwrap();
964961
assert!(
965-
gemini
966-
.skills_dir
967-
.to_string_lossy()
968-
.ends_with(".gemini/skills"),
962+
gemini.skills_dir.ends_with(".gemini/skills"),
969963
"gemini skills_dir should end with .gemini/skills, got: {}",
970964
gemini.skills_dir.display()
971965
);
972966

973967
// Antigravity - ~/.gemini/antigravity/skills
974968
let antigravity = config.get_agent("antigravity").unwrap();
975969
assert!(
976-
antigravity
977-
.skills_dir
978-
.to_string_lossy()
979-
.ends_with(".gemini/antigravity/skills"),
970+
antigravity.skills_dir.ends_with(".gemini/antigravity/skills"),
980971
"antigravity skills_dir should end with .gemini/antigravity/skills, got: {}",
981972
antigravity.skills_dir.display()
982973
);
983974

984975
// Clawdbot - ~/.clawdbot/skills
985976
let clawdbot = config.get_agent("clawdbot").unwrap();
986977
assert!(
987-
clawdbot
988-
.skills_dir
989-
.to_string_lossy()
990-
.ends_with(".clawdbot/skills"),
978+
clawdbot.skills_dir.ends_with(".clawdbot/skills"),
991979
"clawdbot skills_dir should end with .clawdbot/skills, got: {}",
992980
clawdbot.skills_dir.display()
993981
);
994982

995983
// Droid - ~/.factory/skills
996984
let droid = config.get_agent("droid").unwrap();
997985
assert!(
998-
droid
999-
.skills_dir
1000-
.to_string_lossy()
1001-
.ends_with(".factory/skills"),
986+
droid.skills_dir.ends_with(".factory/skills"),
1002987
"droid skills_dir should end with .factory/skills, got: {}",
1003988
droid.skills_dir.display()
1004989
);
1005990

1006991
// Windsurf - ~/.codeium/windsurf/skills
1007992
let windsurf = config.get_agent("windsurf").unwrap();
1008993
assert!(
1009-
windsurf
1010-
.skills_dir
1011-
.to_string_lossy()
1012-
.ends_with(".codeium/windsurf/skills"),
994+
windsurf.skills_dir.ends_with(".codeium/windsurf/skills"),
1013995
"windsurf skills_dir should end with .codeium/windsurf/skills, got: {}",
1014996
windsurf.skills_dir.display()
1015997
);
@@ -1029,10 +1011,7 @@ project_skills_dir = ".custom/skills"
10291011

10301012
// Global dir should still be ~/.copilot/skills
10311013
assert!(
1032-
copilot
1033-
.skills_dir
1034-
.to_string_lossy()
1035-
.ends_with(".copilot/skills"),
1014+
copilot.skills_dir.ends_with(".copilot/skills"),
10361015
"copilot global skills_dir should end with .copilot/skills, got: {}",
10371016
copilot.skills_dir.display()
10381017
);
@@ -1051,11 +1030,8 @@ project_skills_dir = ".custom/skills"
10511030
);
10521031

10531032
assert!(
1054-
opencode
1055-
.skills_dir
1056-
.to_string_lossy()
1057-
.contains("opencode/skill"),
1058-
"opencode global skills_dir should contain opencode/skill, got: {}",
1033+
opencode.skills_dir.ends_with("opencode/skill"),
1034+
"opencode global skills_dir should end with opencode/skill, got: {}",
10591035
opencode.skills_dir.display()
10601036
);
10611037
}
@@ -1104,7 +1080,7 @@ project_skills_dir = ".custom/skills"
11041080
.resolve_skills_dir(Scope::Global, Some(agent_id), None)
11051081
.unwrap();
11061082
assert!(
1107-
result.to_string_lossy().ends_with(expected_suffix),
1083+
result.ends_with(expected_suffix),
11081084
"Agent '{}' global dir should end with '{}', got: {}",
11091085
agent_id,
11101086
expected_suffix,

0 commit comments

Comments
 (0)