Generic HTTP client instead of reqwest #15
Unanswered
WhyNotHugo
asked this question in
Q&A
Replies: 3 comments 2 replies
-
Please note that I'm asking whether you'd consider this an acceptable improvement, not whether you're willing to put the work. I believe I might be able to work on this refactor myself. |
Beta Was this translation helpful? Give feedback.
0 replies
-
See also: https://sans-io.readthedocs.io/ |
Beta Was this translation helpful? Give feedback.
0 replies
-
Hi, jmap-client is currently not being maintained but we have plans to rewrite it next year. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Currently this library pulls
reqwest
as an HTTP client. This is typically a solid choice for applications, but not very flexible for a library, since consumers cannot use an HTTP client which fits their needs.Would you consider making the HTTP client generic, with bounds something like these1:
This allows using
hyper
clients. Users who needreqwest
can still use it, but users who need to control further details of the HTTP client can also do so. This also substantially reduces the dependency tree, sincereqwest
is a pretty "fat" dependency.Footnotes
This specific sample is actually copied from libdav's CalDavClient. ↩
Beta Was this translation helpful? Give feedback.
All reactions