Make mcmc_pairs() return a ggplot object instead of a bayesplot_group object (Fix #268) #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some differences that I think are notable are:
|
|
Hey @billdenney thank you for this and sorry for the slow reply! I'm caught up in a bunch of other stuff at the moment but hopefully I'll have time to give you some comments soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
mcmc_pairs()return a ggplot object instead of a bayesplot_group object (Fix #268).This is a DRAFT PR for review and comment!!! The reason that it is a draft is that it emits all sorts of warnings that would need to be fixed before merging, but I know that there are strong preferences about the graphical organization of the output of
mcmc_pairs(), and I wanted to provide this draft to allow for testing and review. For a final PR, I would ensure that warnings were not present (or that they were minimized as much as possible).I believe that I captured all the major functionality from the existing
mcmc_pairs()output, but there were some interactions around how divergent transitions, max tree depth hits, and hex plots that may be off.