Merge pull request #712 from stan-dev/fix/numpy-randomstate

Switch from np.random.RandomState to default_rng

Author: WardBrian

cmdstanpy/cmdstan_args.py

@@ -7,7 +7,7 @@
 from typing import Any, Dict, List, Mapping, Optional, Union
 
 import numpy as np
-from numpy.random import RandomState
+from numpy.random import default_rng
 
 from cmdstanpy import _TMPDIR
 from cmdstanpy.utils import (
@@ -868,8 +868,8 @@ def validate(self) -> None:
                 )
 
         if self.seed is None:
-            rng = RandomState()
-            self.seed = rng.randint(1, 99999 + 1)
+            rng = default_rng()
+            self.seed = rng.integers(low=1, high=99999, size=1).item()
         else:
             if not isinstance(self.seed, (int, list, np.integer)):
                 raise ValueError(

cmdstanpy/model.py

@@ -562,7 +562,7 @@ def optimize(
 
         :param seed: The seed for random number generator. Must be an integer
             between 0 and 2^32 - 1. If unspecified,
-            :class:`numpy.random.RandomState` is used to generate a seed.
+            :func:`numpy.random.default_rng` is used to generate a seed.
 
         :param inits:  Specifies how the sampler initializes parameter values.
             Initialization is either uniform random on a range centered on 0,
@@ -789,7 +789,7 @@ def sample(
 
         :param seed: The seed for random number generator. Must be an integer
             between 0 and 2^32 - 1. If unspecified,
-            :class:`numpy.random.RandomState`
+            :func:`numpy.random.default_rng`
             is used to generate a seed which will be used for all chains.
             When the same seed is used across all chains,
             the chain-id is used to advance the RNG to avoid dependent samples.
@@ -1231,7 +1231,7 @@ def generate_quantities(
 
         :param seed: The seed for random number generator. Must be an integer
             between 0 and 2^32 - 1. If unspecified,
-            :class:`numpy.random.RandomState`
+            :func:`numpy.random.default_rng`
             is used to generate a seed which will be used for all chains.
             *NOTE: Specifying the seed will guarantee the same result for
             multiple invocations of this method with the same inputs.  However
@@ -1432,7 +1432,7 @@ def variational(
 
         :param seed: The seed for random number generator. Must be an integer
             between 0 and 2^32 - 1. If unspecified,
-            :class:`numpy.random.RandomState`
+            :func:`numpy.random.default_rng`
             is used to generate a seed which will be used for all chains.
 
         :param inits:  Specifies how the sampler initializes parameter values.
@@ -1647,7 +1647,7 @@ def pathfinder(
 
         :param seed: The seed for random number generator. Must be an integer
             between 0 and 2^32 - 1. If unspecified,
-            :class:`numpy.random.RandomState` is used to generate a seed.
+            :func:`numpy.random.default_rng` is used to generate a seed.
 
         :param inits: Specifies how the algorithm initializes parameter values.
             Initialization is either uniform random on a range centered on 0,