fixing fixes

Author: mitzimorris

cmdstanpy/model.py

@@ -549,7 +549,7 @@ def compile(
                     get_logger().error('Stan program failed to compile:')
                     get_logger().warning(console)
                 elif len(warnings) > 0:
-                    get_logger().info(
+                    get_logger().warning(
                         'Stan compiler has produced %d warnings:',
                         len(warnings),
                     )

test/data/bad_syntax.stan

@@ -0,0 +1,12 @@
+data {
+  int<lower=0> N;
+  array[N] int<lower=0, upper=1> y;
+}
+parameters {
+  real<lower=0, upper=1> theta;
+}
+model {
+  theta ~ beta(1, 1)
+  for (n in 1:N)
+    y[n] ~ bernoulli(theta);
+}

test/data/bernoulli.stan

@@ -9,4 +9,3 @@ model {
   theta ~ beta(1, 1); // uniform prior on interval 0,1
   y ~ bernoulli(theta);
 }
-

test/data/bernoulli_include.stan

@@ -0,0 +1,15 @@
+functions {
+#include divide_real_by_two.stan
+}
+data {
+  int<lower=0> N;
+  int<lower=0,upper=1> y[N];
+}
+parameters {
+  real<lower=0,upper=1> theta;
+}
+model {
+  theta ~ beta(divide_real_by_two(2),1);
+  for (n in 1:N)
+    y[n] ~ bernoulli(theta);
+}

test/data/divide_real_by_two.stan

@@ -0,0 +1,3 @@
+real divide_real_by_two(real x){
+  return x / 2;
+}

test/data/external.stan

@@ -0,0 +1,7 @@
+functions {
+   real return_one();
+}
+
+generated quantities {
+   real one = return_one();
+}

test/data/format_me.stan

@@ -1,11 +1,10 @@
 generated quantities {
-  array[10, 10, 10, 10, 10] matrix[100, 100] a_very_long_name;
-  int x = 10;
-  int y;
-  if (1) {
+   array[10,10,10,10,10] matrix[100,100] a_very_long_name;
+   int x = (((10)));
+   int y;
+   if (1)
     y = 1;
-  } else {
-    y = 2;
-  }
+   else
+    y=2;
 }
 

test/data/format_me_deprecations.stan

@@ -1,6 +1,5 @@
-// pound-sign comment
+# pound-sign comment
 generated quantities {
-  int x;
-  x = 3;
+   int x;
+   x <- (((((3)))));
 }
-

test/test_model.py

@@ -22,13 +22,13 @@
 
 CODE = """data {
   int<lower=0> N;
-  int<lower=0,upper=1> y[N];
+  array[N] int<lower=0, upper=1> y;
 }
 parameters {
-  real<lower=0,upper=1> theta;
+  real<lower=0, upper=1> theta;
 }
 model {
-  theta ~ beta(1,1);  // uniform prior on interval 0,1
+  theta ~ beta(1, 1); // uniform prior on interval 0,1
   y ~ bernoulli(theta);
 }
 """
@@ -218,7 +218,6 @@ def test_compile_force(self):
         self.assertTrue(os.path.exists(model.exe_file))
 
         info_dict = model.exe_info()
-        print(f'info={info_dict}')
         self.assertEqual(info_dict['STAN_THREADS'].lower(), 'false')
 
         more_opts = {'STAN_THREADS': 'TRUE'}
@@ -228,7 +227,6 @@ def test_compile_force(self):
         self.assertTrue(os.path.exists(model.exe_file))
 
         info_dict2 = model.exe_info()
-        print(f'info2={info_dict2}')
         self.assertEqual(info_dict2['STAN_THREADS'].lower(), 'true')
 
         override_opts = {'STAN_NO_RANGE_CHECKS': 'TRUE'}
@@ -237,7 +235,6 @@ def test_compile_force(self):
             force=True, cpp_options=override_opts, override_options=True
         )
         info_dict3 = model.exe_info()
-        print(f'info3={info_dict3}')
         self.assertEqual(info_dict3['STAN_THREADS'].lower(), 'false')
         # cmdstan#1056
         # self.assertEqual(info_dict3['STAN_NO_RANGE_CHECKS'].lower(), 'true')