Merge pull request #569 from stan-dev/fix/568-temp-subdir

Make a subdirectory of the temporary directory per-runset

Author: WardBrian

cmdstanpy/stanfit/runset.py

@@ -6,6 +6,7 @@
 import os
 import re
 import shutil
+import tempfile
 from datetime import datetime
 from time import time
 from typing import List, Optional
@@ -50,7 +51,10 @@ def __init__(
         if args.output_dir is not None:
             self._output_dir = args.output_dir
         else:
-            self._output_dir = _TMPDIR
+            # make a per-run subdirectory of our master temp directory
+            self._output_dir = tempfile.mkdtemp(
+                prefix=args.model_name, dir=_TMPDIR
+            )
 
         # output files prefix: ``<model_name>-<YYYYMMDDHHMM>_<chain_id>``
         self._base_outfile = (

test/data/normal-rng.stan

@@ -0,0 +1,7 @@
+transformed data{
+  real x_;
+  x_ = std_normal_rng();
+}
+generated quantities{
+  real x = x_;
+}

test/test_sample.py

@@ -1769,6 +1769,20 @@ def test_single_row_csv(self):
                 self.assertEqual(int(z_as_ndarray[0, i, j]), i + 1)
                 self.assertEqual(int(z_as_xr.z.data[0, 0, i, j]), i + 1)
 
+    def test_overlapping_names(self):
+        stan = os.path.join(DATAFILES_PATH, 'normal-rng.stan')
+
+        mod = CmdStanModel(stan_file=stan)
+        # %Y to force same names
+        fits = [
+            mod.sample(data={}, time_fmt="%Y", iter_sampling=1, iter_warmup=1)
+            for i in range(10)
+        ]
+
+        self.assertEqual(
+            len(np.unique([fit.stan_variables()["x"][0] for fit in fits])), 10
+        )
+
     def test_complex_output(self):
         stan = os.path.join(DATAFILES_PATH, 'complex_var.stan')
         model = CmdStanModel(stan_file=stan)