fix models

Author: rok-cesnovar

knitr/bandits/bernoulli-ab.stan

@@ -11,6 +11,10 @@ model {
 }
 generated quantities {
   int<lower = 0, upper = 1> is_best[K];
-  for (k in 1:K)
-    is_best[k] = (theta[k] >= best_prob);
+  {
+    real best_prob = max(theta);
+    for (k in 1:K) {
+      is_best[k] = (theta[k] >= best_prob);
+    }    
+  }  
 }

knitr/car-iar-poisson/pois_icar.stan

@@ -28,7 +28,7 @@ model {
   beta0 ~ normal(0.0, 1.0);
   beta1 ~ normal(0.0, 1.0);
   sigma ~ normal(0.0, 1.0);
-  phi ~ icar_normal_lpdf(N, node1, node2);
+  phi ~ icar_normal(N, node1, node2);
   // soft sum-to-zero constraint on phi
   // more efficient than mean(phi) ~ normal(0, 0.001)
   sum(phi) ~ normal(0, 0.001 * N);

knitr/neural-nets/nn.stan

@@ -39,7 +39,8 @@ model {
   to_vector(beta) ~ normal(0, 2);
 
   // likelihood
-  y[n] ~ categorical_logit(v[ , n]);
+  for (n in 1:N)
+    y[n] ~ categorical_logit(v[ , n]);
 }