Skip to content

Commit 3249478

Browse files
committed
Compare converted
1 parent 3e9cfe4 commit 3249478

File tree

2 files changed

+34
-16
lines changed

2 files changed

+34
-16
lines changed

tests/testthat/_snaps/compare.md

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,31 @@
2626

2727
# compare returns expected result (2 models)
2828

29+
Code
30+
comp1
31+
Output
32+
elpd_diff se
33+
0.0 0.0
34+
35+
---
36+
2937
Code
3038
comp2
3139
Output
32-
<deprecatedWarning in loo::compare(w1, w2): 'loo::compare' is deprecated.
33-
Use 'loo_compare' instead.
34-
See help("Deprecated")>
40+
elpd_diff se
41+
-4.1 0.1
42+
43+
# compare returns expected result (3 models)
44+
45+
WAoAAAACAAQFAAACAwAAAAMOAAAAGAAAAAAAAAAAwBA6U1+cRe7AMA3KkbYEGAAAAAAAAAAA
46+
P7ZqR7QvEwE/y6/t4TTtXsBU4fDdyUJYwFXllhPDBrnAWOVjgjbDYkARCD2zEXBfQBEalRIN
47+
2T9AEPIF3GigE0AKKMBh1blTQCZnlesA0IpAQcjYUhrdCj/x/WXscvNeP/GbYJxtZ8c/8YDQ
48+
kmfJX0Bk4fDdyUJYQGXllhPDBrlAaOVjgjbDYkAhCD2zEXBfQCEalRIN2T9AIPIF3GigEwAA
49+
BAIAAAABAAQACQAAAANkaW0AAAANAAAAAgAAAAMAAAAIAAAEAgAAAAEABAAJAAAACGRpbW5h
50+
bWVzAAAAEwAAAAIAAAAQAAAAAwAEAAkAAAACdzEABAAJAAAAAncyAAQACQAAAAJ3MwAAABAA
51+
AAAIAAQACQAAAAllbHBkX2RpZmYABAAJAAAAB3NlX2RpZmYABAAJAAAACWVscGRfd2FpYwAE
52+
AAkAAAAMc2VfZWxwZF93YWljAAQACQAAAAZwX3dhaWMABAAJAAAACXNlX3Bfd2FpYwAEAAkA
53+
AAAEd2FpYwAEAAkAAAAHc2Vfd2FpYwAABAIAAAABAAQACQAAAAVjbGFzcwAAABAAAAAEAAQA
54+
CQAAAAtjb21wYXJlLmxvbwAEAAkAAAAGbWF0cml4AAQACQAAAAVhcnJheQAEAAkAAAAPb2xk
55+
X2NvbXBhcmUubG9vAAAA/g==
3556

tests/testthat/test_compare.R

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ library(loo)
22
set.seed(123)
33
SW <- suppressWarnings
44

5-
context("compare models")
6-
75
LLarr <- example_loglik_array()
86
LLarr2 <- array(rnorm(prod(dim(LLarr)), c(LLarr), 0.5), dim = dim(LLarr))
97
LLarr3 <- array(rnorm(prod(dim(LLarr)), c(LLarr), 1), dim = dim(LLarr))
@@ -62,8 +60,8 @@ test_that("loo_compare returns expected results (2 models)", {
6260
expect_equal(colnames(comp1), comp_colnames)
6361
expect_equal(rownames(comp1), c("model1", "model2"))
6462
expect_output(print(comp1), "elpd_diff")
65-
expect_equivalent(comp1[1:2,1], c(0, 0))
66-
expect_equivalent(comp1[1:2,2], c(0, 0))
63+
expect_equal(comp1[1:2,1], c(0, 0), ignore_attr = TRUE)
64+
expect_equal(comp1[1:2,2], c(0, 0), ignore_attr = TRUE)
6765

6866
comp2 <- loo_compare(w1, w2)
6967
expect_s3_class(comp2, "compare.loo")
@@ -90,7 +88,7 @@ test_that("loo_compare returns expected result (3 models)", {
9088

9189
# specifying objects via '...' gives equivalent results (equal
9290
# except rownames) to using 'x' argument
93-
expect_equivalent(comp1, loo_compare(x = list(w1, w2, w3)))
91+
expect_equal(comp1, loo_compare(x = list(w1, w2, w3)), ignore_attr = TRUE)
9492
})
9593

9694
# Tests for deprecated compare() ------------------------------------------
@@ -101,24 +99,23 @@ test_that("compare throws deprecation warnings", {
10199
})
102100

103101
test_that("compare returns expected result (2 models)", {
104-
comp1 <- expect_warning(loo::compare(w1, w1), "Deprecated")
102+
expect_warning(comp1 <- loo::compare(w1, w1), "Deprecated")
105103
expect_snapshot(comp1)
106-
# expect_output(print(comp1), "elpd_diff")
107104
expect_equal(comp1[1:2], c(elpd_diff = 0, se = 0))
108105

109-
comp2 <- expect_warning(loo::compare(w1, w2), "Deprecated")
106+
expect_warning(comp2 <- loo::compare(w1, w2), "Deprecated")
110107
expect_snapshot(comp2)
111108
expect_named(comp2, c("elpd_diff", "se"))
112109
expect_s3_class(comp2, "compare.loo")
113110

114111
# specifying objects via ... and via arg x gives equal results
115-
comp_via_list <- expect_warning(loo::compare(x = list(w1, w2)), "Deprecated")
112+
expect_warning(comp_via_list <- loo::compare(x = list(w1, w2)), "Deprecated")
116113
expect_equal(comp2, comp_via_list)
117114
})
118115

119116
test_that("compare returns expected result (3 models)", {
120117
w3 <- SW(waic(LLarr3))
121-
comp1 <- expect_warning(loo::compare(w1, w2, w3), "Deprecated")
118+
expect_warning(comp1 <- loo::compare(w1, w2, w3), "Deprecated")
122119

123120
expect_equal(
124121
colnames(comp1),
@@ -130,12 +127,12 @@ test_that("compare returns expected result (3 models)", {
130127
expect_equal(comp1[1,1], 0)
131128
expect_s3_class(comp1, "compare.loo")
132129
expect_s3_class(comp1, "matrix")
133-
expect_snapshot_value(comp1)
130+
expect_snapshot_value(comp1, style = "serialize")
134131

135132
# specifying objects via '...' gives equivalent results (equal
136133
# except rownames) to using 'x' argument
137-
comp_via_list <- expect_warning(loo::compare(x = list(w1, w2, w3)), "Deprecated")
138-
expect_equivalent(comp1, comp_via_list)
134+
expect_warning(comp_via_list <- loo::compare(x = list(w1, w2, w3)), "Deprecated")
135+
expect_equal(comp1, comp_via_list, ignore_attr = TRUE)
139136
})
140137

141138
test_that("compare throws appropriate errors", {

0 commit comments

Comments
 (0)