oops, fix khat comparison

avehtari · avehtari · commit b0ebac7540d8 · 2025-10-17T20:38:40.000+03:00
diff --git a/R/loo_compare.R b/R/loo_compare.R
@@ -140,7 +140,7 @@ loo_compare.default <- function(x, ...) {
     # Vehtari et al., 2024)
     khat_diff <- rep(NA, length(elpd_diff))
     khat_diff[elpd_diff!=0] <- apply(diffs[,elpd_diff!=0, drop = FALSE], 2, \(x) posterior::pareto_khat(x, tail="both"))
-    diag_pnorm[khat_diff > ps_khat_threshold(N)] <- paste0("khat_diff > 0.5")
+    diag_pnorm[khat_diff > 0.5] <- paste0("khat_diff > 0.5")
   }
   rownames(comp) <- rnms
   comp <- cbind(data.frame(elpd_diff = elpd_diff, se_diff = se_diff,

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ loo_compare.default <- function(x, ...) {`
`140`	`140`	`# Vehtari et al., 2024)`
`141`	`141`	`khat_diff <- rep(NA, length(elpd_diff))`
`142`	`142`	`khat_diff[elpd_diff!=0] <- apply(diffs[,elpd_diff!=0, drop = FALSE], 2, \(x) posterior::pareto_khat(x, tail="both"))`
`143`		`- diag_pnorm[khat_diff > ps_khat_threshold(N)] <- paste0("khat_diff > 0.5")`
	`143`	`+ diag_pnorm[khat_diff > 0.5] <- paste0("khat_diff > 0.5")`
`144`	`144`	`}`
`145`	`145`	`rownames(comp) <- rnms`
`146`	`146`	`comp <- cbind(data.frame(elpd_diff = elpd_diff, se_diff = se_diff,`