Merge pull request #3070 from stan-dev/fix_zero_sized_parameters

Fix zero sized parameters in transform_inits

Author: rok-cesnovar

src/stan/services/sample/standalone_gqs.hpp

@@ -42,11 +42,18 @@ void get_model_parameters(const Model &model,
       param_names.emplace_back(cur_name);
     }
   }
+  std::vector<std::string> all_param_names;
+  model.get_param_names(all_param_names);
   size_t num_params = param_names.size();
   std::vector<std::vector<size_t>> dimss;
   model.get_dims(dimss);
-  for (size_t i = 0; i < num_params; ++i) {
-    param_dimss.emplace_back(dimss[i]);
+  for (size_t i = 0; i < param_names.size(); i++) {
+    for (size_t j = i; j < all_param_names.size(); ++j) {
+      if (param_names[i].compare(all_param_names[j]) == 0) {
+        param_dimss.emplace_back(dimss[j]);
+        break;
+      }
+    }
   }
 }
 

src/test/test-models/good/services/gq_test_zero_sized.stan

@@ -0,0 +1,17 @@
+parameters {
+  real a;
+  vector[0] b;
+  vector[5] c;
+  array[0] vector[2] d;
+  row_vector[6] e;
+  array[2] vector[0] f;
+  array[2] vector[3] g;
+}
+model {
+  a ~ std_normal();
+  c ~ std_normal();
+  e ~ std_normal();
+  g[1] ~ std_normal();
+  g[2] ~ std_normal();
+}
+

src/test/unit/services/sample/standalone_gqs_zero_sized_test.cpp

@@ -0,0 +1,49 @@
+#include <stan/services/error_codes.hpp>
+#include <stan/services/sample/standalone_gqs.hpp>
+#include <stan/callbacks/stream_writer.hpp>
+#include <stan/callbacks/stream_logger.hpp>
+#include <stan/io/empty_var_context.hpp>
+#include <stan/io/stan_csv_reader.hpp>
+#include <test/test-models/good/services/gq_test_zero_sized.hpp>
+#include <test/unit/services/instrumented_callbacks.hpp>
+#include <test/unit/util.hpp>
+#include <Eigen/Dense>
+#include <gtest/gtest.h>
+#include <iostream>
+#include <string>
+#include <vector>
+
+class ServicesStandaloneGQ2 : public ::testing::Test {
+ public:
+  ServicesStandaloneGQ2()
+      : logger(logger_ss, logger_ss, logger_ss, logger_ss, logger_ss) {}
+
+  void SetUp() {
+    stan::io::empty_var_context context;
+    model = new stan_model(context);
+  }
+
+  void TearDown() { delete model; }
+
+  stan::test::unit::instrumented_interrupt interrupt;
+  std::stringstream logger_ss;
+  stan::callbacks::stream_logger logger;
+  stan_model *model;
+};
+
+TEST_F(ServicesStandaloneGQ2, zero_sized_params_get_model_parameters) {
+  std::vector<std::string> param_names;
+  std::vector<std::vector<size_t>> param_dimss;
+  stan::services::get_model_parameters(*model, param_names, param_dimss);
+
+  EXPECT_EQ(param_names.size(), 4);
+  EXPECT_EQ(param_dimss.size(), 4);
+  EXPECT_EQ(param_dimss[0].size(), 0);
+  EXPECT_EQ(param_dimss[1].size(), 1);
+  EXPECT_EQ(param_dimss[1][0], 5);
+  EXPECT_EQ(param_dimss[2].size(), 1);
+  EXPECT_EQ(param_dimss[2][0], 6);
+  EXPECT_EQ(param_dimss[3].size(), 2);
+  EXPECT_EQ(param_dimss[3][0], 2);
+  EXPECT_EQ(param_dimss[3][1], 3);
+}