More tests

Author: WardBrian

src/stan_math_backend/Cpp_Json.ml

@@ -65,10 +65,10 @@ let%expect_test "outvar to json pretty" =
   unslash the ones near a plus*)
 let replace_cpp_expr s =
   s
-  |> String.substr_replace_all ~pattern:{|"|} ~with_:{|\"|}
+  |> String.substr_replace_all ~pattern:"\\n" ~with_:""
+  |> Cpp_str.escaped
   |> String.substr_replace_all ~pattern:{|\"+|} ~with_:{|" +|}
   |> String.substr_replace_all ~pattern:{|+\"|} ~with_:{|+ "|}
-  |> String.substr_replace_all ~pattern:"\\n" ~with_:""
 
 let wrap_in_quotes s = "\"" ^ s ^ "\""
 
@@ -79,9 +79,12 @@ let out_var_interpolated_json_str vars =
 let%expect_test "outvar to json" =
   let var x = {Expr.Fixed.pattern= Var x; meta= Expr.Typed.Meta.empty} in
   [ ( "var_one"
-    , SizedType.SArray (SVector (AoS, var "N"), var "K")
+    , SizedType.SArray
+        ( SVector
+            (AoS, Expr.Helpers.binop (var "N") Operator.Minus Expr.Helpers.one)
+        , var "K" )
     , Program.Parameters ) ]
   |> out_var_interpolated_json_str |> print_endline;
   [%expect
     {|
-    "[{\"name\":\"var_one\",\"type\":{\"name\":\"array\",\"length\":" + std::to_string(K) + ",\"element_type\":{\"name\":\"vector\",\"length\":" + std::to_string(N) + "}},\"block\":\"parameters\"}]" |}]
+    "[{\"name\":\"var_one\",\"type\":{\"name\":\"array\",\"length\":" + std::to_string(K) + ",\"element_type\":{\"name\":\"vector\",\"length\":" + std::to_string((N -1)) + "}},\"block\":\"parameters\"}]" |}]

test/integration/bad/stanc.expected

@@ -2969,6 +2969,19 @@ Semantic error in 'typo.stan', line 2, column 17 to column 34:
 
 A returning function was expected but an undeclared identifier 'to_vetor' was supplied.
 A similar known identifier is 'to_vector'
+[exit 1]
+  $ ../../../../install/default/bin/stanc unicode-without-flag.stan
+Syntax error in 'unicode-without-flag.stan', line 4, column 24, lexing error:
+   -------------------------------------------------
+     2:    int<lower=0> J; // number of schools
+     3:    array[J] real y; // estimated treatment effect (school j)
+     4:    array[J] real<lower=0> σ; // std err of effect estimate (school j)
+                                  ^
+     5:  }
+     6:  parameters {
+   -------------------------------------------------
+
+Unicode identifiers are not supported without the (experimental) allow-unicode flag
 [exit 1]
   $ ../../../../install/default/bin/stanc validate_add_expression_dimss_bad.stan
 Semantic error in 'validate_add_expression_dimss_bad.stan', line 4, column 6 to column 13:

test/integration/bad/unicode-without-flag.stan

@@ -0,0 +1,14 @@
+data {
+  int<lower=0> J; // number of schools
+  array[J] real y; // estimated treatment effect (school j)
+  array[J] real<lower=0> σ; // std err of effect estimate (school j)
+}
+parameters {
+  real μ;
+  array[J] real θ;
+  real<lower=0> τ;
+}
+model {
+  θ ~ normal(μ, τ);
+  y ~ normal(θ, σ);
+}

test/integration/bad/unicode/invalid-utf8-4.stan

@@ -0,0 +1,3 @@
+data {
+  int ñ߿;
+}

test/integration/bad/unicode/invalid-utf8-5.stan

@@ -0,0 +1,3 @@
+data {
+  int _ñ;
+}

test/integration/bad/unicode/non-utf-8/stanc.expected

@@ -7,7 +7,10 @@
  (action
   (with-stdout-to
    %{targets}
-   (run %{bin:run_bin_on_args} "%{bin:stanc} --print-cpp" %{stanfiles}))))
+   (run
+    %{bin:run_bin_on_args}
+    "%{bin:stanc} --allow-unicode --print-cpp"
+    %{stanfiles}))))
 
 (rule
  (alias runtest)

test/integration/bad/unicode/stanc.expected

@@ -0,0 +1,22 @@
+data {
+  int<lower=0> J; // number of schools
+  array[J] real y; // estimated treatment effect (school j)
+  array[J] real<lower=0> σ; // std err of effect estimate (school j)
+}
+parameters {
+  real μ;
+  array[J] real θ;
+  real<lower=0> τ;
+}
+model {
+  θ ~ normal(μ, τ);
+  y ~ normal(θ, σ);
+
+}
+
+
+generated quantities {
+  int ñabc;
+  ñabc = 1 + to_int(θ[J-1]);
+  print(ñabc);
+}