Skip to content

Commit 54ddd37

Browse files
authored
feat: Improves Add Tag dropdown UI (#2936)
* feat: Improves Add Tag dropdown UI * chore: change string color * chore: render title prefix conditionally * chore: cast to boolean
1 parent 51025de commit 54ddd37

File tree

1 file changed

+31
-23
lines changed

1 file changed

+31
-23
lines changed

packages/web/src/javascripts/Components/NotesOptions/AddTagOption.tsx

Lines changed: 31 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -78,30 +78,38 @@ const AddTagOption: FunctionComponent<Props> = ({
7878
overrideZIndex="z-modal"
7979
>
8080
<Menu a11yLabel="Tag selection menu" className="!px-0">
81-
{navigationController.tags.map((tag) => (
82-
<MenuItem
83-
key={tag.uuid}
84-
onClick={() => {
85-
isTagLinkedToSelectedItems(tag) ? unlinkTagFromSelectedItems(tag) : linkTagToSelectedItems(tag)
86-
}}
87-
>
88-
{tag.iconString && (
89-
<Icon
90-
type={tag.iconString as IconType}
91-
size={'custom'}
92-
className={'ml-0.5 mr-1.5 h-7 w-7 text-2xl text-neutral lg:h-6 lg:w-6 lg:text-lg'}
93-
/>
94-
)}
95-
<span
96-
className={classNames(
97-
'overflow-hidden overflow-ellipsis whitespace-nowrap',
98-
isTagLinkedToSelectedItems(tag) ? 'font-bold' : '',
99-
)}
81+
{navigationController.tags.map((tag) => {
82+
const tagTitlePrefix = getTitleForLinkedTag(tag, application)?.titlePrefix
83+
return (
84+
<MenuItem
85+
key={tag.uuid}
86+
onClick={() => {
87+
isTagLinkedToSelectedItems(tag) ? unlinkTagFromSelectedItems(tag) : linkTagToSelectedItems(tag)
88+
}}
10089
>
101-
{getTitleForLinkedTag(tag, application)?.longTitle}
102-
</span>
103-
</MenuItem>
104-
))}
90+
{tag.iconString && (
91+
<Icon
92+
type={tag.iconString as IconType}
93+
size={'custom'}
94+
className={'ml-0.5 mr-1.5 h-7 w-7 text-2xl text-neutral lg:h-6 lg:w-6 lg:text-lg'}
95+
/>
96+
)}
97+
<div>
98+
{!!tagTitlePrefix && (
99+
<p className="overflow-hidden overflow-ellipsis whitespace-nowrap text-neutral">{tagTitlePrefix}</p>
100+
)}
101+
<p
102+
className={classNames(
103+
'overflow-hidden overflow-ellipsis whitespace-nowrap',
104+
isTagLinkedToSelectedItems(tag) ? 'font-bold' : '',
105+
)}
106+
>
107+
{tag.title}
108+
</p>
109+
</div>
110+
</MenuItem>
111+
)
112+
})}
105113
</Menu>
106114
</Popover>
107115
</div>

0 commit comments

Comments
 (0)