Skip to content

Commit ffebb82

Browse files
committed
Revert "Prevent trivial unsat in BMC-SP engine due to false simple path constraint"
This reverts commit 1369e9a.
1 parent 3695192 commit ffebb82

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

engines/kinduction.cpp

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -293,9 +293,7 @@ Term KInduction::simple_path_constraint(int i, int j)
293293
disj = solver_->make_term(PrimOp::Or, disj, neq);
294294
}
295295
// add selector term
296-
if (disj != false_) {
297-
disj = solver_->make_term(PrimOp::Or, disj, sel_simple_path_terms_);
298-
}
296+
disj = solver_->make_term(PrimOp::Or, disj, sel_simple_path_terms_);
299297

300298
return disj;
301299
}
@@ -312,11 +310,9 @@ bool KInduction::check_simple_path_eager(int i)
312310
// solver call below for inductive case check
313311
for (int j = 0; (!no_simp_path_check && j < i); j++) {
314312
Term constraint = simple_path_constraint(j, i);
315-
if (constraint != false_) {
316-
kind_log_msg(
317-
3, " ", "adding simple path clause for pair 'j,i' = {},{}", j, i);
318-
solver_->assert_formula(constraint);
319-
}
313+
kind_log_msg(
314+
3, " ", "adding simple path clause for pair 'j,i' = {},{}", j, i);
315+
solver_->assert_formula(constraint);
320316
}
321317

322318
// Note: the solver call here is actually not necessary since we add
@@ -372,7 +368,7 @@ bool KInduction::check_simple_path_lazy(int i)
372368
Term constraint = simple_path_constraint(j, l);
373369
kind_log_msg(
374370
3, " ", "checking constraint for pair j,l = {} , {}", j, l);
375-
if (constraint != false_ && solver_->get_value(constraint) == false_) {
371+
if (solver_->get_value(constraint) == false_) {
376372
kind_log_msg(
377373
3, " ", "adding constraint for pair j,l = {} , {}", j, l);
378374
added_to_simple_path = true;

0 commit comments

Comments
 (0)