Replace deprecated newInstance() method

manning · manning · commit ea0b5a962888 · 2025-11-08T13:47:33.000-08:00
diff --git a/src/edu/stanford/nlp/dcoref/SieveCoreferenceSystem.java b/src/edu/stanford/nlp/dcoref/SieveCoreferenceSystem.java
@@ -371,7 +371,7 @@ public static String initializeAndRunCoref(Properties props) throws Exception {
           }
           mentionFinder = (CorefMentionFinder) Class.forName(mentionFinderClass).getConstructor(Properties.class).newInstance(mentionFinderProps);
         } else {
-          mentionFinder = (CorefMentionFinder) Class.forName(mentionFinderClass).newInstance();
+          mentionFinder = (CorefMentionFinder) Class.forName(mentionFinderClass).getDeclaredConstructor().newInstance();
         }
         mentionExtractor.setMentionFinder(mentionFinder);
       }
diff --git a/src/edu/stanford/nlp/ie/crf/CRFClassifier.java b/src/edu/stanford/nlp/ie/crf/CRFClassifier.java
@@ -1224,7 +1224,7 @@ public List<IN> classifyGibbs(List<IN> document, Triple<int[][][], int[], double
 
     CRFCliqueTree<? extends CharSequence> cliqueTree = getCliqueTree(documentDataAndLabels);
 
-    PriorModelFactory<IN> pmf = (PriorModelFactory<IN>) Class.forName(flags.priorModelFactory).newInstance();
+    PriorModelFactory<IN> pmf = (PriorModelFactory<IN>) Class.forName(flags.priorModelFactory).getDeclaredConstructor().newInstance();
     ListeningSequenceModel prior = pmf.getInstance(flags.backgroundSymbol, classIndex, tagIndex, newDocument, entityMatrices, flags);
 
     if ( ! flags.useUniformPrior) {
@@ -2235,7 +2235,7 @@ protected void loadTextClassifier(BufferedReader br) throws Exception {
     }
     featureFactories = Generics.newArrayList();
     for (int ff = 1; ff < featureFactoryName.length - 1; ++ff) {
-      FeatureFactory<IN> featureFactory = (FeatureFactory<IN>) Class.forName(featureFactoryName[1]).newInstance();
+      FeatureFactory<IN> featureFactory = (FeatureFactory<IN>) Class.forName(featureFactoryName[1]).getDeclaredConstructor().newInstance();
       featureFactory.init(flags);
       featureFactories.add(featureFactory);
     }
diff --git a/src/edu/stanford/nlp/ling/AnnotationLookup.java b/src/edu/stanford/nlp/ling/AnnotationLookup.java
@@ -112,7 +112,7 @@ <T> KeyLookup(Class<? extends CoreAnnotation<T>> coreKey, String oldKey) {
     /**
      * This constructor allows us to use reflection for loading old class keys.
      * This is useful because we can then create distributions that do not have
-     * all of the classes required for all the old keys (such as trees package classes).
+     * all the classes required for all the old keys (such as trees package classes).
      */
     @SuppressWarnings("unused")
     KeyLookup(String className, String oldKey) {
@@ -155,16 +155,15 @@ public static Class<? extends CoreAnnotation<?>> toCoreKey(String stringKey) {
    * @param key The annotation key (non-null)
    * @return The type of the value of that key (non-null)
    */
-  @SuppressWarnings("unchecked")
-  public static Class<?> getValueType(Class<? extends CoreAnnotation<?>> key) {
-    Class type = valueCache.get(key);
+   public static Class<?> getValueType(Class<? extends CoreAnnotation<?>> key) {
+    Class<?> type = valueCache.get(key);
     if (type == null) {
       try {
-        type = key.newInstance().getType();
-      } catch (Exception e) {
+        type = key.getDeclaredConstructor().newInstance().getType();
+      } catch (ReflectiveOperationException e) {
         throw new UnsupportedOperationException("Unexpected failure to instantiate - is your key class fancy?", e);
       }
-      valueCache.put((Class)key, type);
+      valueCache.put(key, type);
     }
     return type;
   }
diff --git a/src/edu/stanford/nlp/ling/tokensregex/types/Expressions.java b/src/edu/stanford/nlp/ling/tokensregex/types/Expressions.java
@@ -1261,14 +1261,14 @@ private static Value attemptTypeConversion(CompositeValue cv, Env env, Object...
             // If so, then try to instantiate a new instance of the class
             if (TYPE_CLASS.equals(typeValue.getType())) {
               // Variable maps to a java class
-              Class c = (Class) typeValue.get();
+              Class<?> c = (Class<?>) typeValue.get();
               try {
-                Object obj = c.newInstance();
+                Object obj = c.getDeclaredConstructor().newInstance();
                 // for any field other than the "type", set the value of the field
                 //   of the created object to the specified value
                 for (String s:cv.value.keySet()) {
                   if (!"type".equals(s)) {
-                    Value v = cv.value.get(s).evaluate(env, args);
+                    Value<?> v = cv.value.get(s).evaluate(env, args);
                     try {
                       Field f = c.getField(s);
                       Object objVal =  toCompatibleObject(f, v.get());
@@ -1281,14 +1281,14 @@ private static Value attemptTypeConversion(CompositeValue cv, Env env, Object...
                   }
                 }
                 return new PrimitiveValue<>(typeName, obj);
-              } catch (InstantiationException | IllegalAccessException ex) {
+              } catch (ReflectiveOperationException ex) {
                 throw new RuntimeException("Cannot instantiate " + c, ex);
               }
             } else if (typeValue.get() != null){
               // When evaluated, variable does not explicitly map to "CLASS"
               // See if we can convert this CompositeValue into appropriate object
               // by calling "create(CompositeValue cv)"
-              Class c = typeValue.get().getClass();
+              Class<?> c = typeValue.get().getClass();
               try {
                 Method m = c.getMethod("create", CompositeValue.class);
                 CompositeValue evaluatedCv = cv.evaluateNoTypeConversion(env, args);
diff --git a/src/edu/stanford/nlp/parser/lexparser/ChineseTreebankParserParams.java b/src/edu/stanford/nlp/parser/lexparser/ChineseTreebankParserParams.java
@@ -1153,7 +1153,7 @@ public int setOptionFlag(String[] args, int i) {
       i += 2;
     } else if (args[i].equalsIgnoreCase("-headFinder") && (i + 1 < args.length)) {
       try {
-        headFinder = (HeadFinder) Class.forName(args[i + 1]).newInstance();
+        headFinder = (HeadFinder) Class.forName(args[i + 1]).getDeclaredConstructor().newInstance();
       } catch (Exception e) {
         log.info(e);
         log.info(this.getClass().getName() + ": Could not load head finder " + args[i + 1]);
diff --git a/src/edu/stanford/nlp/parser/lexparser/FactoredParser.java b/src/edu/stanford/nlp/parser/lexparser/FactoredParser.java
@@ -118,16 +118,13 @@ public static void main(String[] args) {
         i += 2;
       } else if (args[i].equalsIgnoreCase("-tLPP") && (i + 1 < args.length)) {
         try {
-          op.tlpParams = (TreebankLangParserParams) Class.forName(args[i + 1]).newInstance();
+          op.tlpParams = (TreebankLangParserParams) Class.forName(args[i + 1]).getDeclaredConstructor().newInstance();
         } catch (ClassNotFoundException e) {
           log.info("Class not found: " + args[i + 1]);
           throw new RuntimeException(e);
-        } catch (InstantiationException e) {
+        } catch (ReflectiveOperationException e) {
           log.info("Couldn't instantiate: " + args[i + 1] + ": " + e.toString());
           throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-          log.info("illegal access" + e);
-          throw new RuntimeException(e);
         }
         i += 2;
       } else if (args[i].equals("-encoding")) {
diff --git a/src/edu/stanford/nlp/parser/lexparser/FrenchTreebankParserParams.java b/src/edu/stanford/nlp/parser/lexparser/FrenchTreebankParserParams.java
@@ -663,7 +663,7 @@ public int setOptionFlag(String[] args, int i) {
 
     } else if (args[i].equalsIgnoreCase("-headFinder") && (i + 1 < args.length)) {
       try {
-        HeadFinder hf = (HeadFinder) Class.forName(args[i + 1]).newInstance();
+        HeadFinder hf = (HeadFinder) Class.forName(args[i + 1]).getDeclaredConstructor().newInstance();
         setHeadFinder(hf);
         optionsString.append("HeadFinder: " + args[i + 1] + "\n");
 
diff --git a/src/edu/stanford/nlp/parser/lexparser/SpanishTreebankParserParams.java b/src/edu/stanford/nlp/parser/lexparser/SpanishTreebankParserParams.java
@@ -297,11 +297,11 @@ public MemoryTreebank memoryTreebank() {
   public int setOptionFlag(String[] args, int i) {
     if (args[i].equalsIgnoreCase("-headFinder") && (i + 1 < args.length)) {
       try {
-        HeadFinder hf = (HeadFinder) Class.forName(args[i + 1]).newInstance();
+        HeadFinder hf = (HeadFinder) Class.forName(args[i + 1]).getDeclaredConstructor().newInstance();
         setHeadFinder(hf);
 
         optionsString.append("HeadFinder: " + args[i + 1] + "\n");
-      } catch (ReflectiveOperationException|SecurityException e) {
+      } catch (ReflectiveOperationException | SecurityException e) {
         log.info(e);
         log.info(this.getClass().getName() + ": Could not load head finder " + args[i + 1]);
       }
diff --git a/src/edu/stanford/nlp/parser/lexparser/TreeBinarizer.java b/src/edu/stanford/nlp/parser/lexparser/TreeBinarizer.java
@@ -662,15 +662,15 @@ public static void main(String[] args) {
     while (i < args.length && args[i].startsWith("-")) {
       if (args[i].equalsIgnoreCase("-tlp") && i + 1 < args.length) {
 	try {
-	  tlp = (TreebankLanguagePack) Class.forName(args[i+1]).newInstance();
+	  tlp = (TreebankLanguagePack) Class.forName(args[i+1]).getDeclaredConstructor().newInstance();
 	} catch (Exception e) {
 	  log.info("Couldn't instantiate: " + args[i+1]);
           throw new RuntimeException(e);
 	}
 	i++;
       } else if (args[i].equalsIgnoreCase("-tlpp") && i + 1 < args.length) {
 	try {
-	  tlpp = (TreebankLangParserParams) Class.forName(args[i+1]).newInstance();
+	  tlpp = (TreebankLangParserParams) Class.forName(args[i+1]).getDeclaredConstructor().newInstance();
 	} catch (Exception e) {
 	  log.info("Couldn't instantiate: " + args[i+1]);
           throw new RuntimeException(e);
diff --git a/src/edu/stanford/nlp/sequences/ColumnTabDocumentReaderWriter.java b/src/edu/stanford/nlp/sequences/ColumnTabDocumentReaderWriter.java
@@ -74,7 +74,7 @@ public void init(SeqClassifierFlags flags) {
 
     if (flags.tokenFactory != null) {
       try {
-        this.tokenFactory = (CoreTokenFactory<IN>) Class.forName(flags.tokenFactory).newInstance();
+        this.tokenFactory = (CoreTokenFactory<IN>) Class.forName(flags.tokenFactory).getDeclaredConstructor().newInstance();
       } catch (Exception e) {
         throw new RuntimeException(e);
       }
@@ -102,7 +102,7 @@ public void init(String name, Properties props) {
     String tokenFactoryClassName =  props.getProperty(prefix + "tokenFactory");
     if (tokenFactoryClassName != null) {
       try {
-        this.tokenFactory = (CoreTokenFactory<IN>) Class.forName(tokenFactoryClassName).newInstance();
+        this.tokenFactory = (CoreTokenFactory<IN>) Class.forName(tokenFactoryClassName).getDeclaredConstructor().newInstance();
       } catch (Exception e) {
         throw new RuntimeException(e);
       }
diff --git a/src/edu/stanford/nlp/trees/GrammaticalStructureConversionUtils.java b/src/edu/stanford/nlp/trees/GrammaticalStructureConversionUtils.java
@@ -232,8 +232,8 @@ private static DependencyReader loadAlternateDependencyReader(String altDepReade
     DependencyReader altDepReader; // initialized below
     if (depReaderArgs.length == 0) {
       try {
-        altDepReader = altDepReaderClass.newInstance();
-      } catch (InstantiationException e) {
+        altDepReader = altDepReaderClass.getDeclaredConstructor().newInstance();
+      } catch (NoSuchMethodException | InstantiationException | InvocationTargetException e) {
         throw new RuntimeException(e);
       } catch (IllegalAccessException e) {
         log.info("No argument constructor to " + altDepReaderName + " is not public");
@@ -288,7 +288,7 @@ private static DependencyPrinter loadAlternateDependencyPrinter(String altDepPri
     try {
       DependencyPrinter depPrinter;
       if (depPrintArgs.length == 0) {
-        depPrinter = altDepPrinterClass.newInstance();
+        depPrinter = altDepPrinterClass.getDeclaredConstructor().newInstance();
       } else {
         depPrinter = altDepPrinterClass.getConstructor(String[].class).newInstance((Object) depPrintArgs);
       }
diff --git a/src/edu/stanford/nlp/trees/international/pennchinese/CTBErrorCorrectingTreeNormalizer.java b/src/edu/stanford/nlp/trees/international/pennchinese/CTBErrorCorrectingTreeNormalizer.java
@@ -67,7 +67,7 @@ public CTBErrorCorrectingTreeNormalizer(boolean splitNPTMP, boolean splitPPTMP,
     this.splitXPTMP = splitXPTMP;
     if (charTags) {
       try {
-        tagExtender = (TreeTransformer) Class.forName("edu.stanford.nlp.trees.international.pennchinese.CharacterLevelTagExtender").newInstance();
+        tagExtender = (TreeTransformer) Class.forName("edu.stanford.nlp.trees.international.pennchinese.CharacterLevelTagExtender").getDeclaredConstructor().newInstance();
       } catch (Exception e) {
         throw new RuntimeException(e);
       }
diff --git a/src/edu/stanford/nlp/trees/treebank/AbstractDataset.java b/src/edu/stanford/nlp/trees/treebank/AbstractDataset.java
@@ -28,7 +28,7 @@
 public abstract class AbstractDataset implements Dataset  {
 
   /** A logger for this class */
-  private static Redwood.RedwoodChannels log = Redwood.channels(AbstractDataset.class);
+  private static final Redwood.RedwoodChannels log = Redwood.channels(AbstractDataset.class);
 
   protected final List<String> outputFileList;
   protected Mapper posMapper = null;
@@ -86,14 +86,14 @@ public AbstractDataset() {
   private Mapper loadMapper(String className) {
     Mapper m = null;
     try {
-      Class c = ClassLoader.getSystemClassLoader().loadClass(className);
-      m = (Mapper) c.newInstance();
+      Class<?> c = ClassLoader.getSystemClassLoader().loadClass(className);
+      m = (Mapper) c.getDeclaredConstructor().newInstance();
     } catch (ClassNotFoundException e) {
       System.err.printf("%s: Mapper type %s does not exist\n", this.getClass().getName(), className);
-    } catch (InstantiationException e) {
+    } catch (InstantiationException | NoSuchMethodException e) {
       System.err.printf("%s: Unable to instantiate mapper type %s\n", this.getClass().getName(), className);
       e.printStackTrace();
-    } catch (IllegalAccessException e) {
+    } catch (ReflectiveOperationException e) {
       System.err.printf("%s: Unable to access mapper type %s\n", this.getClass().getName(), className);
     }
 
@@ -156,7 +156,7 @@ else if(param.equals(ConfigParser.paramMaxLen))
       else if(param.equals(ConfigParser.paramMorph))
         morphDelim = value;
       else if(param.equals(ConfigParser.paramTransform))
-        customTreeVisitor = loadTreeVistor(value);
+        customTreeVisitor = loadTreeVisitor(value);
     }
 
     if(!configuredOptions.containsAll(requiredOptions))
@@ -180,13 +180,13 @@ else if(param.equals(ConfigParser.paramTransform))
     return true;
   }
 
-  private static TreeVisitor loadTreeVistor(String value) {
+  private static TreeVisitor loadTreeVisitor(String value) {
     try {
-      Class c = ClassLoader.getSystemClassLoader().loadClass(value);
+      Class<?> c = ClassLoader.getSystemClassLoader().loadClass(value);
 
-      return (TreeVisitor) c.newInstance();
+      return (TreeVisitor) c.getDeclaredConstructor().newInstance();
 
-    } catch (ClassNotFoundException | InstantiationException | IllegalAccessException e) {
+    } catch (ReflectiveOperationException e) {
       e.printStackTrace();
     }
 
diff --git a/src/edu/stanford/nlp/trees/treebank/TreebankPreprocessor.java b/src/edu/stanford/nlp/trees/treebank/TreebankPreprocessor.java
@@ -70,15 +70,13 @@ private static Dataset getDatasetClass(Properties dsParams) {
       if(dsType == null)
         ds = new ATBArabicDataset();
       else {
-        Class c = ClassLoader.getSystemClassLoader().loadClass(dsType);
-        ds = (Dataset) c.newInstance();
+        Class<?> c = ClassLoader.getSystemClassLoader().loadClass(dsType);
+        ds = (Dataset) c.getDeclaredConstructor().newInstance();
       }
     } catch (ClassNotFoundException e) {
       System.err.printf("Dataset type %s does not exist%n", dsType);
-    } catch (InstantiationException e) {
+    } catch (ReflectiveOperationException e) {
       System.err.printf("Unable to instantiate dataset type %s%n", dsType);
-    } catch (IllegalAccessException e) {
-      System.err.printf("Unable to access dataset type %s%n", dsType);
     }
 
     return ds;
diff --git a/src/edu/stanford/nlp/trees/tregex/gui/Preferences.java b/src/edu/stanford/nlp/trees/tregex/gui/Preferences.java
@@ -132,8 +132,7 @@ static HeadFinder lookupHeadFinder(String headfinderName) {
     } else {//try to find the class
       try {
         Class<?> headfinder = Class.forName(headfinderName);
-        HeadFinder hf = (HeadFinder) headfinder.newInstance();
-        return hf;
+        return (HeadFinder) headfinder.getDeclaredConstructor().newInstance();
       } catch (Exception e) {
         return null;
       }
@@ -170,8 +169,7 @@ static TreeReaderFactory lookupTreeReaderFactory(String trfName) {
     } else {//try to find the class
       try {
         Class<?> trfClass = Class.forName(trfName);
-        TreeReaderFactory trf = (TreeReaderFactory) trfClass.newInstance();
-        return trf;
+        return (TreeReaderFactory) trfClass.getDeclaredConstructor().newInstance();
       } catch (Exception e) {
         return new PennTreeReaderFactory();
       }
diff --git a/src/edu/stanford/nlp/util/Generics.java b/src/edu/stanford/nlp/util/Generics.java
@@ -133,7 +133,7 @@ private static Constructor getHashSetCollectionConstructor() {
 
   public static <E> Set<E> newHashSet() {
     try {
-      return ErasureUtils.uncheckedCast(HASH_SET_CLASS.newInstance());
+      return ErasureUtils.uncheckedCast(HASH_SET_CLASS.getDeclaredConstructor().newInstance());
     } catch (Exception e) {
       throw new RuntimeException(e);
     }
@@ -198,7 +198,7 @@ private static Constructor getHashMapFromMapConstructor() {
   /* Maps */
   public static <K,V> Map<K,V> newHashMap() {
     try {
-      return ErasureUtils.uncheckedCast(HASH_MAP_CLASS.newInstance());
+      return ErasureUtils.uncheckedCast(HASH_MAP_CLASS.getDeclaredConstructor().newInstance());
     } catch (Exception e) {
       throw new RuntimeException(e);
     }
diff --git a/test/src/edu/stanford/nlp/util/PriorityQueueTest.java b/test/src/edu/stanford/nlp/util/PriorityQueueTest.java
@@ -21,7 +21,7 @@ public void testFixedPrioritiesPriorityQueue() {
   private static void runBasicTests(String className) {
     PriorityQueue<String> queue;
     try {
-      queue = ErasureUtils.uncheckedCast(Class.forName(className).newInstance());
+      queue = ErasureUtils.uncheckedCast(Class.forName(className).getDeclaredConstructor().newInstance());
     } catch (Exception e) {
       fail(e.toString());
       return;
@@ -48,7 +48,7 @@ protected static void runBasicTests(PriorityQueue<String> queue) {
   private static void runRelaxingTests(String className) {
     BinaryHeapPriorityQueue<String> queue;
     try {
-      queue = ErasureUtils.uncheckedCast(Class.forName(className).newInstance());
+      queue = ErasureUtils.uncheckedCast(Class.forName(className).getDeclaredConstructor().newInstance());
     } catch (Exception e) {
       fail(e.toString());
       return;
@@ -80,7 +80,7 @@ protected static void runRelaxingTests(BinaryHeapPriorityQueue<String> queue) {
   private static void runNotRelaxingTests(String className) {
     FixedPrioritiesPriorityQueue<String> pq;
     try {
-      pq = ErasureUtils.uncheckedCast(Class.forName(className).newInstance());
+      pq = ErasureUtils.uncheckedCast(Class.forName(className).getDeclaredConstructor().newInstance());
     } catch (Exception e) {
       fail(e.toString());
       return;

Original file line number	Diff line number	Diff line change
`@@ -371,7 +371,7 @@ public static String initializeAndRunCoref(Properties props) throws Exception {`
`371`	`371`	`}`
`372`	`372`	`mentionFinder = (CorefMentionFinder) Class.forName(mentionFinderClass).getConstructor(Properties.class).newInstance(mentionFinderProps);`
`373`	`373`	`} else {`
`374`		`- mentionFinder = (CorefMentionFinder) Class.forName(mentionFinderClass).newInstance();`
	`374`	`+ mentionFinder = (CorefMentionFinder) Class.forName(mentionFinderClass).getDeclaredConstructor().newInstance();`
`375`	`375`	`}`
`376`	`376`	`mentionExtractor.setMentionFinder(mentionFinder);`
`377`	`377`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1224,7 +1224,7 @@ public List<IN> classifyGibbs(List<IN> document, Triple<int[][][], int[], double`
`1224`	`1224`
`1225`	`1225`	`CRFCliqueTree<? extends CharSequence> cliqueTree = getCliqueTree(documentDataAndLabels);`
`1226`	`1226`
`1227`		`- PriorModelFactory<IN> pmf = (PriorModelFactory<IN>) Class.forName(flags.priorModelFactory).newInstance();`
	`1227`	`+ PriorModelFactory<IN> pmf = (PriorModelFactory<IN>) Class.forName(flags.priorModelFactory).getDeclaredConstructor().newInstance();`
`1228`	`1228`	`ListeningSequenceModel prior = pmf.getInstance(flags.backgroundSymbol, classIndex, tagIndex, newDocument, entityMatrices, flags);`
`1229`	`1229`
`1230`	`1230`	`if ( ! flags.useUniformPrior) {`
`@@ -2235,7 +2235,7 @@ protected void loadTextClassifier(BufferedReader br) throws Exception {`
`2235`	`2235`	`}`
`2236`	`2236`	`featureFactories = Generics.newArrayList();`
`2237`	`2237`	`for (int ff = 1; ff < featureFactoryName.length - 1; ++ff) {`
`2238`		`- FeatureFactory<IN> featureFactory = (FeatureFactory<IN>) Class.forName(featureFactoryName[1]).newInstance();`
	`2238`	`+ FeatureFactory<IN> featureFactory = (FeatureFactory<IN>) Class.forName(featureFactoryName[1]).getDeclaredConstructor().newInstance();`
`2239`	`2239`	`featureFactory.init(flags);`
`2240`	`2240`	`featureFactories.add(featureFactory);`
`2241`	`2241`	`}`