Semgrex uniqueness operation #1490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a UniqPattern which removes duplicates based on the node names given (using the values of those nodes) Add some unit testing of the uniq search parsing functionality - SemgrexParser should fail if a requested node is not in the pattern. Also, uniq should be usable as a node name Test a couple varieties of this operation To allow uniq for a ProcessSemgrexRequest, need to decode all sentences from the request first, then turn that into a response. Flip the order of matching in ProcessSemgrexRequest so that for each pattern, it matches all of the sentences at once. Allows for operations on the complete batch of matches, such as the new uniq operator We also refactor the ProcessSemgrexRequest and make the CoreNLPServer use the refactored method as well Add a test of uniq for ProcessSemgrexRequest as well (it should only produce one result now for two graphs, not two)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.