Skip to content

Commit 5d1989a

Browse files
committed
refactor(llama_index_rm): simplified class
properties. Updated requirements.txt.
1 parent f070e05 commit 5d1989a

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

dspy/retrieve/llama_index_rm.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,15 @@ class LlamaIndexRM(dspy.Retrieve):
3737
def __init__(
3838
self,
3939
retriever: BaseRetriever,
40-
k: Optional[int] = 3,
40+
k: Optional[int] = None,
4141
):
4242
self.retriever = retriever
4343

44-
if hasattr(self.retriever, "similarity_top_k"):
45-
self.retriever.similarity_top_k = k
46-
else:
47-
logging.warning(NO_TOP_K_WARNING)
44+
if k:
45+
self.k = k
4846

4947
@property
50-
def k(self) -> int:
48+
def k(self) -> Optional[int]:
5149
"""Get similarity top k of retriever."""
5250
if not hasattr(self.retriever, "similarity_top_k"):
5351
logging.warning(NO_TOP_K_WARNING)
@@ -78,10 +76,8 @@ def forward(self, query: str, k: Optional[int] = None) -> list[dspy.Example]:
7876
Returns:
7977
List[dspy.Example]: A list of examples retrieved by the retriever
8078
"""
81-
if hasattr(self.retriever, "similarity_top_k") and k:
82-
self.retriever.similarity_top_k = k
83-
else:
84-
logging.warning(NO_TOP_K_WARNING)
79+
if k:
80+
self.k = k
8581

8682
raw = self.retriever.retrieve(query)
8783

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
backoff
22
datasets
33
joblib<=1.3.2
4+
llama-index>=0.10.30
45
openai>=0.28.1,<2.0.0
56
optuna
67
pandas

0 commit comments

Comments
 (0)