Skip to content

Commit 9331fed

Browse files
committed
keep using zero_scores size instead of checking 0.0 value
1 parent 1666c6e commit 9331fed

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

stanza/models/coref/model.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -512,13 +512,11 @@ def train(self, log=False):
512512
else:
513513
s_loss = torch.zeros_like(c_loss)
514514

515-
del res
516-
517515
(c_loss + s_loss + z_loss).backward()
518516

519517
running_c_loss += c_loss.item()
520518
running_s_loss += s_loss.item()
521-
if z_loss:
519+
if res.zero_scores.size(0) == 0:
522520
running_z_loss += z_loss.item()
523521

524522
# log every 100 docs
@@ -527,12 +525,11 @@ def train(self, log=False):
527525
'train_c_loss': c_loss.item(),
528526
'train_s_loss': s_loss.item(),
529527
}
530-
if z_loss:
528+
if res.zero_scores.size(0) == 0:
531529
logged['train_z_loss'] = z_loss.item()
532530
wandb.log(logged)
533531

534-
535-
del c_loss, s_loss, z_loss
532+
del c_loss, s_loss, z_loss, res
536533

537534
for optim in self.optimizers.values():
538535
optim.step()

0 commit comments

Comments
 (0)