Skip to content

Commit cdb40e7

Browse files
jrmccluskeystankiewicz
authored andcommitted
Fix env variable loading in Cost Benchmark workflow (apache#33404)
* Fix env variable loading in Cost Benchmark workflow * fix output file for tf mnist * add load test requirements file arg * update mnist args * revert how args are passed * assign result correctly
1 parent ec72833 commit cdb40e7

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/beam_Python_CostBenchmarks_Dataflow.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ jobs:
9292
-PloadTest.mainClass=apache_beam.testing.benchmarks.wordcount.wordcount \
9393
-Prunner=DataflowRunner \
9494
-PpythonVersion=3.10 \
95-
'-PloadTest.args=${{ env.beam_Inference_Python_Benchmarks_Dataflow_test_arguments_1 }} --job_name=benchmark-tests-wordcount-python-${{env.NOW_UTC}} --output_file=gs://temp-storage-for-end-to-end-tests/wordcount/result_wordcount-${{env.NOW_UTC}}.txt' \
95+
'-PloadTest.args=${{ env.beam_Python_Cost_Benchmarks_Dataflow_test_arguments_1 }} --job_name=benchmark-tests-wordcount-python-${{env.NOW_UTC}} --output_file=gs://temp-storage-for-end-to-end-tests/wordcount/result_wordcount-${{env.NOW_UTC}}.txt' \
9696
- name: Run Tensorflow MNIST Image Classification on Dataflow
9797
uses: ./.github/actions/gradle-command-self-hosted-action
9898
timeout-minutes: 30
@@ -102,4 +102,5 @@ jobs:
102102
-PloadTest.mainClass=apache_beam.testing.benchmarks.inference.tensorflow_mnist_classification_cost_benchmark \
103103
-Prunner=DataflowRunner \
104104
-PpythonVersion=3.10 \
105-
'-PloadTest.args=${{ env.beam_Inference_Python_Benchmarks_Dataflow_test_arguments_2 }} --job_name=benchmark-tests-tf-mnist-classification-python-${{env.NOW_UTC}} --input_file=gs://apache-beam-ml/testing/inputs/it_mnist_data.csv --output_file=gs://temp-storage-for-end-to-end-tests/wordcount/result_tf_mnist-${{env.NOW_UTC}}.txt --model=gs://apache-beam-ml/models/tensorflow/mnist/' \
105+
-PloadTest.requirementsTxtFile=apache_beam/ml/inference/tensorflow_tests_requirements.txt \
106+
'-PloadTest.args=${{ env.beam_Python_Cost_Benchmarks_Dataflow_test_arguments_2 }} --job_name=benchmark-tests-tf-mnist-classification-python-${{env.NOW_UTC}} --input_file=gs://apache-beam-ml/testing/inputs/it_mnist_data.csv --output_file=gs://temp-storage-for-end-to-end-tests/inference/result_tf_mnist-${{env.NOW_UTC}}.txt --model=gs://apache-beam-ml/models/tensorflow/mnist/' \

sdks/python/apache_beam/testing/benchmarks/inference/tensorflow_mnist_classification_cost_benchmark.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def test(self):
3131
extra_opts['input'] = self.pipeline.get_option('input_file')
3232
extra_opts['output'] = self.pipeline.get_option('output_file')
3333
extra_opts['model_path'] = self.pipeline.get_option('model')
34-
tensorflow_mnist_classification.run(
34+
self.result = tensorflow_mnist_classification.run(
3535
self.pipeline.get_full_options_as_args(**extra_opts),
3636
save_main_session=False)
3737

0 commit comments

Comments
 (0)