fix: fix bug in get_products where end was not being propery calculated by being calculated before new start index

Author: theodorehreuter

src/stapi_fastapi/routers/root_router.py

@@ -145,14 +145,13 @@ def get_products(
     ) -> ProductsCollection:
         start = 0
         product_ids = [*self.product_routers.keys()]
-        end = min(start + limit, len(product_ids))
         try:
             if next:
                 start = product_ids.index(next)
         except ValueError:
             logging.exception("An error occurred while retrieving orders")
             raise NotFoundException(detail="Error finding pagination token") from None
-
+        end = min(start + limit, len(product_ids))
         ids = product_ids[start:end]
         links = [
             Link(

tests/test_product.py

@@ -71,17 +71,20 @@ def test_product_pagination(stapi_client: TestClient, limit: int):
     assert res.status_code == status.HTTP_200_OK
     body = res.json()
     assert len(body["products"]) == limit
+    links = body["links"]
     for d in body["links"]:
         if ("rel", "next") in d.items():
             next = d["href"]
 
-    while len(body["links"]) > 1:
+    while len(links) > 1:
         res = stapi_client.get(next)
         assert res.status_code == status.HTTP_200_OK
         body = res.json()
-        assert len(body["products"]) == limit
+        assert body["products"] != []
+        links = body["links"]
         for d in body["links"]:
             if ("rel", "next") in d.items():
+                assert len(body["products"]) == limit
                 next = body["links"][0]["href"]